From:	lauras AT softhome DOT net
Message-ID:	<20010217091528.4337.qmail@softhome.net>
References:	<20010216102653 DOT 32267 DOT qmail AT softhome DOT net>
	<2110-Sat17Feb2001094540+0200-eliz AT is DOT elta DOT co DOT il>
In-Reply-To:	<2110-Sat17Feb2001094540+0200-eliz@is.elta.co.il>
To:	Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
Cc:	djgpp-workers AT delorie DOT com
Subject:	Re: djtar: skipping directories
Date:	Sat, 17 Feb 2001 09:15:28 GMT
Mime-Version:	1.0
X-Sender:	lauras AT softhome DOT net
Reply-To:	djgpp-workers AT delorie DOT com

The updated patch will be delayed, because one disk partition
in my sand box fried.

> One-space-after-period strikes again ;-)

Ugh... OK. Will fix that.

> Texinfo sources should use `` and '', not " and ", to quote text.
> (Yes, this is a bug in the original version.)

OK.

> I think ``several'' is better here than ``few''.

OK.

> Shouldn't you simply use xmalloc?

xmalloc() is some other function in djtar. From zlib, IIRC.

> That is, you want to skip that file or directory.  Given this line,
> the above code would skip all files whose names begin with
> "/foo/bar/baz", including, for example, "/foo/bar/bazilicum.c" and
> "/foo/bar/bazillion/xyzzy".

Errm... And this is wrong? But this is the behaviour `-o' documentation
suggests. I'll fix code here and docs there.

> If we are cautious about NULL pointers being returned by malloc, why
> not do the same for strdup?

Ah, OK, xstrdup to come.

Laurynas

- Raw text -