delorie.com/archives/browse.cgi   search  
Mail Archives: djgpp-workers/2001/01/31/04:14:46

Date: Wed, 31 Jan 2001 11:11:35 +0200 (IST)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender: eliz AT is
To: Martin Stromberg <eplmst AT lu DOT erisoft DOT se>
cc: djgpp-workers AT delorie DOT com
Subject: Re: Bug000323
In-Reply-To: <200101310852.JAA06693@lws256.lu.erisoft.se>
Message-ID: <Pine.SUN.3.91.1010131110650.29266c-100000@is>
MIME-Version: 1.0
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com

On Wed, 31 Jan 2001, Martin Stromberg wrote:

> > > Index: src/libc/ansi/stdio/doprnt.c
> > > +
> > > +  if (fp->_flag & _IOAPPEND)
> > > +  {
> > > +    if ( llseek(fileno(fp), 0, SEEK_END) == -1 )
> > > +    {
> > > +      return (EOF);
> > > +    }
> > > +  }
> > 
> > This shouldn't be needed; the flsbuf() call should move to EOF.
> 
> Well, I tried without it and it didn't work.

Are you sure you tried this with a handle which had _IOAPPEND flag set, 
and with _flsbuf doing the Right Thing with _IOAPPEND?

I don't see how could this not work, since _doprnt always calls putc to 
output the text, and putc always calls _flsbuf.

(Btw, you should avoid doing anything in _dpornt that assumes `fp' is a 
real FILE object.  See sprintf for the reason why.)

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019