Date:	Sat, 25 Nov 2000 18:19:02 +0200
From:	"Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender:	halo1 AT zahav DOT net DOT il
To:	djgpp-workers AT delorie DOT com
Message-Id:	<2561-Sat25Nov2000181901+0200-eliz@is.elta.co.il>
X-Mailer:	Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.6
CC:	ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De
In-reply-to:	<Pine.A41.4.05.10011251321540.82314-100000@ieva06.lanet.lv>
	(message from Andris Pavenis on Sat, 25 Nov 2000 14:18:19 +0200 (WET))
Subject:	Re: Patch #3 for dtou.c
References:	<Pine DOT A41 DOT 4 DOT 05 DOT 10011251321540 DOT 82314-100000 AT ieva06 DOT lanet DOT lv>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Sat, 25 Nov 2000 14:18:19 +0200 (WET)
> From: Andris Pavenis <pavenis AT lanet DOT lv>
> 
> Perhaps there is no need to convert argv[0] to lowercase to print usage
> info. Function strlwr() used for this purpose is not portable (not ANSI,not
> POSIX). As result dtou.c is not compiling for me on Linux (glibc-2.2) and
> under AIX 4.3.1 on RS6000.

I agree that non-Posix functions should not be used.

> Also we should strip path from argv[0] for displaying usage info

This is nice, but not necessary: most of the programs used in the
DJGPP development don't bother to do that (it's not needed on Unix,
usually).

> Also I think it's better to return 0 unless return code is explicitly
> requested by some command line parameter.

That would be incompatible with the original version: it returned
non-zero exit status when, for example, one of the files didn't exist
or couldn't be open/read.

> I'm including patch with following fixes:

Applied.

Thanks!

- Raw text -