Mail Archives: djgpp-workers/2000/08/31/05:02:47
On 30 Aug 2000, at 15:43, Eli Zaretskii wrote:
>
> On Wed, 30 Aug 2000, Laurynas Biveinis wrote:
>
> > Juan Manuel Guerrero wrote:
> > > In conio.[ch] I have renamed gettext to _conio_gettext.
> > > In conio.h I have added same minor code that will check
> > > if libintl.h has also been included. In this case, gettext
> > > from conio.h will be **only** available as _conio_gettext.
> >
> > Is it OK to commit libc changes? IMHO it's the best
> > solution. If nobody speaks up in a following day or two,
> > I commit it.
>
> I wouldn't recommend to commit them, at least until Andris and/or SET say
> that this new port indeed solves the problems between conio and gettext.
> We don't have any reason to hurry, so it's better to be sure this
> solution is okay.
I think all we should have is that the result of including both conio.h
and libintl.h does not depend on order of include statements. So
perhaps
#define gettext _conio_gettext
in conio.h only if libintl.h is not included and
#undef gettext
in libintl.h if conio.h is already included should be Ok.
Andris
- Raw text -