Message-Id:	<200008120847.EAA11903@delorie.com>
Date:	Sat, 12 Aug 2000 11:50:21 +0200
To:	tr AT eth DOT net
X-Mailer:	Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b
From:	"Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
CC:	djgpp-workers AT delorie DOT com
In-reply-to:	<003201c003be$55b0e5e0$26b5c5cb@trr>
Subject:	Re: Sh-utils 2.0j sources uploaded
References:	<Pine DOT LNX DOT 4 DOT 21 DOT 0007250651010 DOT 823-100000 AT midpec DOT com> <09c901510100b80CHNSPLP02 AT eth DOT net> <003201c003be$55b0e5e0$26b5c5cb AT trr>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> From: "Prashant TR" <tr AT eth DOT net>
> Date: Fri, 11 Aug 2000 23:24:45 +0530
> >
> > The DJGPP-specific fragment in tee.c which sets mode_string to "ab" or
> > "wb", should, I think be replaced by a SET_BINARY call on the file
> > descriptor returned by `fopen'.  I think Jim Meyering explicitly
> > requested that.
> 
> I've done this, too, in the patches I sent to Jim. I had also CCed them to
> you.

Yes, I vaguely remembered that, but probably didn't save that mail.  I
looked at the file DIFFS in shl20js.zip when replying to your message.

> > About the value of default_shells[] in getusershell.c: perhaps instead
> > of the environment variable (which Jim Meyering didn't like), it's
> > better to (1) add "/dev/env/DJDIR/bin/bash.exe" to the list, and (2)
> > define SHELLS_FILE to "/dev/env/DJDIR/etc/shells" (and add an empty
> > file to the binary distro), so that users could add/edit that file if
> > their shell isn't in the list.
> 
> Done. Check the patch below. If it works fine, I'll send them to Jim.

Will do.

- Raw text -