X-Authentication-Warning:	hp2.xraylith.wisc.edu: khan owned process doing -bs
Date:	Sun, 9 Jan 2000 12:41:31 -0600 (CST)
From:	Mumit Khan <khan AT NanoTech DOT Wisc DOT EDU>
To:	Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
cc:	djgpp-workers AT delorie DOT com
Subject:	Re: (patch) updated protoize patch
In-Reply-To:	<Pine.SUN.3.91.1000109101728.23866n-100000@is>
Message-ID:	<Pine.HPP.3.96.1000109123909.17518A-100000@hp2.xraylith.wisc.edu>
MIME-Version:	1.0
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	dj-admin AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On Sun, 9 Jan 2000, Eli Zaretskii wrote:

> Thanks.  The changes seem okay, but the following hunk bothers me:
> 
> @@ -2032,7 +2128,11 @@ munge_compile_params (params_list)
>  
>    temp_params[param_count++] = "-S";
>    temp_params[param_count++] = "-o";
> +#if defined (__MSDOS__) || (defined (_WIN32) && ! defined (__CYGWIN__) && ! defined (_UWIN))
> +  temp_params[param_count++] = "NUL:";
> +#else
>    temp_params[param_count++] = "/dev/null";
> +#endif
>  
>    /* Leave room for the input file name argument.  */
>    input_file_name_index = param_count;
> 
> I'm afraid that "NUL:" (with the colon) won't work for DJGPP, since
> the device name is just "NUL".  I don't have GCC sources installed, so
> can someone please test this?
> 
> If it doesn't work, then we have two alternatives:
> 
>   - use "NUL" instead, I think it should work for Mingw and Cygwin as
>     well;
> 
>   - if "NUL" doesn't work for Mingw and Cygwin, leave "NUL:" for them
>     only, and use "/dev/null" for DJGPP (by removing __MSDOS__ from
>     the #ifdef).


Yikes. I actually didn't have __MSDOS__ in the earlier patch, but someone
suggested I add that as well. The ':' in NUL: is a typo there. 
Please try out without it (ie., /dev/null for djgpp), and if it works 
for djgpp, I'll update the GCC mainline as well accordingly.

Regards,
Mumit

- Raw text -