Date:	Tue, 8 Sep 1998 14:46:29 -0400 (EDT)
Message-Id:	<199809081846.OAA25391@delorie.com>
From:	DJ Delorie <dj AT delorie DOT com>
To:	snowball3 AT usa DOT net
CC:	djgpp-workers AT delorie DOT com
In-reply-to:	<199809081729.RAA184144@out2.ibm.net> (snowball3@usa.net)
Subject:	Re: Revised proposed patch to djtypes.h

> --- djtypes.h	Tue Sep  8 12:27:16 1998
> +++ c:\temp\include\sys\djtypes.h	Sun Oct 30 01:22:34 1994

NEVER send patches to me with backslashes.  Always use forward
slashes.  I apply these diffs on a Unix machine, which doesn't
understand reverse slashes.

Please avoid DOS drive letters completely.  You should run diff from
the top of the source tree (yours would have said include/sys/djtypes.h
if done right).

> @@ -11,13 +11,6 @@

Please use "diff -c3"

> -#  define __DJ_wchar_t

Bad style.  No spaces after the '#'

> -// ... but remains a typedef in C

This is NOT a valid C comment

> -#  define __DJ_wchar_t    typedef int wchar_t;
> -#endif
> +#define __DJ_wchar_t	typedef int wchar_t;

Your diffs are reversed.  Always list the OLD file FIRST, and the new
file second.

- Raw text -