Mail Archives: djgpp-workers/1998/01/27/07:47:46
On Mon, 26 Jan 1998, Randy Maas wrote:
> Previously I had suggested that maybe opening the file and the
> fstat'ing it would be a good way to keep things simple.
> I've decided not to propose that
I agree that this is not a good idea, since it may fail due to
shortage of file handles. Also, installing a handler for fstat (which
is a handle-based function) when you really want a handler based on a
file name is counter-intuitive.
> *** src\libc\posix\sys\stat\stat.c~1 Sun Nov 16 14:04:58 1997
> --- src\libc\posix\sys\stat\stat.c Mon Jan 26 15:01:46 1998
You should *never* use backslashes in diffs, since people might apply
them on Unix machines, where it will fail miserably.
> +
> + if (__FSEXT_call_open_handlers(__FSEXT_stat, &ret, &path))
> + return ret;
This doesn't pass `statbuf' to the handler. How on earth is this
supposed to work?
- Raw text -