X-Authentication-Warning:	delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient:	djgpp AT delorie DOT com
X-Recipient:	dj AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=skdcwjJ2KWspiX6VH/7ZhfbgY6xA9PVWI7ebPa0hhe4=; b=hTpb5Kd26c26
	H6mj+o4SMGYThvbYCqytJGI7YzANr0icBYEIOLTj6UUZFMfj4swxEtnwRutCwZk5SQLuAP7tVZCB5
	kvqFsn/4QfT1dmcppUGxPr4JeB93ZwQ9ZpaSi/J1dG0m7gBWDgQkSi0TaIv6kWMNbY5j9DBz1psAQ
	rvfU5b6kPo40tVc/DiOCfszMg1nc4b1m6rkFpqbXhZTUdBRXfboFLkxg1sVRX70QO8sFIa/c6/7zC
	0rLWdaem9Z2/B8iWg9z4LFdihYYdK48ECijPuKFDvA+kx8AkyEP2fWusKp3ljRR4gBsVz9FyKzZIz
	WuURMedtizQkv1uoZd47VQ==;
Date:	Sat, 13 Apr 2024 14:51:17 +0300
Message-Id:	<86edb9pjka.fsf@gnu.org>
From:	"Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
To:	Pali <pali AT pali DOT im>
Cc:	dj AT delorie DOT com, sezeroz AT gmail DOT com, djgpp AT delorie DOT com
In-Reply-To:	<20240413103741.wpz7cy3ff3uaflo6@pali> (message from Pali on Sat,
	13 Apr 2024 12:37:41 +0200)
Subject:	Re: Error handling in __djgpp_set_page_attributes()
References:	<20240413103741 DOT wpz7cy3ff3uaflo6 AT pali>
Reply-To:	djgpp AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Sat, 13 Apr 2024 12:37:41 +0200
> From: Pali <pali AT pali DOT im>
> Cc: djgpp AT delorie DOT com
> 
> Hello, I have there a change for __djgpp_set_page_attributes() function
> which sets more sane errno value on different failures. Could you look
> at it if it is useful?

Thanks.  I think this can be useful, but I'd prefer to keep the style
of having just one exit point in this function.  So could you please
rewrite the patch so that the various conditions only set errno, and
still "goto fail"?

- Raw text -