X-Authentication-Warning:	delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient:	djgpp AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=UGZOG7wh3OzL0Ar/qzbPDuRIEIJwzb21p86EQnksSzk=; b=rAFWEp7M1h7M
	F9RDrT1TJv8THAsYUKeMV6AT+/T70vrl72WlyQFEcicN7RHhLshOc5Qxtwa6Z9cd6juxd0vcCGrmm
	HjsF/QVpjvCO7qDDBu9BGefApSO6WjOEtr84GQt7cA0mM8R6huxK462ii7AQe4eAIA+AxBWIiZzXc
	mjKe+UacLBfIosKIz3m0uRjoNhhj0cKklo1qoALQgPBNOYPiU5ZPeuWN0hEHTY4rXCQE6Xhh5HFja
	WmhZJTpKTnlfmlTeNbEv6d8MMbAn2ypwSFEfsKsNZ3SKFjatCJeV2rL9vVZBjhvU3+/SJpRu0CQEc
	AcPPR2DzYJodhLDwvLIrpw==;
Date:	Mon, 30 Jan 2023 20:02:43 +0200
Message-Id:	<835ycn529o.fsf@gnu.org>
From:	"Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
To:	djgpp AT delorie DOT com
In-Reply-To:
	<CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ AT mail DOT gmail DOT com>
	(djgpp AT delorie DOT com)
Subject:	Re: [PATCH] dxe3gen: add support for using an exports file.
References:	<CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ AT mail DOT gmail DOT com>
Reply-To:	djgpp AT delorie DOT com

> From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
> Date: Mon, 30 Jan 2023 20:27:51 +0300
> 
> The patch inlined below (also attached for convenience) adds support for
> using an exports file to dxe3gen.
> 
> The existing mechanism for exported symbols is through symbol prefixes,
> i.e. the -E and -X switches, but can be really hard to use especially if
> there are many symbols which don't necessarily share a common prefix, or
> if some of the symbols to exclude share the common prefix with symbols
> to export.
> 
> The exports file is a plain text file with one symbol name at each line,
> like an exports file that can be used in macOS projects. No trailing or
> leading space/tab should be used in the file. A line starting with a '#'
> character is a comment line and will be ignored.
> 
> The -E and -X switches are still supported, but those two are mutually
> exclusive.
> 
> Eli, Juan, DJ:  Please review. OK to apply?

LGTM, but why did you use binary mode for reading the exports file?

- Raw text -