X-Authentication-Warning:	delorie.com: mail set sender to djgpp-bounces using -f
X-Received:	by 10.66.236.41 with SMTP id ur9mr25216039pac.12.1442427897067;
	Wed, 16 Sep 2015 11:24:57 -0700 (PDT)
X-Received:	by 10.182.105.230 with SMTP id gp6mr127416obb.12.1442427897025;
	Wed, 16 Sep 2015 11:24:57 -0700 (PDT)
Newsgroups:	comp.os.msdos.djgpp
Date:	Wed, 16 Sep 2015 11:24:56 -0700 (PDT)
In-Reply-To:	<CAA2C=vC4D8sm=3JMbLGAL-cPq7xAMZg32FCU0hezBrhkK9K9kA@mail.gmail.com>
Complaints-To:	groups-abuse AT google DOT com
Injection-Info:	glegroupsg2000goo.googlegroups.com; posting-host=46.5.89.220; posting-account=OsAajgoAAADdKJnkJkmhzqP0jo6I_P_0
NNTP-Posting-Host:	46.5.89.220
References:	<CAA2C=vCi88BYHh-yRXvtx8az13Y9wymqkjs93UJHx=qaZRPOGQ AT mail DOT gmail DOT com>
	<cae6b037-4d08-4255-aa4f-d423a86a0d1c AT googlegroups DOT com> <83d1xi6ye1 DOT fsf AT gnu DOT org>
	<CAA2C=vC4D8sm=3JMbLGAL-cPq7xAMZg32FCU0hezBrhkK9K9kA AT mail DOT gmail DOT com>
User-Agent:	G2/1.0
MIME-Version:	1.0
Message-ID:	<b27e79c8-8084-44f0-81c6-4487d88840c2@googlegroups.com>
Subject:	Re: dlopen.c: make sure filename is not NULL and not empty
From:	"Juan Manuel Guerrero (juan DOT guerrero AT gmx DOT de) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
Injection-Date:	Wed, 16 Sep 2015 18:24:57 +0000
Bytes:	3677
Lines:	62
To:	djgpp AT delorie DOT com
DJ-Gateway:	from newsgroup comp.os.msdos.djgpp
Reply-To:	djgpp AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On Wednesday, September 16, 2015 at 8:07:44 PM UTC+2, Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com] wrote:
> On 9/16/15, Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]
> <djgpp AT delorie DOT com> wrote:
> >> Date: Wed, 16 Sep 2015 10:14:40 -0700 (PDT)
> >> From: "Juan Manuel Guerrero (juan DOT guerrero AT gmx DOT de) [via
> >> djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
> >>
> >> On Wednesday, September 16, 2015 at 2:39:19 PM UTC+2, Ozkan Sezer
> >> (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com] wrote:
> >> > If there are no objections, I want to apply the following
> >> > patch to both HEAD and to v2_05_1.  dlopen(NULL,mode) is
> >> > supported by glibc but not by djgpp, and such a call left
> >> > unchecked will result in Bad Things (TM) to happen.
> >> >
> >> > Index: dlopen.c
> >> > ===================================================================
> >> > RCS file: /cvs/djgpp/djgpp/src/libc/dxe/dlopen.c,v
> >> > retrieving revision 1.9
> >> > diff -u -p -r1.9 dlopen.c
> >> > --- dlopen.c	21 Aug 2015 18:10:28 -0000	1.9
> >> > +++ dlopen.c	16 Sep 2015 12:02:07 -0000
> >> > @@ -119,6 +119,11 @@ void *dlopen(const char *filename, int m
> >> >    _dl_unresolved_count = 0;
> >> >    errno = 0;
> >> >
> >> > +  if (!filename || !*filename) {
> >> > +    errno = EINVAL;
> >> > +    return NULL;
> >> > +  }
> >> > +
> >> >    /* Find the dynamic module along the LD_LIBRARY_PATH */
> >> >    if (!ACCESS(filename))
> >> >    {
> >>
> >>
> >> Looks ok to me but my man page tells something like this:
> >> "If filename is NULL, then the returned handle is for the  main
> >> program."
> >> What shall this imply for DJGPP?
> >
> > This feature is for when the function is already statically linked
> > into the main program.
> 
> Yes, useful in such a case too
> 
> >  Can we support this in DJGPP?
> 
> Someone will need to implement that, but for 2.06 I think
> 
> >  If not, we should return ENOSYS or some such.
> >
> 
> I used EINVAL, because NULL or "" filename is already an invalid
> argument for the current implementation, and ENOSYS would be a
> misleading errno.  What do the others think?
> 
> --
> O.S.

When this has clarified we will need a new djdev205.zip, etc... before we can proceed.

Regards,
Juan M. Guerrero

- Raw text -