X-Authentication-Warning:	delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient:	djgpp AT delorie DOT com
Date:	Sun, 24 May 2015 12:24:32 +0300
Sun-Java-System-SMTP-Warning:	Lines longer than SMTP allows found and truncated.
From:	"Eli Zaretskii (eliz AT gnu DOT org)" <djgpp AT delorie DOT com>
Subject:	Re: New GDB versions and DJGPP (Was: ANNOUNCE: DJGPP 2.05 beta 1)
In-reply-to:	<55618917.7080608@iki.fi>
X-012-Sender:	halo1 AT inter DOT net DOT il
To:	djgpp AT delorie DOT com
Message-id:	<83d21q1g6n.fsf@gnu.org>
References:	<201505042003 DOT t44K3odg011007 AT delorie DOT com> <55579278 DOT 8090301 AT iki DOT fi> <CAA2C=vBaQKzmch_buxFm20DJLcG+zv6d6803+qMEx=baA4Frog AT mail DOT gmail DOT com> <555829A6 DOT 8010502 AT iki DOT fi> <CAA2C=vA73qPvoDFytp3FeW6bCD1-XuGsFFoDinoKn2KYY1fkow AT mail DOT gmail DOT com> <555870E8 DOT 7040302 AT iki DOT fi> <CAA2C=vDhD6BJj89o1i0FRd2U0H4bTpGGN4zH6qs7FJKxzqhuQg AT mail DOT gmail DOT com> <201505180114 DOT t4I1EiaX017288 AT envy DOT delorie DOT com> <CAA2C=vCyrQ_+Yq6XsRD-UO4r=j9WoGGiXoqQFrkbiEQpzX+=MA AT mail DOT gmail DOT com> <201505181216 DOT t4ICGaKO014123 AT envy DOT delorie DOT com> <CAA2C=vCk5MY74z+HNVzzdLByg71Y_9ObK-1jPxJ_KF8eqRDZMQ AT mail DOT gmail DOT com> <83zj52dkns DOT fsf AT gnu DOT org> <CAA2C=vAPcN+MKC_2tcZqVmo9gvF2Cxdo+K+-qfKaNrQuCkMnEw AT mail DOT gmail DOT com> <555A0DD5 DOT 1010607 AT iki DOT fi> <83r3qdemuj DOT fsf AT gnu DOT org> <555AADE6 DOT 3030905 AT iki DOT f> <83lhgkehn4 DOT fsf AT gnu DOT org> <201505191714 DOT t4JHEr0B010992 AT envy DOT delorie DOT com> <83vbfo7a74 DOT fsf AT gnu DOT org> <201505191729 DOT t4JHTIRe011541 AT envy DOT delorie DOT com>
	<83sias77km DOT fsf AT gnu DOT org> <555CFF9C DOT 1050301 AT gmx DOT de> <555D5E30 DOT 7020107 AT iki DOT fi> <83vbfl6hs9 DOT fsf AT gnu DOT org> <55618917.7@[87.69.4.28]>
Reply-To:	djgpp AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Sun, 24 May 2015 11:17:27 +0300
> From: "Andris Pavenis (andris DOT pavenis AT iki DOT fi)" <djgpp AT delorie DOT com>
> 
> > So what and how goes wrong in the DJGPP build of GDB?  Can someone
> > with enough free time step through the go32 initialization, and see
> > what's wrong there?
> 
> Perhaps at least some hint could give GDB commit which caused that DJGPP port stopped to work (with 
> symptoms described earlier)
> 
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=9b409511d07fe375284701af34909fb539029caf

Thanks!

Actually, it seems bd265cd0bde9e045ab5946532449430b66fe91ad, which is
a followup to the one you mentioned, is the bad commit.  It seems a
simple case of misunderstanding the API conventions of our read_child
and write_child.

Can you try the patch below?  If it fixes the problem, I will push it.

diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c
index f3966cd..852473b 100644
--- a/gdb/go32-nat.c
+++ b/gdb/go32-nat.c
@@ -587,6 +587,13 @@
   else
     res = read_child (memaddr, readbuf, len);
 
+  /* read_child and write_child return zero on success, non-zero on
+     failure; adjust the result value to that.  */
+  if (res == 0)
+    res = len;
+  else
+    res = -1;
+
   if (res <= 0)
     return TARGET_XFER_E_IO;
 

- Raw text -