X-Authentication-Warning:	delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient:	djgpp AT delorie DOT com
Date:	Sat, 16 Aug 2014 22:32:13 +0300
From:	Eli Zaretskii <eliz AT gnu DOT org>
Subject:	Re: Emacs pretest 24.3.93
In-reply-to:	<53EFAF05.2010005@gmx.de>
X-012-Sender:	halo1 AT inter DOT net DOT il
To:	djgpp AT delorie DOT com
Message-id:	<834mxcdyde.fsf@gnu.org>
References:	<83egwim872 DOT fsf AT gnu DOT org> <53EF1E40 DOT 6050004 AT gmx DOT de> <83k368ekyk DOT fsf AT gnu DOT org> <53EFAF05 DOT 2010005 AT gmx DOT de>
Reply-To:	djgpp AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Sat, 16 Aug 2014 21:20:37 +0200
> From: Juan Manuel Guerrero <juan DOT guerrero AT gmx DOT de>
> 
> I will investigate this but it seems to be a DJGPP 2.04 issue.  I will answer
> ASAP.

Thanks.

> I have also tried djdev203 and it was possible to compile it out-of-the box
> and seems to work.  Neither less the emacs code expects that the library
> provides snprintf, but this is not the case for djdev203.  This is also the
> case for many other GNU ports I have done lately where I had to add
> to the sources the snprintf code taken from the repository so they can
> be compiled with DJGPP 2.03.

Not sure why you needed to add snprintf, as it is already provided in
sysdep.c.  In src/config.h, we have:

  /* Define to 1 if you have the `snprintf' function. */
  #if __DJGPP__ > 2 || __DJGPP_MINOR__ > 3
  #define HAVE_SNPRINTF 1
  #else
  #undef HAVE_SNPRINTF
  #endif

So HAVE_SNPRINTF should not be defined when building with DJGPP v2.03,
and the replacement in sysdep.c, which is enabled when HAVE_SNPRINTF
is not defined, should have worked.  Can you see why it didn't work
for you?

> I got this error message:
> 
> [snip]
> gcc -c -I../msdos -Demacs  -I. -I../lib           -O2  font.c
> font.c: In function 'font_unparse_xlfd':
> font.c:1330:9: warning: incompatible implicit declaration of built-in function 'snprintf' [enabled by default]

These are warnings, not errors.  I guess we need to add a prototype
for snprintf somewhere, to pacify the newer compilers, is that right?

Thanks for testing Emacs.

- Raw text -