delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin-developers/2001/10/23/01:24:07

Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Message-ID: <03d801c15b83$663928f0$0200a8c0@lifelesswks>
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>,
<cygwin-developers AT cygwin DOT com>
References: <20011022142729 DOT A10309 AT redhat DOT com> <20011022192430 DOT 3581 DOT qmail AT lizard DOT curl DOT com> <20011022193036 DOT 3609 DOT qmail AT lizard DOT curl DOT com> <20011022203136 DOT 5144 DOT qmail AT lizard DOT curl DOT com> <20011022203747 DOT 5162 DOT qmail AT lizard DOT curl DOT com> <02a201c15b5b$7910a4d0$0200a8c0 AT lifelesswks> <20011022204740 DOT B18754 AT redhat DOT com> <20011023005236 DOT 7136 DOT qmail AT lizard DOT curl DOT com> <20011022205828 DOT C18754 AT redhat DOT com> <02ea01c15b5f$7e673bc0$0200a8c0 AT lifelesswks> <20011022212759 DOT A19493 AT redhat DOT com> <035a01c15b6b$e7788c70$0200a8c0 AT lifelesswks> <039401c15b74$3555bd70$0200a8c0 AT lifelesswks> <03d201c15b83$0e480990$0200a8c0 AT lifelesswks>
Subject: Re: 1.3.4 status?
Date: Tue, 23 Oct 2001 15:27:24 +1000
MIME-Version: 1.0
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4133.2400
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
X-OriginalArrivalTime: 23 Oct 2001 05:32:05.0990 (UTC) FILETIME=[0D4AC860:01C15B84]

and this patch fixes it.

Index: fhandler_console.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/fhandler_console.cc,v
retrieving revision 1.66
diff -u -p -r1.66 fhandler_console.cc
--- fhandler_console.cc 2001/10/22 18:39:22     1.66
+++ fhandler_console.cc 2001/10/23 05:23:17
@@ -54,7 +54,7 @@ cp_convert (UINT destcp, char * dest, UI
     }
   else
     {
-      WCHAR wbuffer[CONVERT_LIMIT]; /* same size as the maximum input,
s.b. */
+      WCHAR *wbuffer = (WCHAR *) alloca (CONVERT_LIMIT); /* same size
as the maximum inpu
t, s.b. */
       if (!MultiByteToWideChar (srccp, 0, src, size, wbuffer, sizeof
(wbuffer)))
        return FALSE;
       if (!WideCharToMultiByte (destcp, 0, wbuffer, size, dest, size,

Have fun!

Rob

----- Original Message -----
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>;
<cygwin-developers AT cygwin DOT com>
Sent: Tuesday, October 23, 2001 3:24 PM
Subject: Re: 1.3.4 status?


> got the culprit.
>
> con_to_str calls cp_convert which inlines with -finline-functions. The
> buffer there is what is getting allocated.
>
> Rob
>
>

- Raw text -


  webmaster     delorie software   privacy  
  Copyright 2019   by DJ Delorie     Updated Jul 2019