delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin-developers/1999/01/29/20:53:52

From: fujieda AT jaist DOT ac DOT jp (Kazuhiro Fujieda)
Subject: binmode handling in fhandler.cc
29 Jan 1999 20:53:52 -0800 :
Message-ID: <wkvhhpfkrc.fsf.cygnus.cygwin32.developers@indra.will.or.jp>
Mime-Version: 1.0 (generated by SEMI MIME-Edit 0.100 - "Shijima")
To: cygwin32-developers AT cygnus DOT com

In the snapshot since 19990122, `binmode' specified by the
CYGWIN variable or the mount flag, has no effect on fopen()
without binary flag "b". This is incompatible with the previous
release.

This problem is caused by fhandler.cc:311.

310:  int bin;
311:  if (flags & (O_BINARY | O_TEXT))
312:    bin = flags & O_TEXT ? 0 : O_BINARY;
313:  else if (get_device () == FH_DISK)

fopen() always set O_BINARY or O_TEXT to the `flags'. I think
this should check only O_BINARY flag, same as the previous
release.
____
  | AIST      Kazuhiro Fujieda <fujieda AT jaist DOT ac DOT jp>
  | HOKURIKU  School of Information Science
o_/ 1990      Japan Advanced Institute of Science and Technology

- Raw text -


  webmaster     delorie software   privacy  
  Copyright 2019   by DJ Delorie     Updated Jul 2019