From:	noer AT cygnus DOT com (Geoffrey Noer)
Subject:	Mark ~fhandler_base virtual?
24 Mar 1998 21:06:40 -0800 :
Message-ID:	<199803250239.SAA01986.cygnus.cygwin32.developers@skaro.cygnus.com>
To:	cygwin32-developers AT cygnus DOT com
Cc:	noer AT cygnus DOT com (Geoffrey Noer)

I've been cleaning up warnings generated by compiling cygwin32 with
-Wall.  One of them is that fhandler.h declares virtual functions but
has a non-virtual destructor.

Should I make ~fhandler_base virtual?  I *think* it's not necessary
but wouldn't hurt either.  The function set_name (which is the only
thing that calls new and thus needs the destructor) is only called by
fhandler_base functions.

-- 
Geoffrey Noer
noer AT cygnus DOT com

- Raw text -