Mailing-List:	contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT cygwin DOT com>
List-Help:	<mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-developers-owner AT cygwin DOT com
Delivered-To:	mailing list cygwin-developers AT cygwin DOT com
Message-ID:	<3E6CBB60.FAC2C62D@ieee.org>
Date:	Mon, 10 Mar 2003 11:20:48 -0500
From:	"Pierre A. Humblet" <Pierre DOT Humblet AT ieee DOT org>
X-Accept-Language:	en,pdf
MIME-Version:	1.0
To:	cygwin-developers AT cygwin DOT com
Subject:	Re: unlink
References:	<3E6CB0FA DOT 2312CCD0 AT ieee DOT org> <20030310155855 DOT GB1193 AT cygbert DOT vinschen DOT de>

Corinna Vinschen wrote:
> 
> On Mon, Mar 10, 2003 at 10:36:26AM -0500, Pierre A. Humblet wrote:
> > So I would propose to remove the DELETE code from alloc_sd and sec_acl
> > and to leave unlink as it is, in that respect.
> 
> Like this?

Wow. Yes.

> > 2) Why is wincap.has_delete_on_close needed?
> 
> Hmm, I can't answer this one.  Historical reasons?  Bad experience?
> 
> > 3) I don't understand why there are so many SetFileAttributes after CreateFile
> >    succeeds. If the file will be deleted, its attributes are don't care. If it won't,
> >    then we undo twice what we just did before the CreateFile.
> >    Also it's an easy test to decide if the SetFileAttribute before CreateFile is needed.
> 
> Chris and I are through this attribute hell this weekend.  To make it
> short:  If the file is hardlinked more than once, the other links would
> miss an attribute after removing this one link.

I think I see. When a file is hard linked, SetFileAttributes affects *all* links.
Correct? 
Still, it's easy to decide if the calls are needed.

Pierre

- Raw text -