Mailing-List:	contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT cygwin DOT com>
List-Help:	<mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-developers-owner AT cygwin DOT com
Delivered-To:	mailing list cygwin-developers AT cygwin DOT com
Date:	Thu, 18 Jul 2002 10:56:32 +0200
From:	Corinna Vinschen <vinschen AT redhat DOT com>
To:	cygdev <cygwin-developers AT cygwin DOT com>
Subject:	Re: Corinna or Pierre please comment? [jason AT tishler DOT net: Re: setuid() problem when disconnected from PDC under 1.3.12-2]
Message-ID:	<20020718105632.R6932@cygbert.vinschen.de>
Reply-To:	cygwin-developers AT cygwin DOT com
Mail-Followup-To:	cygdev <cygwin-developers AT cygwin DOT com>
References:	<20020715155951 DOT GG2372 AT tishler DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20020715162535 DOT 0080c900 AT mail DOT attbi DOT com> <20020716191735 DOT GB1692 AT tishler DOT net> <20020717121704 DOT GA1260 AT tishler DOT net> <20020717142259 DOT E6932 AT cygbert DOT vinschen DOT de> <20020717123351 DOT GB1260 AT tishler DOT net> <20020717145642 DOT G6932 AT cygbert DOT vinschen DOT de> <3D358707 DOT 509E8CD3 AT ieee DOT org> <20020717163922 DOT GD1260 AT tishler DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20020717222627 DOT 007fd3e0 AT mail DOT attbi DOT com>
Mime-Version:	1.0
In-Reply-To:	<3.0.5.32.20020717222627.007fd3e0@mail.attbi.com>
User-Agent:	Mutt/1.3.22.1i

On Wed, Jul 17, 2002 at 10:26:27PM -0400, Pierre A. Humblet wrote:
> Corinna, what do you think?
> [...]

Everything's fine with your patch, IMHO.

> - Should we add an informational system_printf() if the DC can't be 
> looked up? 

What do you mean?  A debug output when NetGetDCName() fails is already
in the code and when get_user_groups() fails, too.  What does an extra
system_printf help?

Could you just hand in the ChangeLog?  I will apply the patch ASAP then.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.

- Raw text -