Mailing-List:	contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT cygwin DOT com>
List-Help:	<mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-developers-owner AT cygwin DOT com
Delivered-To:	mailing list cygwin-developers AT cygwin DOT com
Date:	Mon, 1 Jul 2002 09:44:12 +0200
From:	Corinna Vinschen <vinschen AT redhat DOT com>
To:	cygwin-developers AT cygwin DOT com
Subject:	Re: Slowdown
Message-ID:	<20020701094412.A17641@cygbert.vinschen.de>
Reply-To:	cygwin-developers AT cygwin DOT com
Mail-Followup-To:	cygwin-developers AT cygwin DOT com
References:	<20020629031639 DOT GA14536 AT redhat DOT com> <3D1B4043 DOT EF2CA37A AT ieee DOT org> <3D1B4043 DOT EF2CA37A AT ieee DOT org> <3 DOT 0 DOT 5 DOT 32 DOT 20020627224059 DOT 0080d5b0 AT mail DOT attbi DOT com> <20020629031639 DOT GA14536 AT redhat DOT com> <3 DOT 0 DOT 5 DOT 32 DOT 20020629183141 DOT 007fa560 AT mail DOT attbi DOT com> <20020630115640 DOT A12869 AT cygbert DOT vinschen DOT de> <20020701035732 DOT GA6234 AT redhat DOT com>
Mime-Version:	1.0
In-Reply-To:	<20020701035732.GA6234@redhat.com>
User-Agent:	Mutt/1.3.22.1i

On Sun, Jun 30, 2002 at 11:57:32PM -0400, Chris Faylor wrote:
> On Sun, Jun 30, 2002 at 11:56:40AM +0200, Corinna Vinschen wrote:
> >- If in evironment, done.
> >- Else ask /etc/passwd
> >- Else use environemt vars HOMEDRIVE/HOMEPATH.
> >
> >The server is only asked for getting HOMEDRIVE/HOMEPATH and
> >the values are never used to set the environment or to
> >evaluate HOME.  So if HOMEDRIVE/HOMEPATH are missing in the
> >environment, getting the values from the server doesn't help
> >for setting HOME.  Or do I miss something?
> 
> Nope, you aren't missing anything.  When I reworked that logic, I
> thought about using the derived values of HOMEPATH/HOMEDRIVE but that
> would mean a potentially expensive operation, right?  Maybe it doesn't

> So, I just added the potential capability to set HOME from
> HOMEPATH/HOMEDRIVE.  It isn't on yet, though.

Hmm.

> Boy, I think I hate these environment variables almost as much as I hate
> Windows 95.  Have I mentioned that lately?

Not this month...

> Oh, and currently I made HOME default to / if it can't figure out
> anything else.  Does that make sense?

That's ok but I'm still sure it makes sense to use HOMEDRIVE/HOMEPATH
first.  Setting to "/" should be just the last fallback.  

What's the problem in trusting these environment variables?  The user
could change them, yes, but the user can change a lot of stuff.  The user
could also change $HOME to some bogus value and in case of $HOME it's
suddenly no problem to trust the environment but for HOMEDRIVE/HOMEPATH
it is?  Sounds not logical to me.

In contrast to your solution I'd add another getenv("HOMEDRIVE")/
getenv("HOMEPATH") to evaluate homedrive/homepath.  This would very
likely eliminate another potential server call.  Currently it's

- Get from /etc/passwd
- Else get from server

What I think is better is

- Get from /etc/passwd
- Else use environemt vars HOMEDRIVE/HOMEPATH (as for HOME)
- Else get from server

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.

- Raw text -