Mailing-List:	contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT cygwin DOT com>
List-Help:	<mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-developers-owner AT cygwin DOT com
Delivered-To:	mailing list cygwin-developers AT cygwin DOT com
X-WM-Posted-At:	avacado.atomice.net; Sun, 30 Jun 02 14:00:26 +0100
Message-ID:	<00a801c22036$1a7456b0$0100a8c0@advent02>
From:	"Chris January" <chris AT atomice DOT net>
To:	<cygwin-developers AT cygwin DOT com>
Subject:	changes to fhandler_process.cc from 02/06/2002 should be reverted
Date:	Sun, 30 Jun 2002 14:00:26 +0100
MIME-Version:	1.0
X-Priority:	3
X-MSMail-Priority:	Normal
X-MimeOLE:	Produced By Microsoft MimeOLE V6.00.2600.0000

I've just seen this ChangeLog entry, Chris:

2002-06-02  Christopher Faylor  <cgf AT redhat DOT com>

 Remove unneeded sigproc.h includes throughout.
 * fhandler.h (fhandler_proc::fill_filebuf): Take a pinfo argument.
 * fhandler_proc.cc (fhandler_proc::get_proc_fhandler): Simplify search
 for given pid.
 (fhandler_proc::readdir): Assume that pid exists if it shows up in the
 winpid list.
 * fhandler_process.cc (fhandler_process::open): Simplify search for
 given pid.  Call fill_filebuf with pinfo argument.
 (fhandler_process::fill_filebuf): Pass pinfo here and assume that it
 exists.
 * pinfo.h (pinfo::remember): Define differently if sigproc.h is not
 included.

IMHO, these changes need to be reverted. fhandler_base::fill_filebuf is
virtual. If you add the pinfo parameter to fhandler_process::fill_filebuf,
then you are defining a new function, not overriding the one in
fhandler_base. Hence, /proc semantics whereby the file contents are
refreshed on an lseek are broken.

Regards
Chris

- Raw text -