Mailing-List:	contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT cygwin DOT com>
List-Help:	<mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-developers-owner AT cygwin DOT com
Delivered-To:	mailing list cygwin-developers AT cygwin DOT com
Date:	Mon, 28 Jan 2002 16:27:09 +0300
From:	egor duda <deo AT logos-m DOT ru>
X-Mailer:	The Bat! (v1.53 RC/4)
Reply-To:	egor duda <cygwin-developers AT cygwin DOT com>
Organization:	deo
X-Priority:	3 (Normal)
Message-ID:	<174527779136.20020128162709@logos-m.ru>
To:	"Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
CC:	cygwin-developers AT cygwin DOT com
Subject:	Re: Daemon reviewer
In-Reply-To:	<01cd01c1a6dd$4619e550$0200a8c0@lifelesswks>
References:	<01cd01c1a6dd$4619e550$0200a8c0 AT lifelesswks>
MIME-Version:	1.0

Hi!

Sunday, 27 January, 2002 Robert Collins robert DOT collins AT itdomain DOT com DOT au wrote:

RC> Gary, will you have to time make some sort of comment on the code/design
RC> quality in the next (say) fortnight?

i'm in process of looking into it. the first thing i've stumbled
over is that cygserver.exe depends on cygwin1.dll. I believe it's
just wrong and may be a source of difficult to find errors. Is there
any particular reason for linking daemon with cygwin1.dll? original
named-pipes-as-transport thingie was made with self-sufficiency
requirement.

second, you wrote that it's mulithreaded, but it's not very clear what
does that mean. Do i understand right that every client connection
creates a separate thread to handle requests from that client? If it's
so, i'm afraid i don't understand what all those Interlocked* calls
and synchronization-related FIXME:'s are for. For instance, in
cygserver_transport_pipes.cc (transport_layer_pipes::init_security)
there's a FIXME: comment about the need of something like
pthread_once. i don't see why it's needed. Standard security
descriptors should be initialized once at the program startup, before
any new threads are being spawned.

or i just totally misunderstand your design.

Egor.            mailto:deo AT logos-m DOT ru ICQ 5165414 FidoNet 2:5020/496.19

- Raw text -