Mailing-List:	contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin-developers AT sources DOT redhat DOT com
Date:	Mon, 12 Nov 2001 11:24:29 -0500
From:	Christopher Faylor <cgf AT redhat DOT com>
To:	cygwin-developers AT cygwin DOT com
Subject:	Re: change to fhandler_console.cc from 2001-10-23 breaks ttyfier
Message-ID:	<20011112162429.GA23200@redhat.com>
Reply-To:	cygwin-developers AT cygwin DOT com
Mail-Followup-To:	cygwin-developers AT cygwin DOT com
References:	<3583457104 DOT 20011112171154 AT logos-m DOT ru>
Mime-Version:	1.0
In-Reply-To:	<3583457104.20011112171154@logos-m.ru>
User-Agent:	Mutt/1.3.23.1i

On Mon, Nov 12, 2001 at 05:11:54PM +0300, egor duda wrote:
>Hi!
>
>2001-10-23  Christopher Faylor  <cgf AT redhat DOT com>
>
>        * fhandler_console.cc (fhandler_console::read): Remove unneeded test.
>        Only honor "key down" events.
>
>this change breaks ttyfier. unfortunately some programs (notably
>ntvdm) want to see key-up events. without them they think that ctrl
>key is stuck.
>
>key-up events should work only in raw mode -- there's a check for
>key-down flag in fhandler_console.cc:291
>
>what was the reason of this change?

I saw a similar change in Ian Ray's Win95 CAPS-lock fix and wondered if it
would solve any problems on w95.  It doesn't.

I'll revert the change.

cgf

- Raw text -