Mailing-List:	contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT sourceware DOT cygnus DOT com>
List-Archive:	<http://sourceware.cygnus.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT sourceware DOT cygnus DOT com>
List-Help:	<mailto:cygwin-developers-help AT sourceware DOT cygnus DOT com>, <http://sourceware.cygnus.com/ml/#faqs>
Sender:	cygwin-developers-owner AT sourceware DOT cygnus DOT com
Delivered-To:	mailing list cygwin-developers AT sourceware DOT cygnus DOT com
From:	Chris Faylor <cgf AT cygnus DOT com>
Date:	Mon, 14 Feb 2000 16:53:03 -0500
To:	Reinhard Nissl <rnissl AT gmx DOT de>
Cc:	cygwin-developers AT sourceware DOT cygnus DOT com
Subject:	Re: cygwin-src-20000125: patch to not convert cmdline to OEM
Message-ID:	<20000214165303.A18925@cygnus.com>
Reply-To:	cygwin-developers AT sourceware DOT cygnus DOT com
References:	<38A6E0D9 DOT 442DD5E9 AT gmx DOT de>
Mime-Version:	1.0
User-Agent:	Mutt/1.1.3i
In-Reply-To:	<38A6E0D9.442DD5E9@gmx.de>; from rnissl@gmx.de on Sun, Feb 13, 2000 at 05:50:33PM +0100

On Sun, Feb 13, 2000 at 05:50:33PM +0100, Reinhard Nissl wrote:
>the attached patch makes cygwin1.dll only convert the cmdline to OEM when the
>environment variable CYGWIN_CMD_LINE_MODE is not set to ANSI. If the variable
>doesn't exist or is set to anything else then ANSI, the library behaves as it
>did before applying the patch.
>
>In the case ANSI is set, any conversions from char to OEM or reverse are
>skipped or replaced by a neutral function. A call to SetFileApisToANSI() is
>done to handle the ANSI filenames correctly.
>
>I developed this patch while porting sms_client to the CYGWIN environment to
>be able to send SMS messages that contain "Umlauts", as the programme expects
>them to be coded according to the ANSI code page. 

I have a few problems with this patch.

1) It's using a non-standard environment variable to control this behavior.

2) It doesn't contain a ChangeLog.

3) It doesn't adhere to the coding style of the surrounding code.

4) I am wondering if the conditional behavior of this code should actually be
   the default behavior, i.e., should we always be using SetFileApisToANSI and
   MultiByteToWideChar.

1 - 3 are obviously easy to fix but I'd like to get a better feel for 3.
Can some other non-US people comment on this patch?

cgf

- Raw text -