Mail Archives: cygwin-developers/1999/12/10/22:43:05
Sorry that I didn't have time to give this my full attention earlier.
This looks basically ok, but I think you left in a section of code that
shouldn't be there. It seems to run a while loop twice looking for a
'\\'. That can't be right. Is this just something wrong with the
patch?
Also, I'm not sure what this is going to do to those mount tables which
have just a "c:" in them. I think they should work ok but somehow I
have a nagging feeling that there might be a problem there somewhere.
cgf
On Fri, Dec 10, 1999 at 08:39:08PM +0100, Corinna Vinschen wrote:
>ChangeLog:
>==========
>
>Dec 10 20:34:00 1999 Corinna Vinschen <corinna AT vinschen DOT de>
>
> * path.cc (path_conv::path_conv): If path is converted to
> only "X:\", don't eliminate trailing backslash. If path is
> converted to only "X:", add trailing backslash.
>
>
>Index: path.cc
>===================================================================
>RCS file: /src/cvsroot/winsup-991207/path.cc,v
>retrieving revision 1.1.1.1
>diff -u -p -r1.1.1.1 path.cc
>--- path.cc 1999/12/08 22:51:38 1.1.1.1
>+++ path.cc 1999/12/10 19:18:12
>@@ -221,6 +221,15 @@ path_conv::path_conv (const char *src, s
>
> /* Eat trailing slashes */
> char *tail = strchr (full_path, '\0');
>+ /* If path is only a drivename, Windows interprets it as
>+ the current working directory on this drive instead of
>+ the root dir which is what we want. So we need
>+ the trailing backslash in this case. */
>+ while (tail > full_path + 3 && (*--tail == '\\'))
>+ *tail = '\0';
>+ if (full_path[0] && full_path[1] == ':' && full_path[2] == '\0')
>+ strcat (full_path, "\\");
>+
> while (tail > full_path && (*--tail == '\\'))
> *tail = '\0';
--
cgf AT cygnus DOT com
http://www.cygnus.com/
- Raw text -