delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin-developers/1998/04/08/06:39:02

From: cgf AT cygnus DOT com
Subject: (none)
8 Apr 1998 06:39:02 -0700 :
Message-ID: <199804081306.JAA24423.cygnus.cygwin32.developers@tweedledumb.cygnus.com>
To: cygwin32-developers AT cygnus DOT com

>From: sos AT prospect DOT com DOT ru (Sergey Okhapkin)
>Date: 8 Apr 1998 05:29:30 -0700
>
>Geoffrey Noer wrote:
>> 2) In tty.cc, gcc claims that class tty * ttyp is an unused
>> variable in fhandler_tty_slave::close().  What needs to change here,
>> if anything?
>
>Looks like the variable is unused now and the declaration should be removed.
>
>> 
>> 3) In exceptions.cc,
>> 
>> 	/home/noer/src/devo/comp-tools/devo/winsup/exceptions.cc: At top
>> 	level:
>> 	/home/noer/src/devo/comp-tools/devo/winsup/exceptions.cc:370: warning:
>> 	`unsigned int rethere' defined but not used
>> 
>> Is this really the case?  Or is _rethere that's mentioned in the asm
>> section refering to the global rethere?
>> 
>
>Yes it is. Try to remove it and change the asseble code
>
>      "popl	_rethere\n"
>      "popl	_rethere\n"
>      "popl	_rethere\n"
>      "ret");
>to
>	"add $12,sp\n"
>	"ret");

Please don't do this.  It might appear to work but you can't use an add
here because it will change the flags register.  If the signal interrupted
something which relies on it, it will not have the correct state when it
returns.

cgf

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019