Mailing-List:	contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT cygwin DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT cygwin DOT com>
List-Help:	<mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To:	cygwin-apps AT cygwin DOT com
Delivered-To:	mailing list cygwin-apps AT cygwin DOT com
Date:	Mon, 10 Jun 2002 10:17:50 +0200
From:	Corinna Vinschen <cygwin-apps AT cygwin DOT com>
To:	cygwin-apps AT cygwin DOT com
Subject:	Re: package offering: gnupg
Message-ID:	<20020610101750.Q30892@cygbert.vinschen.de>
Mail-Followup-To:	cygwin-apps AT cygwin DOT com
References:	<3D01D259 DOT 9080508 AT scytek DOT de> <3D041CA7 DOT 4070708 AT ece DOT gatech DOT edu>
Mime-Version:	1.0
In-Reply-To:	<3D041CA7.4070708@ece.gatech.edu>
User-Agent:	Mutt/1.3.22.1i

On Sun, Jun 09, 2002 at 11:27:35PM -0400, Charles Wilson wrote:
> You probably should add a postinstall script to install-info the .info 
> files -- oh wait -- you could just rely on cgf's _install_info virtual 
> package to handle that...
> 
> Other than that, it looks good (although I'm a gpg newbie, so I haven't 
> actually tested *operation*...)
> 
> In the build script, don't just comment out the check() function -- you 
> also need to comment out check) from the switch statement.  Better, just 
> replace the guts of the check() function with "echo Check not implemented."
> 
> You should probably patch 'autogen' to call gettextize with the -c 
> option.  Ditto autoconf and automake (and libtool, if that applies).
> 
> Other than those tiny things, it looks great.

Charles, when you say "tiny things", I assume you don't
mean "showstopper".

Volker, do you want to rearrange your package to follow
Charles' suggestions or should I upload the package as is?

Corinna

- Raw text -