Mailing-List:	contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT cygwin DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT cygwin DOT com>
List-Help:	<mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To:	cygwin-apps AT cygwin DOT com
Delivered-To:	mailing list cygwin-apps AT cygwin DOT com
Date:	Fri, 10 May 2002 17:38:55 -0400
From:	Christopher Faylor <cgf AT redhat DOT com>
To:	cygwin-apps AT cygwin DOT com
Subject:	setup's version checking
Message-ID:	<20020510213855.GA31055@redhat.com>
Reply-To:	cygwin-apps AT cygwin DOT com
Mail-Followup-To:	cygwin-apps AT cygwin DOT com
Mime-Version:	1.0
User-Agent:	Mutt/1.3.23.1i

I don't know if anyone has noticed but, from the bug reports in the
cygwin mailing list, it seems pretty obvious that setup isn't properly
handling the version number field in setup.ini.

What should be happening is that the version field should be parsed
first, and then, if the setup.ini version is newer than setup.exe, a
warning is raised asking the user if they want to continue.  This
should happen before any further proessing of setup.ini happens.

What is happening instead is that the whole file is parsed (causing all
sorts of errors thanks to the md5 addition) and then, if setup makes
it that far, the user is asked if they're sure.  Unfortunately, setup
doesn't make it far enough to notify the user about the problems and
so, hilarity ensues.

cgf

- Raw text -