Mailing-List:	contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT cygwin DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT cygwin DOT com>
List-Help:	<mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To:	cygwin-apps AT cygwin DOT com
Delivered-To:	mailing list cygwin-apps AT cygwin DOT com
From:	"Gary R Van Sickle" <tiberius AT braemarinc DOT com>
To:	<cygwin-apps AT cygwin DOT com>
Subject:	RE: Patch for Setup.exe problem and for mklink2.cc
Date:	Wed, 27 Mar 2002 11:48:19 -0600
Message-ID:	<000e01c1d5b7$956b6760$2101a8c0@BRAEMARINC.COM>
MIME-Version:	1.0
X-Priority:	3 (Normal)
X-MSMail-Priority:	Normal
In-reply-to:	<FC169E059D1A0442A04C40F86D9BA76008ABCB@itdomain003.itdomain.net.au>
X-MimeOLE:	Produced By Microsoft MimeOLE V6.00.2600.0000
X-MS-TNEF-Correlator:	00000000B03CC41A0A406141B2DADC7F0FA7B35A24E9CB00
Importance:	Normal

This is a multi-part message in MIME format.

------=_NextPart_000_000F_01C1D585.4AD27E00
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit

[snip]
 
> > Found the problem causing the segment violation and probably 
> > causing Jonas Eriksson's problem. It is a typical case of 
> > 'off by 1'. In PickView::set_headers the loop filling the 
> > window header does one iteration too much, resulting in a 
> > call to DoInsertItem with a NULL string pointer and hence a 
> > crash following. While debugging this I could not compile the 
> > new mklink2.cc ( the
> > c++ version of the original mklink2.c). It seems three & 
> (address of 
> > c++ operator)
> > have disappeared in the transition. Putting them back made 
> > the compiler happy. Is this OK Robert ?
> 
> I'll check the off-by-one fix in tomorrow, as I'm off to bed now. 
> 

[snip]

There have been a few of these off-by-ones in Setup.  Is it possible your
habit of using 1-based arrays is a contributing factor Rob?  This isn't a
convention I see much (modulo "Numerical Recipies"); is there a reason you
use this convention?

-- 
Gary R. Van Sickle
Braemar Inc.
11481 Rupp Dr.
Burnsville, MN 55337


------=_NextPart_000_000F_01C1D585.4AD27E00
Content-Type: application/ms-tnef;
	name="winmail.dat"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
	filename="winmail.dat"

eJ8+IhQRAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEIgAcAGAAAAElQTS5NaWNy
b3NvZnQgTWFpbC5Ob3RlADEIAQ2ABAACAAAAAgACAAEGgAMADgAAANIHAwAbAAsAMAAAAAMANQEB
A5AGACgIAAAlAAAACwACAAEAAAALACMAAAAAAAMAJgAAAAAACwApAAAAAAADAC4AAAAAAAMANgAA
AAAAHgBwAAEAAAAvAAAAUGF0Y2ggZm9yIFNldHVwLmV4ZSBwcm9ibGVtIGFuZCBmb3IgbWtsaW5r
Mi5jYwAAAgFxAAEAAAAWAAAAAcHVt5Shkn/hNV1mRbaAT4WkS4dFCAAAAgEdDAEAAAAdAAAAU01U
UDpUSUJFUklVU0BCUkFFTUFSSU5DLkNPTQAAAAALAAEOAAAAAEAABg4ASCmJt9XBAQIBCg4BAAAA
GAAAAAAAAACwPMQaCkBhQbLa3H8Pp7NawoAAAAMAFA4BAAAACwAfDgEAAAACAQkQAQAAAMcDAADD
AwAAjwUAAExaRnUmfNuYAwAKAHJjcGcxMjXiMgNDdGV4BUEBAwH3/wqAAqQD5AcTAoAP8wBQBFY/
CFUHshElDlEDAQIAY2jhCsBzZXQyBgAGwxEl9jMERhO3MBIsETMI7wn3tjsYHw4wNREiDGBjAFAz
CwkBZDM2FlALpiBb8nMDAHBdCqIKgArjCoAUPiAeIEYIYG5kIGB0aGUgcANgAmBlIG0gY2F1AJBu
ZxsesxQQZweAAjAgdmn5BvBhdCDQA6AAcB6gHwJZAaBseR25H4ZKAiBhtQQgRQUQawQQAiAnBCDx
HwUuIEkFQAQAIVAesDx5cA3gB0AfcRQQIG9aZh25JyZAJlBiIhAxlick0QOgUA3ga1YIkKh3OjoU
EV8e0GEEgYcEIB7CF7BvcCBmAxDebB/GHcgD8B6QbwfgKOReICuAB5ECIB7gaQ6wciUhBHQpsCBt
GtBoLOIgGCBzdWwhEB/RC4CPJUEiOioQLVEgRG8n0H8UEAAgJPAfUQPwHsAlQU5oVUxMIDB0BRAf
0XCebwuALNEhUx7QbmMe4Psu2yzwczEQAhAqECuQH8E5JNBXaAMQHuABAGJ1bGdnH8QlIUkfcAhg
bNkeoG5vBUAFoG0lkDUxJyp8LJAH4G1rKiFrMmAuY2MgKB6yIjkrfisgsCkhISImQR7CBbBp9zWx
JcE4tykk0xQQH1ApQqkJ0SAmHbcoKQBkLgG/LGEmWjpSKcAs4gWwKR3IzxPgOpAsIAQAYXBAEArA
fwmALpIewjGwAHIhEiTQUP51AkAfxR9gIdAoIC2QKQG/HbkewjcVBcAT4EHAeSTRUylCJSFPSwfx
YjBhIOY/HcYdxkknL7ET0AWQ10RwO0MBIC0nYC0sginw3nhCMwNwBbADYHct4COBv0jwH2AnIi/h
R5A2snck0O9H/B1UHPodVFQe0BggQST3R5AJ8CVBZgfROxQmE0oGxwQgLqEGYHR1cCTQRrKXLMAy
AQQQaR8xIHkIYd1BIWJTASZBH6QxShAmAfceoArALPB5UgElMgWgAjB3BRA1gC5TZgDQQFFHYj//
UrBPcCUhBAAkIAVAViM6kP8CMCEiNlA9AS2TOVAEYS4wcS2AIk51B4AFECWyUocFkAUgCJBzIik7
JRL/HsFPoSVQGCAjgCExU8FUkZ83ciUhWLhH5R1ULS0dtVZHCsAiEFIk0FYDkVP3KBEfQB1UQizw
H1AKwSfQBGMuHVQxMTQ4MacH8FKAKdBEcmIlQghwFwCAIMAqEGUt4E1OIFEaYDMzN02afWXgAB4A
QhABAAAARQAAADxGQzE2OUUwNTlEMUEwNDQyQTA0QzQwRjg2RDlCQTc2MDA4QUJDQkBpdGRvbWFp
bjAwMy5pdGRvbWFpbi5uZXQuYXU+AAAAAAMACVkBAAAACwAAgAggBgAAAAAAwAAAAAAAAEYAAAAA
A4UAAAAAAAADAAKACCAGAAAAAADAAAAAAAAARgAAAAAQhQAAAAAAAAMAB4AIIAYAAAAAAMAAAAAA
AABGAAAAAFKFAAC2dAEAHgAJgAggBgAAAAAAwAAAAAAAAEYAAAAAVIUAAAEAAAAEAAAAOS4wAAsA
EYAIIAYAAAAAAMAAAAAAAABGAAAAAAaFAAAAAAAAAwASgAggBgAAAAAAwAAAAAAAAEYAAAAAAYUA
AAAAAAALABuACCAGAAAAAADAAAAAAAAARgAAAAAOhQAAAAAAAAMAHIAIIAYAAAAAAMAAAAAAAABG
AAAAABGFAAAAAAAAAwAegAggBgAAAAAAwAAAAAAAAEYAAAAAGIUAAAAAAAACAfgPAQAAABAAAACw
PMQaCkBhQbLa3H8Pp7NaAgH6DwEAAAAQAAAAsDzEGgpAYUGy2tx/D6ezWgIB+w8BAAAAoAAAAAAA
AAA4obsQBeUQGqG7CAArKlbCAABtc3BzdC5kbGwAAAAAAE5JVEH5v7gBAKoAN9luAAAAQzpcRG9j
dW1lbnRzIGFuZCBTZXR0aW5nc1xnYXJ5X3ZzLkJSQUVNQVJJTkNcTG9jYWwgU2V0dGluZ3NcQXBw
bGljYXRpb24gRGF0YVxNaWNyb3NvZnRcT3V0bG9va1xtYWlsYm94LnBzdAADAP4PBQAAAAMADTT9
NwAAAgF/AAEAAAAxAAAAMDAwMDAwMDBCMDNDQzQxQTBBNDA2MTQxQjJEQURDN0YwRkE3QjM1QTI0
RTlDQjAwAAAAAAMABhDRwI0JAwAHEP0CAAADABAQAQAAAAMAERAAAAAAHgAIEAEAAABlAAAAU05J
UEZPVU5EVEhFUFJPQkxFTUNBVVNJTkdUSEVTRUdNRU5UVklPTEFUSU9OQU5EUFJPQkFCTFlDQVVT
SU5HSk9OQVNFUklLU1NPTlNQUk9CTEVNSVRJU0FUWVBJQ0FMQ0FTRQAAAADXCA==

------=_NextPart_000_000F_01C1D585.4AD27E00--

- Raw text -