Mailing-List:	contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To:	mailing list cygwin-apps AT sources DOT redhat DOT com
Date:	Sun, 11 Nov 2001 18:30:34 -0500
From:	Christopher Faylor <cgf AT redhat DOT com>
To:	cygwin-patches AT cygwin DOT com, cygwin-apps AT cygwin DOT com
Subject:	Re: setup streams work..
Message-ID:	<20011111233034.GA24210@redhat.com>
Reply-To:	cygwin-patches AT cygwin DOT com
Mail-Followup-To:	cygwin-patches AT cygwin DOT com, cygwin-apps AT cygwin DOT com
References:	<019d01c16a7f$ab3ee060$0200a8c0 AT lifelesswks>
Mime-Version:	1.0
In-Reply-To:	<019d01c16a7f$ab3ee060$0200a8c0@lifelesswks>
User-Agent:	Mutt/1.3.23.1i

On Sun, Nov 11, 2001 at 06:08:29PM +1100, Robert Collins wrote:
>So given that the class layout works, and somethings are already
>becoming easier to do, I plan to commit this to HEAD.
>
>Any objections?

It looks fine to me.

It was a little hard to tell what was changing given that you seem
to have run the sources through indent and there was some whitespace
changes.

I actually think that indent is doing the wrong thing for c++ in some
cases.

I like the idea of the io_stream a lot.  I also like the "cygfile:"
"URL".

I say go for it.

cgf

- Raw text -