delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin-apps/2001/11/05/20:14:20

Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Date: Mon, 5 Nov 2001 20:14:32 -0500
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin-apps AT cygwin DOT com
Subject: Re: Setup.exe - snapshot runs but compiled from cvs get application error.
Message-ID: <20011105201432.A1047@redhat.com>
Reply-To: cygwin-apps AT cygwin DOT com
Mail-Followup-To: cygwin-apps AT cygwin DOT com
References: <EA18B9FA0FE4194AA2B4CDB91F73C0EF08F26F AT itdomain002 DOT itdomain DOT net DOT au>
Mime-Version: 1.0
In-Reply-To: <EA18B9FA0FE4194AA2B4CDB91F73C0EF08F26F@itdomain002.itdomain.net.au>
User-Agent: Mutt/1.3.21i

On Tue, Nov 06, 2001 at 12:15:50PM +1100, Robert Collins wrote:
>> -----Original Message-----
>> FWIW, this *is* the problem that was fixed by my patch.
>
>Thanks.

And, here it is for public consumption.

I didn't apply it because I didn't think that it was exactly the right solution.
I thought that maybe cygpath should have a "get_root_dir_now" call in it to
ensure that it would never try to access setup.exe's mount table before it
was initialized.

cgf

2001-11-02  Christopher Faylor  <cgf AT redhat DOT com>

	* localdir.cc (do_local_dir): Ensure that mount table is initialized prior
	to cygpath call.

Index: localdir.cc
===================================================================
RCS file: /cvs/uberbaum/winsup/cinstall/localdir.cc,v
retrieving revision 2.2
diff -u -p -r2.2 localdir.cc
--- localdir.cc	2001/11/01 13:22:46	2.2
+++ localdir.cc	2001/11/03 02:31:39
@@ -202,6 +202,7 @@ do_local_dir (HINSTANCE h)
   static int inited = 0;
   if (!inited)
     {
+      get_root_dir_now ();
       FILE *f = fopen (cygpath ("/etc/setup/last-cache", 0), "rt");
       if (f)
 	{

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019