Mailing-List:	contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To:	mailing list cygwin-apps AT sources DOT redhat DOT com
Message-ID:	<014301c0af4f$ec386550$0200a8c0@lifelesswks>
From:	"Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To:	"Trevor Forbes" <trevorforbes AT ozemail DOT com DOT au>, <cygwin-apps AT cygwin DOT com>
References:	<20010317172830 DOT A24346 AT redhat DOT com> <011b01c0af4b$62f44ec0$0200a8c0 AT voyager>
Subject:	Re: gcc 2.95.3-1 and -mwin32
Date:	Sun, 18 Mar 2001 13:05:34 +1100
MIME-Version:	1.0
X-Priority:	3
X-MSMail-Priority:	Normal
X-Mailer:	Microsoft Outlook Express 5.50.4133.2400
X-MimeOLE:	Produced By Microsoft MimeOLE V5.50.4133.2400
X-OriginalArrivalTime:	18 Mar 2001 01:59:51.0344 (UTC) FILETIME=[1E62C300:01C0AF4F]

----- Original Message -----
From: "Trevor Forbes" <trevorforbes AT ozemail DOT com DOT au>


>
> ----- Original Message -----
> From: "Christopher Faylor" <cgf AT redhat DOT com>
>
< snip> gcc pre release announcement
>
> I also agree with /usr/include/w32api inclusion therefore I am more
than
> happy with this change.
>
> However, I think w32api should be neutral with regards to WIN32
defines.
>
> For example, I think the following should be "removed" and allow WIN32
to be
> defined/not defined in gcc or (my preference) defined in the software
being
> ported:
>
> w32api/windef.h
>
> #ifndef WIN32
> #define WIN32
> #endif
> #ifndef _WIN32
> #define _WIN32
> #endif
>
> Comments?

I don't think the software being ported should ever define WIN32 itself.
It'd be like defining glibc_version (or whatever that value is called)
yourself.

Setting it for gcc is one thing, and quite appropriate. As far as w32api
goes, I haven't investigated and thus won't comment..

Rob

- Raw text -