Mailing-List:	contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To:	mailing list cygwin-apps AT sources DOT redhat DOT com
Date:	Wed, 22 Nov 2000 16:32:25 -0500
From:	Christopher Faylor <cgf AT redhat DOT com>
To:	cygwin-apps AT cygwin DOT com
Subject:	Re: Texinfo-4.0
Message-ID:	<20001122163225.B11387@redhat.com>
Reply-To:	cygwin-apps AT cygwin DOT com
Mail-Followup-To:	cygwin-apps AT cygwin DOT com
References:	<Pine DOT LNX DOT 4 DOT 30 DOT 0011221237210 DOT 10055-100000 AT c445745-a DOT stcla1 DOT sfba DOT home DOT com> <3A1C3784 DOT 9DEF7B94 AT ece DOT gatech DOT edu>
Mime-Version:	1.0
User-Agent:	Mutt/1.3.11i
In-Reply-To:	<3A1C3784.9DEF7B94@ece.gatech.edu>; from cwilson@ece.gatech.edu on Wed, Nov 22, 2000 at 04:15:48PM -0500

On Wed, Nov 22, 2000 at 04:15:48PM -0500, Charles Wilson wrote:
>Carlos Puig wrote:
>> 
>> Note: One small patch is needed to make texinfo-4.0 under cygwin.  On line 106
>> of the generated makeinfo/Makefile, add -DWIN32 as follows:
>> 
>>     DEFS = -DHAVE_CONFIG_H -I. -I$(srcdir) -I..
>> 
>> to
>> 
>>     DEFS = -DWIN32 -DHAVE_CONFIG_H -I. -I$(srcdir) -I..
>
>AArrrrggghhh!!!  No.  Don't rely on -DWIN32 -- it often turns on too
>many windows specific hacks, and leads to huge troubles later on. 
>Cygwin is not windows.  What you should do, is inspect every .h and .c
>file, looking for '#ifdef WIN32'.  If the block of code 'turned on' by
>the WIN32 flag is truly necessary on cygwin, then change the '#ifdef
>WIN32' to 
>
>  #if defined(WIN32) || defined(__CYGWIN__)
>
>If the block of code 'turned on' by the WIN32 flag is NOT needed on
>cygwin, then change the '#ifdef WIN32'
> 
>  #if defined(WIN32) && !defined(__CYGWIN__)

Right.  I would welcome a texinfo update but, if anything it should use
-mno-win32 as an option to avoid Win32'isms.

Do we have a FAQ entry on what it takes to contribute a package?  It's
not that hard but this question keeps coming up.

cgf

- Raw text -