Mailing-List:	contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT cygwin DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT cygwin DOT com>
List-Help:	<mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To:	mailing list cygwin-apps AT cygwin DOT com
Message-ID:	<3C7933C9.3010708@ece.gatech.edu>
Date:	Sun, 24 Feb 2002 13:41:13 -0500
From:	Charles Wilson <cwilson AT ece DOT gatech DOT edu>
User-Agent:	Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.4) Gecko/20011019 Netscape6/6.2
X-Accept-Language:	en-us
MIME-Version:	1.0
To:	Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
CC:	Jason Tishler <jason AT tishler DOT net>,
	Cygwin-Apps <cygwin-apps AT sources DOT redhat DOT com>
Subject:	Re: setup.exe rebase patch
References:	<20020207134119 DOT GB1804 AT dothill DOT com> <027701c1bd28$c4666170$0200a8c0 AT lifelesswks>

Robert Collins wrote:


>>I also have a stand-alone rebase.exe that I would like to contribute
>>
> to
> 
>>Cygwin so that users can rebase without having to run setup.exe.
>>
> 
> Neato. This sounds like a cygutils thingo to me, or a new package.
> Chuck? Ohhhh Chuck?


Ummm...do we really want to fork the code into two separate locations? 
It seems to me that the best thing to do would be the following:

winsup/cinstall/Makefile.am:
bin_PROGRAMS: setup rebase
setup_SOURCES: ..... rebase.cc rebase.l rebase.y rebase.h .....
rebase_SOURCES: rebase.cc rebase.l rebase.y rebase.h
rebase_CFLAGS: -dREBASE_STANDALONE

in rebase.cc:

#if REBASE_STANDALONE
int main(int argc, char * argv[]) {
...
}
#endif

This way, the SAME code is used by both the standalone rebase.exe and 
setup.exe.  Otherwise, we'll continually have synchronization problems 
between the two (e.g. what if the format of /etc/rebase.conf changes?)


> One important thing is to have setup's rebasing and the rebase
> commandline tool *both* store their work in rebase.conf. That way they
> won't require full rebasing when someone fiddles with something.
> 

Yeah -- which is why they should both come from the same code.  In the 
same location.  I *strongly* advocate adding rebase.exe to the cinstall 
directory since it will be so tightly tied to setup.exe's behavior...

--Chuck

- Raw text -