delorie.com/archives/browse.cgi | search |
Mailing-List: | contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm |
Sender: | cygwin-apps-owner AT sourceware DOT cygnus DOT com |
List-Subscribe: | <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com> |
List-Archive: | <http://sources.redhat.com/ml/cygwin-apps/> |
List-Post: | <mailto:cygwin-apps AT sources DOT redhat DOT com> |
List-Help: | <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs> |
Delivered-To: | mailing list cygwin-apps AT sources DOT redhat DOT com |
Message-ID: | <033001c1699c$8bfa35d0$0200a8c0@lifelesswks> |
From: | "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au> |
To: | "Gareth Pearce" <tilps AT hotmail DOT com>, <cygwin-patches AT cygwin DOT com> |
Cc: | <cygwin-apps AT sources DOT redhat DOT com> |
References: | <F174dfEtGrpUN7cLjHZ00022a02 AT hotmail DOT com> |
Subject: | Re: [Patch] setup.exe - no skip/keep option buggyness |
Date: | Sat, 10 Nov 2001 15:02:41 +1100 |
MIME-Version: | 1.0 |
X-Priority: | 3 |
X-MSMail-Priority: | Normal |
X-Mailer: | Microsoft Outlook Express 6.00.2600.0000 |
X-MimeOLE: | Produced By Microsoft MimeOLE V6.00.2600.0000 |
X-OriginalArrivalTime: | 10 Nov 2001 04:08:48.0432 (UTC) FILETIME=[65F37300:01C1699D] |
cross-posted to cyg-apps. Please follow up on cyg-apps. ----- Original Message ----- From: "Gareth Pearce" <tilps AT hotmail DOT com> > > hmm I hope you tested my patch, because although I tested it with no I did. It seemed fine. > problems, if your original patch didnt work - I wouldnt be supprised that > mine fails for the same reasons... Yours works because the state _SKIP is already handled. There is no state for 'keep' - just states for PREV/CURR/TEST && a test for those being the current installed version. > this was what I meant about not knowing > why it worked... I also thought being set to unknown should break my code > ... but only realised that after having tested it and having had it work jut > fine... Have you done much work with FSM's? set_action() is a fairly typically FSM transition function. > if you want it to say keep instead of skip ... under the way my patch > works... ... Yes, for the UI that will work, but the internal logic still needs to be straightened out. Keeping the gui unfixed will act as a reminder :} . Thoughts anyone? For the post-category release I'm hoping to have had a chance to do something on this, so that the impact shouldn't be huge. ... > would submit a patch, but NTFS on win2k being read only mounted is stuffing > me arround... and I couldnt test it here in debian anyway... You might try plex86, I'm intending to use that for testing, if I can ever get it to work. > cyg-apps for setup/winsup directory stuff? hmmm thought I read somewhere > that was not right... anyway ... I can do that :P > and cautious is a not wanting to tred on toes just yet :P I am sure that > will change after patch 3 or 4 ... :P Oh, don't worry about my toes, on public lists I tend to wear steel caps :}. Rob
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |