DMARC-Filter:	OpenDMARC Filter v1.4.2 delorie.com 53T3Eg691223470
Authentication-Results:	delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results:	delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter:	OpenDKIM Filter v2.11.0 delorie.com 53T3Eg691223470
Authentication-Results:	delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=J5zQPWy3
X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org A3B0F3858433
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1745896480;
	bh=VlempreDe2EJOIzo7rs5J+LfXzwPrsCe2O0HH0zJ0n4=;
	h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post:
	List-Help:List-Subscribe:From:Reply-To:From;
	b=J5zQPWy3wbnY+AxSTZPimrYM83d4t0Iyeu+tfUdmCoTNFuvucQUXc5V+WH4C4a7UR
	yP3+AH0uGJQS+fbG5LTGbmGpX6H0QKDdDjIosuqAOxIk3KEl4tiAYkK467GvPYgsJP
	EhD2o2USt+lYqXMpTKC2XvcewaFx6dbXFkU3p/6E=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org 09FDE3858D32
ARC-Filter:	OpenARC Filter v1.0.0 sourceware.org 09FDE3858D32
ARC-Seal:	i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745896455; cv=none;
	b=GPbm7em00rq3B57qIxKoRqIU0+dYn5egee9+jvALijhZ0ZgELoOlaRTlVBpJzEueQfmqnMB52hS7TrMSDMlq2ZOvyCJLnDm+7+ODdAapsEE8+1x3gVs4m3AbJY0ciYvt//73PZGe54q5+dtAfMWYRwkjk6mq14ULm0SmO/+Nq5o=
ARC-Message-Signature:	i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1745896455; c=relaxed/simple;
	bh=0FysaWDBrGO4n/J8tjtYOxwk9hxXAghkS4DVJNsYPNA=;
	h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;
	b=FqUQw6Rz4FJ9H8V5Sy7DZvvKKw8I7fKe1jfCIbv3nvya+sCgV9XGI+i4TJirB8o/4OOrfPjXe4YrLKvdLjSSDGU+Vq7JEie06FU+MJF2Z/cRje/iTSNbcVwutGHeI1UfYEBQ8yZXdLp8Mu7cQCadSi1jYxSDdv2QzjkYkQOYtU4=
ARC-Authentication-Results:	i=1; server2.sourceware.org
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 09FDE3858D32
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1745896453; x=1746501253;
	h=to:subject:message-id:date:from:mime-version:x-gm-message-state
	:from:to:cc:subject:date:message-id:reply-to;
	bh=KO90wJSt2sLyECXt+Q+7e2EiBA9dv02abpHv9iEeTLo=;
	b=XCEXAR92herLHmFa0nuJ+sgq8NZLQYNWDxuvdRjWrzI+aSUtSuVQYNfB775+XHuXjw
	PYtgmNGkhUVEgF8xZ3hwTZzx9PTrELQESGtd3ZOD24tHVUrQDkBODy1iWUn9aiTLpZh5
	bhnWbVf6pvsH1HmKuwHbhd+zeI8lvac/GCMMt8UJRGqhe4FG71BKRGPjHptiMsVj0uRX
	5/ppNf522oajh+L3KO27yMDnZ7I/GTyVui/bkc8I13ke8shD42m0Kjlf1c59xFNrkUCa
	nf8FbCF6QHWY7MX+PKGaDz4BtaLCXG6LuwdI+Vu5hcKh0hPATWx7wS+YcI7Xg2uV8pwB
	aAIA==
X-Gm-Message-State:	AOJu0Yx/2gnatJgA34AmJrFBEIQkNeIJaShoProcEao387exyh1pcZhR
	/J4TIHxoKTEsLcy838PA16FyHz9knRf6DZxCemxn3hEuQ+LuZyq+9RiR6HgDxBfD2+QZzmzYv+t
	C7GbkS8kkSqAk6++m+lrMYC9lDAsNNSXj
X-Gm-Gg:	ASbGnctOFJVBWa8x16kFMBmFrniICUUiQ5dlyiWa2FIgBPlwvwXkD40wdl9fJWTnjXP
	7nkVYpplI0a7H9SROoTXH5ftVmUGcZm18xueFm9T8OL01KTqJUpYcWvPJGUt+RUUxxTCSLWpz2f
	Q/XAWeox3lGOv9YRa1Cho=
X-Google-Smtp-Source:	AGHT+IEAghU3NSLKIe1OX7mT9zX3MxbtlkvxP+QuSEgi/sUSWbEzJnS0y38KSuvN5GcGCd/iDthKKnU7YBpzrveC/EU=
X-Received:	by 2002:a05:651c:506:b0:310:749c:f8da with SMTP id
	38308e7fff4ca-31d5b13ed31mr2797281fa.22.1745896452738; Mon, 28 Apr 2025
	20:14:12 -0700 (PDT)
MIME-Version:	1.0
Date:	Mon, 28 Apr 2025 23:13:59 -0400
X-Gm-Features:	ATxdqUFCftOXEjZQmq9NPAgN85xyV03Tc4nv8EqlJOBbtEYh3c1eM5dP-GCKzks
Message-ID:	<CAGB_HuR1kZm4e0s=eqJtJixS_ukf-p6U3rr_Hm+c+z_HwVbqqw@mail.gmail.com>
Subject:	gnu-patch source, cygwin maintainer patches don't apply cleanly
To:	cygwin AT cygwin DOT com
X-Content-Filtered-By:	Mailman/MimeDel 2.1.30
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Soren via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Soren <somian08 AT gmail DOT com>
Sender:	"Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

Hello Cygwinstas,

I spent last night and some of today working on building the gnu-patch
utility from the source code downloaded using setup. I desired to do this
in order to learn more about the general procedures involved
(re-familiarizing myself with Autoconfiscated projects, primarily) , and I
plan on applying this acquired knowledge to other builds in the future.

My concerns were raised by how many of the patches I applied (by hand, so
to speak) failed in one or more places. I am afraid I can't serve up all
the examples (maybe a good thing, would have made this message huge). I
closed the terminal I was working in before I decided to compose this
message.

Here's a list of the patches anyhow:

patch.cygport
patch-CVE-2018-1000156.patch
patch-2.7.6-test-suite-compatibility-fixes.patch
patch-2.7.6-switch-from-fork-execlp-to-execute.patch
patch-2.7.6-skip-ed-test-when-the-ed-utility-is-not-installed.patch
patch-2.7.6-make-debug-output-more-useful.patch
patch-2.7.6-improve_support_for_memory_leak_detection.patch
patch-2.7.6-fix-segfault-with-mangled-rename-patch.patch
patch-2.7.6-fix-korn-shell-incompatibility.patch
patch-2.7.6-fix-ed-style-test-failure.patch
patch-2.7.6-failed_assertion.patch
patch-2.7.6-dont-leak-temporary-file-on-failed-multi-file-ed-style-patch.patch
patch-2.7.6-dont-leak-temporary-file-on-failed-ed-style-patch.patch
patch-2.7.6-CVE-2019-13638-invoked-ed-directly-instead-of-using-the-shell.patch
patch-2.7.6-CVE-2019-13636-symlinks.patch
patch-2.7.6-CVE-2018-6952-fix-swapping-fake-lines-in-pch_swap.patch
patch-2.7.6-CVE-2018-17942.patch
patch-2.7.6-crash-RLIMIT_NOFILE.patch
patch-2.7.6-cleanups-in-do_ed_script.patch
patch-2.7.6-check-of-return-value-of-fwrite.patch
patch-2.7.6-avoid-warnings-gcc8.patch
patch-2.7.6-avoid-set_file_attributes-sign-conversion-warnings.patch
patch-2.7.6-avoid-invalid-memory-access-in-context-format-diffs.patch
patch-2.7.6-allow-input-files-to-be-missing-for-ed-style-patches.patch
patch-2.7.6-abort_when_cleaning_up_fails.patch


In at least half the cases in the list above, the patch failed; where it
succeeded it was sometimes 6 or 9 lines off.
Is it unusual to have this happen? I ignored patch.cygport, btw, as it did
not seem to apply to the task at hand.

'patch'  only failed one test, and a build for Debian of the same release
also failed that same test (something like set-mode). I installed the
home-built 'patch' and it seems to be sound and reliable.

-- 
Soren 'tino
He's earthy, he's pithy, he's ...a bit astringent.
Think of him more as a "topical antiseptic" than as a snack.
somian08 AT gmail DOT com  https://instagram.com/samhain08/

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -