DMARC-Filter:	OpenDMARC Filter v1.4.2 delorie.com 535DqiZX344552
Authentication-Results:	delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results:	delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter:	OpenDKIM Filter v2.11.0 delorie.com 535DqiZX344552
Authentication-Results:	delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=F4Zr+kGO
X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org C5FFA3865483
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1743861163;
	bh=J4U3M2jzg3Z79sYsaa/MjVXXv8K7yTOf4Il4yBQuNjs=;
	h=Date:Subject:To:References:Cc:In-Reply-To:List-Id:
	List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	From:Reply-To:From;
	b=F4Zr+kGOAUcN2K+UagMwz4xenGAzRrRYGI6fjLoiyYwPIsaZ2jplnA97BWve9EgrU
	8kCFPQ7LOlZqnj5876X7YuzxL8iD8vGrgOAwA5ApIy83QpcXsj9wS/QSnaubnL+z6/
	NfuY3+A4nZpqB4NUf0aExAGjIal1yFCSBGGtVes4=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org 24681385841E
ARC-Filter:	OpenARC Filter v1.0.0 sourceware.org 24681385841E
ARC-Seal:	i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743861102; cv=none;
	b=S4Oa8g3EXVqvF6j7+KWvpQcVTFtFgJG7Srq8KZ/hRTGukQiwsIMGuxnOnH/TDfSDQdhraJSnCoZwpKPvDWPuQUduv38LTMnBvZ2Yf4Hgr3Hkn4QbvEA4RWAWIGGxxRoT5w0+nRia4Gpevl9eXCQ9rdZe3zpdy/sgNV3MiDBxU2k=
ARC-Message-Signature:	i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1743861102; c=relaxed/simple;
	bh=LZioekfVxBWrNT9ykVMLv1v+EtuFbEjPvxrYLP+SIrc=;
	h=Message-ID:Date:MIME-Version:Subject:To:From;
	b=b729uXr01dL1u8z/Fg7jcDOVYUd9mF6+Sbca6yJ1+rC8tudY3xQ17+E73qyWeCfCMfuGZ5FBMykE02uAKlJ0CQmgpk4YWQxOIdAu3bPpsWc6f0hfxOn+XJRkiHCiUEUuaf00RDEJB5qnVerMBP0+rfyEO4QG9Gy8Zw7NpzlKMxY=
ARC-Authentication-Results:	i=1; server2.sourceware.org
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 24681385841E
X-SNCR-Rigid:	67D89D9E024D1F5E
X-Originating-IP:	[81.129.146.194]
X-OWM-Source-IP:	81.129.146.194
X-OWM-Env-Sender:	jon DOT turney AT dronecode DOT org DOT uk
X-RazorGate-Vade:	gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduleeghedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhepkfffgggfuffvfhfhvegjtgfgsehtjeertddtvdejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeevvdekgfffteetueehgfdugefgkeevleejudduheevuedtveejfeevvdevvdfgvdenucfkphepkedurdduvdelrddugeeirdduleegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdelngdpihhnvghtpeekuddruddvledrudegiedrudelgedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhrvghvkffrpehhohhsthekuddquddvledqudegiedqudelgedrrhgrnhhgvgekuddquddvledrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgvhiessghtihhnthgvrhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffvtefjohhsthepsghtphhrughrghhotddtkedpnhgspghrtghpthhtohepvddprhgtphhtthhopegthihgfihinhestgihghifihhnrdgtohhmpdhrtghpthhtoheptgihghifihhnsehj
	ughrrghkvgdrtghomh
X-RazorGate-Vade-Verdict:	clean 0
X-RazorGate-Vade-Classification:	clean
X-VadeSecure-score:	verdict=clean score=0/300, class=clean
Message-ID:	<15190784-9033-46f6-b8d5-1136283958fe@dronecode.org.uk>
Date:	Sat, 5 Apr 2025 14:51:37 +0100
MIME-Version:	1.0
User-Agent:	Mozilla Thunderbird
Subject:	Re: dladdr and dll refcount
To:	Jeremy Drake <cygwin AT jdrake DOT com>
References:	<2ace5ff8-29a2-06a4-6c24-668439d4eb08 AT jdrake DOT com>
Cc:	cygwin AT cygwin DOT com
In-Reply-To:	<2ace5ff8-29a2-06a4-6c24-668439d4eb08@jdrake.com>
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Jon Turney via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Jon Turney <jon DOT turney AT dronecode DOT org DOT uk>
Errors-To:	cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On 05/04/2025 06:28, Jeremy Drake via Cygwin wrote:
> I just happened to look at dlfcn.cc dladdr function, and I had a question.
> Should dladdr be using the GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT
> flag?  It doesn't seem like dladdr should be incrementing the refcount.

Indeed. Well spotted.

This looks like my mistake back in commit 
c8432a01c8401c121940c806a9d868c4adc4cefd

Assuming that flag is available on all applicable Windows versions, it 
certainly looks like we should be using it (otherwise, I guess we just 
immediately free the handle).


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -