Mail Archives: cygwin/2024/12/18/18:05:48

Ken Brown via Cygwin <cygwin AT cygwin DOT com> · Wed, 18 Dec 2024 18:05:11 -0500

On 12/18/2024 5:24 PM, Ken Brown via Cygwin wrote:
> On 12/18/2024 1:35 PM, Corinna Vinschen via Cygwin wrote:
>> On Dec 18 10:45, Ken Brown via Cygwin wrote:
>>> No, I'm still confused.  I thought that the interval determined by 
>>> u_addr
>>> and u_len was the intersection of the requested interval and the whole
>>> interval of the mmap_record; this implies u_addr >= addr.  Back in the
>>> definition of mmap_record::match, we set low = max (addr, get_address 
>>> ()),
>>> and then on success we set m_add = low.  Doesn't that imply m_addr >= 
>>> addr?
>>> Sorry if I'm just being dense.
>>
>> Apologies, I didn't check mmap_record::match().  You're right of course.
>> So, yeah, just go ahead.
> I think I'm seeing a similar confusion in 
> mmap_is_attached_or_noreserve().  I'm tired now and am having trouble 
> sorting out exactly what that function is doing.  But the definition of 
> commit_len looks suspicious to me.  We know from above that start_addr 
> <= u_addr.  So the quantity we're subtracting from u_len is actually <= 
> 0.  That can't be what's intended.  Then in the call to VirtualAlloc, 
> we're allocating starting at start_addr.  But how do we know that 
> start_addr is in the noreserve region mapped by rec?  All we know is 
> that the interval from u_addr to u_addr + u_len is in that region.

The only thing I can come up with immediately is that we should sort the 
list of mmap_records in order of their starting addresses.  Then if 
start_addr == u_addr, we commit u_len bytes, otherwise we fail.

> I hope I'm just missing something obvious.
Still hoping...

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

DMARC-Filter:	OpenDMARC Filter v1.4.2 delorie.com 4BIN5lgR651131
Authentication-Results:	delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results:	delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter:	OpenDKIM Filter v2.11.0 delorie.com 4BIN5lgR651131
Authentication-Results:	delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=QNrxsVZy
X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org D292D3858D3C
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1734563146;
	bh=j5AnRMJy7AUnliPTVljenZLDrxHa3ZYOT9Jnnf76i8g=;
	h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	From;
	b=QNrxsVZyNDl4TGm6yMmscgr+iME6Zp6TftaS87cJ0j3DI8vt+DY9vHhxKAmg2NroX
	BXEgTc8+crqAhahYgPaZ2CKvCr+U9NuMD1cFlj9BWUSZUmjMgwtiCkNLgar5OKhzQ1
	CDVkoETQEljpWpU59PKFVbUVnbejBECT2IKR9GdA=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org 53A963858D20
ARC-Filter:	OpenARC Filter v1.0.0 sourceware.org 53A963858D20
ARC-Seal:	i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1734563115; cv=pass;
	b=olcaJR6tZxjkgacQdSxF5X3smo6P5QOGJN7dMWtfHpekaMnn8qqqROThtRDq1jvOXCk25gfqutT/Ix8hka3VleNcWEGzbIiDLEDkTNuiUOge6S9o4Fd/WycZDLj0wZ4jZ5CyBPShbBBSglp+e0grIDQPosaQt22W8beTcF7HxZw=
ARC-Message-Signature:	i=2; a=rsa-sha256; d=sourceware.org; s=key;
	t=1734563115; c=relaxed/simple;
	bh=D1xmdJ2B4AqqjzvGH61EGGCqQrNYbDVmNHfvflZT7Vw=;
	h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version;
	b=mxttC9cWQNa3nLbZfmFJE9sWDlKRXGMqVJJnaM/Ytjtpe+G/jLQsfTjonD+yumeqZVnIMbxZGXpCccOciDLudBdg771jSdJ45aZdEjmxZA6Qml8fumE6IqhBV0jLVp+nJvJ0AHE60mf9h/+B/ollS4ADyIauPQB8mgHO0kF7+fI=
ARC-Authentication-Results:	i=2; server2.sourceware.org
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 53A963858D20
ARC-Seal:	i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
	b=kSYA4K8XFliCR7Y7pdHQP7GqI8IZE/4d1odeAoz/U1aKenotTpzz+bY2LWxWsYg1gmPaJB4WK5YvfNxhgvMeyY3rJOKMA2CKVkbQ1Z8h6y6KP+pqp3JpvZJ6M5bSjZt0ojC/1wQUUai96N7IwZuROamrxNKTNqzM+Y6wg7y3hTJvstQN18+ob7KbgPypqd/SWUCwiWtCALAi855A0qgBzzCgWJEf2ORMxb6N8SwdmUK6xdh2GEogIaDrJAUNarQElWJnkf3+AWPult8UuHdHRcW3zKl0q7JQhNOZWjOFmfSWgZIwAx0ifvVueuOVlnZ7UwhtcSu1lvBeCBrBIthrOg==
ARC-Message-Signature:	i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
	s=arcselector10001;
	h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
	bh=QHwCkvDGWaMr7rXBn14Hl3iQTIg4DkrGOmfq+DNRTTk=;
	b=QxPrDslble09HU2tlp4LTE+NzdJwWXwp8OI2eqQtfu84ManKgrbQefSnCyDsEcwB2N+32SY2GZBDNpRrpj9/5/Of1OXu7BqjdrfvgSEM46htriiAhjdooJf0pAjNFKwUFMZ6dS7+/mRW++nrPry2Lycifrqod0c1jp/7Ax6vjSJcoNy1GlG7yeUf57EJe/0hcipfHzHDUMBvP1b5pGLwwD0rbsWEIYB8p57QUJvXhFsYwzJ2KyxLGO5LBkEQ3YlvgaYxeW6PchPHEzrffEjMt5x6TLLbXdb792+Hsve/zG/cpYwR8S4nnWN6WlU5IG/BuwlWJ2g+Pi27w4OIgjEUQA==
ARC-Authentication-Results:	i=1; mx.microsoft.com 1; spf=pass
	smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu;
	dkim=pass header.d=cornell.edu; arc=none
Message-ID:	<749daa4c-a4a6-41fd-bd34-2a70d942465a@cornell.edu>
Date:	Wed, 18 Dec 2024 18:05:11 -0500
User-Agent:	Mozilla Thunderbird
Subject:	Re: Atomic mmap replacement
To:	cygwin AT cygwin DOT com
References:	<20180219090042 DOT GC3417 AT calimero DOT vinschen DOT de>
	<e6b3bd42-f981-405e-b65b-529693598735 AT cornell DOT edu>
	<d84f7f6c-5527-4f39-83a5-1aa16d8e451f AT cornell DOT edu>
	<Z2AsCg7Oo4FyHFjG AT calimero DOT vinschen DOT de>
	<b7564609-6a87-4691-b5ec-1f56b51543df AT cornell DOT edu>
	<bb796c13-c2b7-48a0-899b-cc7485fee783 AT cornell DOT edu>
	<Z2GpCxIUDMqp6yen AT calimero DOT vinschen DOT de>
	<cbeac0c9-70a1-4be9-acbb-eceadfde2e1e AT cornell DOT edu>
	<Z2LcCIToHJ8Xc0VV AT calimero DOT vinschen DOT de>
	<b060fb24-ba47-45f6-95b1-cad18aa01df6 AT cornell DOT edu>
	<Z2MV__BG-IdmtGvc AT calimero DOT vinschen DOT de>
	<60ceffc6-083e-4877-982f-76ae121a4a99 AT cornell DOT edu>
In-Reply-To:	<60ceffc6-083e-4877-982f-76ae121a4a99@cornell.edu>
X-ClientProxiedBy:	BL0PR0102CA0043.prod.exchangelabs.com
	(2603:10b6:208:25::20) To SN6PR04MB5151.namprd04.prod.outlook.com
	(2603:10b6:805:90::25)
MIME-Version:	1.0
X-MS-PublicTrafficType:	Email
X-MS-TrafficTypeDiagnostic:	SN6PR04MB5151:EE_\|SA6PR04MB9326:EE_
X-MS-Office365-Filtering-Correlation-Id:	800f8172-4efb-4fc7-330e-08dd1fb86d8d
X-MS-Exchange-SenderADCheck:	1
X-MS-Exchange-AntiSpam-Relay:	0
X-Microsoft-Antispam:	BCL:0;ARA:13230040\|1800799024\|376014\|366016;
X-Microsoft-Antispam-Message-Info:	=?utf-8?B?cGx2cXV1ZEp4UUgxRG5SeFlsa0oxSWcrUHJPTi9SdmZuSXpLUzRReTBVSC9p?=
	=?utf-8?B?dWtQVjd4M0Y2UjlwQ3JmQS9HbDlIZGk2aFQyVy9rU0o3azI0aFpWeSs0bGYw?=
	=?utf-8?B?VjNXZWt6b0ttYWIySDM0Wjl2YVBseDRUci9CMHFUczdsazM3SzJucVVza3pV?=
	=?utf-8?B?SURWcHhKNEIraU5YMk43UTIwK2RXWFU1VlFEMmR0Q2NKaXhib0N2dWIwVWZF?=
	=?utf-8?B?ZXJOeURvZ0MzR09kK3JCMWhOeEtGL3pFVUdoYjdUTmdrcU5KTmhScWR1dEc1?=
	=?utf-8?B?eGhHdXUvL3VLK3RLd01qWFpxWTVVQ2k5SDVjZkFZM1pMK0o2UTBOOVdMdDhM?=
	=?utf-8?B?OHIySlNhRjExT2Yvckg0QitlYmQ4aTR2NkFrNjdTbXhZb3dhTlBTV2phalNN?=
	=?utf-8?B?ZVpvUG8yOEE2UTF0UFJxTEZFUVJXaFNKb3pwTkJlU0NRb2twemZ2ZmpDQXdY?=
	=?utf-8?B?RFUrakRCSnJvWDZQQkJlRUVFbHBscWY0bUx6U1BLNlBnZnF4Z0ExL0N0WVJQ?=
	=?utf-8?B?Qk80ZXpEOGsxdlpoSDJoMGVIN1JHeWcrK0VRc1EwVDB2TmdUcHQ3Rmdld0No?=
	=?utf-8?B?dlZuY0xPVTY2NGVkVitRalM5YzVXbXNlc2p5bmRDb0FHUCtqNG5aTkg0L1dx?=
	=?utf-8?B?SGNqOHNFVnpLYzFhN3JxV3J1WXErUU5CSnZLSUdkZThURks3cFNBaGNIUEsr?=
	=?utf-8?B?VFlEUW9aTnZBTXRIbVY5NmhEZ0tnakNoQXoyOXVHSzgrMlhsbm9HRU9yQmly?=
	=?utf-8?B?aC9Sd1NPOUN1a2lidnFQeGtkREU1M1A1dSt3QytwUnF4TGI1ZFNDcGZ1dWFr?=
	=?utf-8?B?b2tkaDl2ck9nYkp3V0VCV2VLTm5PUnBvaEtWbkN6WlY5UWlTSitSMEdhSEph?=
	=?utf-8?B?SU5DNElOYzBXc1lhenV0S3JVVmZjdTRCWG5UQjVHYWQ3c2Rybmw3dkJOdUlh?=
	=?utf-8?B?TjIxT2syam8xQU5HOXhnVi9YRHZxUFc4SDNiblZRT0pYeDBLbTFNN0JhdU5t?=
	=?utf-8?B?SGsrRnB6dFd4ekF2L1RzU3FhdzBES3RNR29RK2s3M3g2MGc0L3MybGtHZDRk?=
	=?utf-8?B?eUxONmdickJ5aEtjZmJjSERucmowcVFyRWtCbHlDT3JKMXR6Qi9pVyswSmlu?=
	=?utf-8?B?TCtNcG9OdVBqdktPWnJYSzFJaGdjWG9rbU5GZWRvM1FOZXVaYlBGODhjZDF4?=
	=?utf-8?B?SXRiZ0h1TXl1aHI2cHlCajgvQTNRYzdOblJnVHY1eUhaY1VxQW5FeFBWbVp4?=
	=?utf-8?B?OERHekFuQjNqM09DWFo3Z1UrOU9DbUJNeExTM3VqOVRVNVVSSzJkRXNsZmdI?=
	=?utf-8?B?TWY5cXM0bnZIWXlwUSszU3k4d2MzMHN6YUFZeW9lTW9WUDdxYk5GaENaaUJV?=
	=?utf-8?B?MUlJRGFrWnI5dTB0VVlweThXY0k0WnR6QXRBUTRROFZyQTRnY3hvd0pldk1H?=
	=?utf-8?B?LzZESzYrOGFUVStqa2xlRHZCZFp1Y3p3SUhKU2pibUNQa2lLZDh4RmkyMWpo?=
	=?utf-8?B?TElTQzBudFBESkxGNjZkNzdUY1BCK3lPMDV3SEk3YlNrN2FiL1NWdUlFT1M4?=
	=?utf-8?B?OUVXelRIY3FEVG1Od0tid1pDUnAvUHNwQW1TZDl5UFJFaXZHVGxBQTQ1NVNW?=
	=?utf-8?B?cVBkQTNqMjFCaEJiVjhnN2NKM2g4bVJ5V0NkUWV5NjZHVUU3cVI2N3BDRVFT?=
	=?utf-8?B?ZFFmRjY0RGsyeGFKdDB3QlFTL1liZnZQNXNYemFzUVQwNm8vcHoxMlVvQjF4?=
	=?utf-8?B?VHY2aENFR091NEI0aUJveTJNaEtKM1NLUVNiWnJRZTRJanZ6YVYrQTZPSGdP?=
	=?utf-8?B?TVZaQ3AxeklSN3N5bSsrM1MyM3BCK0UvdWRPeWRjdldMWlpwMDAxUTUzTisw?=
	=?utf-8?Q?PdBMplHkSBE1/?=
X-Forefront-Antispam-Report:	CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
	IPV:NLI; SFV:NSPM; H:SN6PR04MB5151.namprd04.prod.outlook.com; PTR:; CAT:NONE;
	SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount:	1
X-MS-Exchange-AntiSpam-MessageData-0:	=?utf-8?B?M0s1cEE0bC9jMEQzeC94N2VrSXo1Q3oyK2tTUnQ5U3pleW5IRnREdGdVZlJN?=
	=?utf-8?B?aHJPQm54ZnIvOVRTRmVuVWxiT0VQWXA1bVJ2TmhZMXhXc3FoVU1XdC96RGlG?=
	=?utf-8?B?enRqcWZqczkxdlNDelRxVGc3cUNjeEw1aUJ5N0h3V21QOFk2MzZSRWc2dzhq?=
	=?utf-8?B?VHNVc3VUTzc0RzB1UmRNMEV2UDZqeGU1dzFkZEdTd29HNitqc1FrTTIraWZG?=
	=?utf-8?B?WWtOTloxWkpoV000K1NGV3JqakNlZXRwYVVIa3hFcHdPZkoyTDNOOXhOaHha?=
	=?utf-8?B?NXRndXhMSFVVVXFJMVNEcWZCNWVWaHp5aFo5a2lDenVUMWFoaFU1Y3ZPTm5y?=
	=?utf-8?B?WUc5Y3VvSWNGcHo0S0kxakhiaDFYdXlqajYrQVdkazdwalR1RE00bEtpWjNq?=
	=?utf-8?B?TWxBOGMyUnVQbmZFaks0ODdWRHJJb1JnY3VZTk80MmlDRVJUUmRWS21XYk0x?=
	=?utf-8?B?aFFEdEc5YXp3ZWpoam9aUmJUTExRaElPMzRZUzREWVZ2YS9ZQVA4ekp2NUlv?=
	=?utf-8?B?K1FPMi9wZ2VDeC9DNklaTHdFTkVzTmc1U3ZtWW93STkzenNnbjNhV3B5aVpp?=
	=?utf-8?B?bFVCS1RYc2p4bEFyb0k0VFEvOWtwU014Z09Fb01nUmVCbE1yV2MrYnU2MWxE?=
	=?utf-8?B?bHRYZ0RrYy9WeGhxcW1kWU1JdDdRWGlDd3l6eTd2cG92bDh1YzVreWJ1WW9O?=
	=?utf-8?B?Qk5DVWpGZ0JCVmJTaEZKNDN2K1J4Tk1hOHpmK01TUFppeGwvaVZzeEwxSE5a?=
	=?utf-8?B?SFVMWkw0aU55anRqdzRpcDNWWXF3L2hyMlZXWEduUkdIL0wySkN2MEdscFds?=
	=?utf-8?B?ZHRBa200eWNFTUlXN2Z6eFlnT1pBMk1DOEFLbU9FVnZSU1V4cnpCcEt1SkpJ?=
	=?utf-8?B?Yi9ZUk5BS0lYRHpPR1lXcU00L1R3MEY0Y1NyK2ZpR0twb0VKcmt2NERNVWpJ?=
	=?utf-8?B?VmR0bzJSUVphbDFoUjdRdWRJTHJpR1h5T1gxMDhzVVFSbW1sbVptVTgzZzdo?=
	=?utf-8?B?Y0RZbko2N1RoVGdxbGNuM0x4a2ExV3NUcXJ5NWQ3dDY4R1pPbU1Zelp0a0tO?=
	=?utf-8?B?ZnBtOVFJYUdBaWVwT3hRWVBPSW05KzZsdk1JbUJpT3p3VlhiMFIwQkRMSEYy?=
	=?utf-8?B?UVA0bTNtclVYMDFEU2lhbyt2VHhGSTBhaWlsRXZXaFZHa3JpWjIwQlpSNmxo?=
	=?utf-8?B?MGVPNDRkaklzQnhOQ0RFY1JUOVpiOXdpV0dxT3ZEK09MQmNWYThqbFFxUHFR?=
	=?utf-8?B?dlFGb3duYkJ6dERTM0JjQnJPdG1oYmJKY1ltaUtESy9YNmVoNWVKOG9XeVcr?=
	=?utf-8?B?SnB0ZDJETDhNSU8zckFJYWM2d1ZHTlBqbW9haFlxbHZaTFBJcEhHMnY5anRQ?=
	=?utf-8?B?bFJScG94bGF4WkFVaUlHWmV2WU5Pbnc5WlhKcG1uWkIzTE4yQVYrcDdPL0M1?=
	=?utf-8?B?WWFYRXozeStkdUFVMi9kQjlxY2dpSG9NbDJ0RmFCTWo1dFkzRjJtL0M1WWNj?=
	=?utf-8?B?TjlIMmV6UWhON2FLYW42N1J6ZUVSVVN5TzN2dmVMbis5c3ZlTTUxMHdvM0lG?=
	=?utf-8?B?Q2pFc3VpelR4VXBad3hxV3l3UndEL1NHS0NpQUt4T2YzN2o1bm1qOC9zd0Zq?=
	=?utf-8?B?Vy9FRTU3R2RJbTE3Q0JGQWtaTk5VZVlSeC8wSlFGQnJCaXppSHN1NDhiVnpR?=
	=?utf-8?B?WmRibTluS0dLK3Z0QUZEbVBqcmVYdHdZZSsvcHo0dThGT1BkZzVxTWJiZWly?=
	=?utf-8?B?N2w3b0ZQQ2FicmZna3NJMVozWmxyOEdkdnNPODRyZWFYbGRZK2F0MlBEakZX?=
	=?utf-8?B?ODFHTnVTdEtmeER4dU1zUVVhcElFeXhVZGF6c29ucUlLd29VOFlTbjRYb2dn?=
	=?utf-8?B?RG5LSzFIeEZMb2ZoMjI4RFBYY2FOMjRwVXQ2QlJzc05CN09NN3c2MmQzakFw?=
	=?utf-8?B?TjhHOGZSRFJmMzdqVkt1VWNpMitWWHdNMHQzUWpvZjZrZ2RETGExOGxnWnpE?=
	=?utf-8?B?OW9GdUhHUXU1MTlTdDI4LzU2eFRkWWYzQUJIN3p2Tk1hRXN6T2EvajJ1eDBX?=
	=?utf-8?B?T3ZFZTJZaHk5cmQrR3h4ZWNwZTF3am1rZzZWeWdENHhXdzgwUVlnNHprc1JZ?=
	=?utf-8?Q?/4nd6dnRT7w9yAuKjIcGBD/ls?=
X-OriginatorOrg:	cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id:	800f8172-4efb-4fc7-330e-08dd1fb86d8d
X-MS-Exchange-CrossTenant-AuthSource:	SN6PR04MB5151.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs:	Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime:	18 Dec 2024 23:05:13.1637 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader:	Hosted
X-MS-Exchange-CrossTenant-Id:	5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType:	HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName:	UNabvWBGAICDmZIidkuwFaB3gntnCWYKCKoQDU6fa30kBZ7s3+96vpu4Va5r03IN4UbBki/dWwyccv8nDo9vkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped:	SA6PR04MB9326
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Ken Brown via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Ken Brown <kbrown AT cornell DOT edu>
Errors-To:	cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>
X-MIME-Autoconverted:	from base64 to 8bit by delorie.com id 4BIN5lgR651131

webmaster	delorie software privacy
Copyright � 2019 by DJ Delorie	Updated Jul 2019