DMARC-Filter:	OpenDMARC Filter v1.4.2 delorie.com 4AGMagMD1904802
Authentication-Results:	delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results:	delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter:	OpenDKIM Filter v2.11.0 delorie.com 4AGMagMD1904802
Authentication-Results:	delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=xF2w6007
X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 544043857358
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1731796600;
	bh=fcc1EZj91NMzeJ+wAcTVfnA7vlWKmyWHgTQQkJp0IOw=;
	h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:
	List-Help:List-Subscribe:From:Reply-To:From;
	b=xF2w60077b3aze4mpG0SYA5juWb433Q4mXP4RGPbNVvIoU74j860U+cTZ+qaM4J21
	viNsN+dod/BkFt6XJf1ioBplkODompbX3MciIRr6C/6QXUhR7mle4VzJtzhcxKLVdO
	U+DbTYe8thIxFtVsfn6ylqJMzb6ssHOfv8kaoNog=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org 299683857734
ARC-Filter:	OpenARC Filter v1.0.0 sourceware.org 299683857734
ARC-Seal:	i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731796572; cv=none;
	b=xu4gc/v8OoHWqC8q9drhg4CkyUK4etJ+C4+yD89F+HV1Kn8+OwJ0nKCALzkAKFIvMB8/4imwv5or8IQOhxAEC0BIwi5osIONY+5Z9iw6tAgEoCIO/bRdup4sfOoo7So6zLfyj1jMdNp4hHt9ppmj7VXtRcHnUJI3Cvbg4YtBIIQ=
ARC-Message-Signature:	i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1731796572; c=relaxed/simple;
	bh=N2i7PhrGn9Ny1EB+P9ZozF1v2YaDySYfD5HEHj47bX8=;
	h=DKIM-Signature:Message-ID:Date:MIME-Version:From:To:Subject;
	b=CMJnoUnXhM6MNN8PE7CVVzEfyp5djXVPEG7cyFFbGTJXlNElR5hiW95PnArVrzsaPzLomZv9VQ941z5vKhQNEVts4I2ijLtu1lnZXWjCJxZfSE8xTOXYH49jiiLN4K1omefiwOQZs39BnoWvsIYWoYW79vBXIe0te3Zi6eXwLyU=
ARC-Authentication-Results:	i=1; server2.sourceware.org
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 299683857734
Message-ID:	<9f95d44b-2a46-4da8-9177-fc9b60a6d18e@mailbox.org>
Date:	Sat, 16 Nov 2024 23:36:06 +0100
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Possible issue with check_dir_not_empty
Autocrypt:	addr=bernhardu AT mailbox DOT org; keydata=
	xsBNBFLFOk0BCADSnIOyw5hwhDXc5yKipb7asfzYmBwgRL9NfM9W8fNz8G5iphXTX2cAvrMy
	7CAOaktgz3yvWiJvf3l5GAB7FrA7HaY0sLRbhCcS06jvEAH3HScfaK+qPeJA1mHo11VudH5E
	oaOUKNz6xy5Gb30SuISwVF+i30GeJNi3DTk8zGjqPQHEQiEo8CJ0Hc1r/fUgo+F9f1ugpZNG
	Hn/ZJowpfCGRcNrrRC199MDI2m4q00i1bda8Z1P2PZTUZDWjD3dpzfkvVLSU+68Y49Kyv934
	Qkj6LV/qw+4wnexWtgBCBTklz0ocVAN2wh/6VQ6ny3I3pJd9Phyd5qDmURZ08u8BZXEtABEB
	AAHNK0Jlcm5oYXJkIMOcYmVsYWNrZXIgPGJlcm5oYXJkdUBtYWlsYm94Lm9yZz7CwJUEEwEK
	AD8CGyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAFiEE7HR0CmaRX6NuV4XV6W+iX4OmQeYF
	AmUarOEFCRf5nZMACgkQ6W+iX4OmQeaArAf/W+zJJHAQX60M9+P6RsZ/eIy+FLGCR1nJptSx
	x3LHDp7qQG1ZrMTyKBwyEcg9HGVWimg+KIdQaZaT3xnpbOGDz05GCDpN6gCiuCpEeLAHVnIp
	glIpHVfpVf3QMzvW+1Sy7bqSnxtXex62eY76SR/tmaGUUrLc5SwKu9xRMxzpT6ALkd76B9/L
	xzf2RyB2wgYEZN9r24vejivsdweBuSE/kZr4rNy1KkBIyosL0M0oOWthuZyy6rSyyJLyPiDV
	IfVgJ3zyqjWtznO4CGcSS3Uqq7YB+kp5KYcPRB373rq17vN/I/5mLV9W66pANzYjEyp4g9mX
	V/AFpX+d20zdrdjGYc7ATQRSxTpNAQgAzY7Lt75go8+7R9OrlxJgLvy2Btad9nI97eiQJ2So
	JW9VF8GpxdTHrHQSst1AuptxlxnsNJ60ajRA8GjQD62VrLwNrm/CJFmKVY1lnwQpk5eM7vdo
	f6zIEd1wLuuYr11tezWEjAky0J7X5sdz3ToPZh+HeIrQYEHexHJe+4vOjelW9nW0un+Hi5jk
	hjw2VwGp8lT+tq9fRxeqUL+L9ctW3btsz/Uf+1h/s3OGo/dlZSTFVAozeHYNZyiyu3Mt9WDs
	Ppbjgz7/FSxmWyworAw1yQeaQyBQgg3S3CH4euepWfBoa71EDH+I4Fw3/17d4wPiR8MXjjSD
	rlMwpV2dd6pj6wARAQABwsB8BBgBCgAmAhsMFiEE7HR0CmaRX6NuV4XV6W+iX4OmQeYFAmUa
	rOEFCRf5nZMACgkQ6W+iX4OmQeZtyQf8CEBfXTO5luF9N3ev6wrwY4sJhJnpoHdrK0s0Tdz9
	Nu0KPxXDhl5OVGWJWDeTZ41FyAtMLVmfBtTa4LNd0zFBvGP5JYoavNME34hOGJIih9mLl+Qu
	nNsVh1okNAYfS2VHOQuESGA9fsSWgli1H84pM1kpqL4vGlVSH+OPAK0H51e6/poQHDHFUq6s
	qmPCDAU0pSYmuuOg/V98WoZW3mtuG1MVLhgNznenctuF7oHx63OdjpCGA0Gv2p78tnPOP2ZZ
	VadUH1G35w/XzlNEPerCul4mdCB/gaDvO4S6Fw7ceBvPy0MutKiJ2BdjD0kW02G3sLLmy8jY
	Xun5X2+YmyYMtA==
X-MBO-RS-ID:	7cbe9aa104811aa7046
X-MBO-RS-META:	aqgs3ep1ozcrwypi8fsz53tp5wzpoph7
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	=?utf-8?q?Bernhard_=C3=9Cbelacker_via_Cygwin?= <cygwin AT cygwin DOT com>
Reply-To:	=?UTF-8?Q?Bernhard_=C3=9Cbelacker?= <bernhardu AT mailbox DOT org>
Sender:	"Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

This is a multi-part message in MIME format.
--------------lKS0lL0R55DIjwDJg2kvXfps
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello everyone,

Is is about the buffer allocated in check_dir_not_empty.

The pointer pfni gets allocated the buffer at the begin,
and is used in the NtQueryDirectoryFile call before the loops.
In the loop the pointer pfni is also used as iterator.
Therefore it holds no longer the initial buffer at the call
to NtQueryDirectoryFile in the while conditition at the bottom.

Attached is a possible modification to always use the allocated buffer.

Kind regards,
Bernhard
--------------lKS0lL0R55DIjwDJg2kvXfps
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Cygwin-check_dir_not_empty-Avoid-leaving-the-allocat.patch"
Content-Disposition: attachment;
 filename*0="0001-Cygwin-check_dir_not_empty-Avoid-leaving-the-allocat.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA2NjdhOGQ1MjU4NzllZDFkMWFlODVjZmE4MWVhMzU2NjM4YmQ0YmQ0IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QmVybmhhcmQ9MjA9QzM9OUNiZWxh
Y2tlcj89IDxiZXJuaGFyZHVAbWFpbGJveC5vcmc+CkRhdGU6IFNhdCwgMTYgTm92IDIwMjQg
MTg6MDk6NTAgKzAxMDAKU3ViamVjdDogQ3lnd2luOiBjaGVja19kaXJfbm90X2VtcHR5OiBB
dm9pZCBsZWF2aW5nIHRoZSBhbGxvY2F0ZWQgYnVmZmVyLgpNSU1FLVZlcnNpb246IDEuMApD
b250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zl
ci1FbmNvZGluZzogOGJpdAoKVGhlIHBvaW50ZXIgcGZuaSBnZXRzIGFsbG9jYXRlZCB0aGUg
YnVmZmVyIGF0IHRoZSBiZWdpbiwKYW5kIGlzIHVzZWQgaW4gdGhlIE50UXVlcnlEaXJlY3Rv
cnlGaWxlIGNhbGwgYmVmb3JlIHRoZSBsb29wcy4KSW4gdGhlIGxvb3AgdGhlIHBvaW50ZXIg
cGZuaSBpcyBhbHNvIHVzZWQgYXMgaXRlcmF0b3IuClRoZXJlZm9yZSBpdCBob2xkcyBubyBs
b25nZXIgdGhlIGluaXRpYWwgYnVmZmVyIGF0IHRoZSBjYWxsCnRvIE50UXVlcnlEaXJlY3Rv
cnlGaWxlIGluIHRoZSB3aGlsZSBjb25kaXRpdGlvbiBhdCB0aGUgYm90dG9tLgoKU2lnbmVk
LW9mZi1ieTogQmVybmhhcmQgw5xiZWxhY2tlciA8YmVybmhhcmR1QG1haWxib3gub3JnPgot
LS0KIHdpbnN1cC9jeWd3aW4vc3lzY2FsbHMuY2MgfCAxNCArKysrKysrKy0tLS0tLQogMSBm
aWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS93aW5zdXAvY3lnd2luL3N5c2NhbGxzLmNjIGIvd2luc3VwL2N5Z3dpbi9zeXNjYWxs
cy5jYwppbmRleCBkZjdkM2ExNGUuLmExOTg3OWFiMiAxMDA2NDQKLS0tIGEvd2luc3VwL2N5
Z3dpbi9zeXNjYWxscy5jYworKysgYi93aW5zdXAvY3lnd2luL3N5c2NhbGxzLmNjCkBAIC02
MTksNiArNjE5LDcgQEAgY2hlY2tfZGlyX25vdF9lbXB0eSAoSEFORExFIGRpciwgcGF0aF9j
b252ICZwYykKIAkJICAgICAgICsgMyAqIE5BTUVfTUFYICogc2l6ZW9mIChXQ0hBUik7CiAg
IFBGSUxFX05BTUVTX0lORk9STUFUSU9OIHBmbmkgPSAoUEZJTEVfTkFNRVNfSU5GT1JNQVRJ
T04pCiAJCQkJIGFsbG9jYSAoYnVmc2l6KTsKKyAgUEZJTEVfTkFNRVNfSU5GT1JNQVRJT04g
cGZuaV9pdDsKICAgTlRTVEFUVVMgc3RhdHVzID0gTnRRdWVyeURpcmVjdG9yeUZpbGUgKGRp
ciwgTlVMTCwgTlVMTCwgMCwgJmlvLCBwZm5pLAogCQkJCQkgIGJ1ZnNpeiwgRmlsZU5hbWVz
SW5mb3JtYXRpb24sCiAJCQkJCSAgRkFMU0UsIE5VTEwsIFRSVUUpOwpAQCAtNjMxLDcgKzYz
Miw4IEBAIGNoZWNrX2Rpcl9ub3RfZW1wdHkgKEhBTkRMRSBkaXIsIHBhdGhfY29udiAmcGMp
CiAgIGludCBjbnQgPSAxOwogICBkbwogICAgIHsKLSAgICAgIHdoaWxlIChwZm5pLT5OZXh0
RW50cnlPZmZzZXQpCisgICAgICBwZm5pX2l0ID0gcGZuaTsKKyAgICAgIHdoaWxlIChwZm5p
X2l0LT5OZXh0RW50cnlPZmZzZXQpCiAJewogCSAgaWYgKCsrY250ID4gMikKIAkgICAgewpA
QCAtNjM5LDEwICs2NDEsMTAgQEAgY2hlY2tfZGlyX25vdF9lbXB0eSAoSEFORExFIGRpciwg
cGF0aF9jb252ICZwYykKIAkgICAgICBPQkpFQ1RfQVRUUklCVVRFUyBhdHRyOwogCSAgICAg
IEZJTEVfQkFTSUNfSU5GT1JNQVRJT04gZmJpOwogCi0JICAgICAgcGZuaSA9IChQRklMRV9O
QU1FU19JTkZPUk1BVElPTikKLQkJICAgICAoKGNhZGRyX3QpIHBmbmkgKyBwZm5pLT5OZXh0
RW50cnlPZmZzZXQpOwotCSAgICAgIFJ0bEluaXRDb3VudGVkVW5pY29kZVN0cmluZygmZm5h
bWUsIHBmbmktPkZpbGVOYW1lLAotCQkJCQkgIHBmbmktPkZpbGVOYW1lTGVuZ3RoKTsKKwkg
ICAgICBwZm5pX2l0ID0gKFBGSUxFX05BTUVTX0lORk9STUFUSU9OKQorCQkJKChjYWRkcl90
KSBwZm5pX2l0ICsgcGZuaV9pdC0+TmV4dEVudHJ5T2Zmc2V0KTsKKwkgICAgICBSdGxJbml0
Q291bnRlZFVuaWNvZGVTdHJpbmcoJmZuYW1lLCBwZm5pX2l0LT5GaWxlTmFtZSwKKwkJCQkJ
ICBwZm5pX2l0LT5GaWxlTmFtZUxlbmd0aCk7CiAJICAgICAgSW5pdGlhbGl6ZU9iamVjdEF0
dHJpYnV0ZXMgKCZhdHRyLCAmZm5hbWUsIDAsIGRpciwgTlVMTCk7CiAJICAgICAgc3RhdHVz
ID0gTnRRdWVyeUF0dHJpYnV0ZXNGaWxlICgmYXR0ciwgJmZiaSk7CiAJICAgICAgLyogSW50
ZW5zaXZlIHRlc3Rpbmcgc2hvd3MgdGhhdCBzb21ldGltZXMgZGlyZWN0b3JpZXMsIGZvciB3
aGljaApAQCAtNjc0LDcgKzY3Niw3IEBAIGNoZWNrX2Rpcl9ub3RfZW1wdHkgKEhBTkRMRSBk
aXIsIHBhdGhfY29udiAmcGMpCiAJCSAgcmV0dXJuIFNUQVRVU19ESVJFQ1RPUllfTk9UX0VN
UFRZOwogCQl9CiAJICAgIH0KLQkgIHBmbmkgPSAoUEZJTEVfTkFNRVNfSU5GT1JNQVRJT04p
ICgoY2FkZHJfdCkgcGZuaSArIHBmbmktPk5leHRFbnRyeU9mZnNldCk7CisJICBwZm5pX2l0
ID0gKFBGSUxFX05BTUVTX0lORk9STUFUSU9OKSAoKGNhZGRyX3QpIHBmbmlfaXQgKyBwZm5p
X2l0LT5OZXh0RW50cnlPZmZzZXQpOwogCX0KICAgICB9CiAgIHdoaWxlIChOVF9TVUNDRVNT
IChOdFF1ZXJ5RGlyZWN0b3J5RmlsZSAoZGlyLCBOVUxMLCBOVUxMLCAwLCAmaW8sIHBmbmks
Ci0tIAoyLjM5LjIKCg==

--------------lKS0lL0R55DIjwDJg2kvXfps
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

--------------lKS0lL0R55DIjwDJg2kvXfps--

- Raw text -