DMARC-Filter:	OpenDMARC Filter v1.4.2 delorie.com 4ABBWaTv3786361
Authentication-Results:	delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results:	delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter:	OpenDKIM Filter v2.11.0 delorie.com 4ABBWaTv3786361
Authentication-Results:	delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=KN4qg3qc
X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org DF8E63858C48
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1731324755;
	bh=Po4DQj130i7X5d0FHceRXWIpd0LGZj0t3HXU3RFtiQU=;
	h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	From;
	b=KN4qg3qcE0u/iYphCmNNTX+bLFfQ6f2R24rSW0O1HMmWbXMfl9WA8Nw04a/5cqjgQ
	aRpiqzZ9TPqIkahRMZlIqAcfHHQqBmstKTdsK0vSohCZ1LMrQmxcZlC4l+A/eWUVnW
	xCl+oMBBHIlzrKdttTmLNKyCTTYhD+qvuaGlCbWE=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org BD9653858D21
ARC-Filter:	OpenARC Filter v1.0.0 sourceware.org BD9653858D21
ARC-Seal:	i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731324732; cv=none;
	b=Nplx6ZgTmSvdXBwAwtloLVWuEb1Y2lPq4p5ptefosR62bbvgLYWqQFYz3HL+IOf2bW/wvz9m4f3zj37X+hJgUVghTJywl3Ei/vrbE5zVzE0Es9TIRzimzP/87X08DMQzvnj0QpI6aEk31vr32YkLe3YDf1RGM1fTkEIio0QRSXs=
ARC-Message-Signature:	i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1731324732; c=relaxed/simple;
	bh=pRMGPDXcg+wonN3qUfpxS+f8tnDpKv/x1L3H3G5ZCRo=;
	h=Date:From:To:Subject:Message-Id:Mime-Version:DKIM-Signature;
	b=jIoNOUhCgeW862jo+7oCkp5ijet3Ad1yaWD/uzXEggBwDty4C0LcqZv2Lf/nBvtPug6zcQebUEAyG1ZmJI8WMidy2/XY3Izfnig2pJF/ziyL12jb6RnsG4d1o7RcR/lttd79bwuRldfT3BRjIudzux+yNoIiTrzo+w7KgVDXsR4=
ARC-Authentication-Results:	i=1; server2.sourceware.org
Date:	Mon, 11 Nov 2024 20:32:02 +0900
To:	cygwin AT cygwin DOT com
Subject:	Re: SMBFS mount's file cannot be made executable
Message-Id:	<20241111203202.b22bcf4f9030aff58299fe0e@nifty.ne.jp>
In-Reply-To:	<20241111201928.811a2f8f09142b7aa8fe9bdc@nifty.ne.jp>
References:	<BL0PR0901MB430827F1A0668E468B498FBBA5D70 AT BL0PR0901MB4308 DOT namprd09 DOT prod DOT outlook DOT com>
	<20241108205109 DOT 55f99e2d172b9fc87e92ae67 AT nifty DOT ne DOT jp>
	<Zy4ODHHpmZPggGSz AT calimero DOT vinschen DOT de>
	<20241111193152 DOT c3a81044a03ecf2093185166 AT nifty DOT ne DOT jp>
	<ZzHizX_6FXABDPvZ AT calimero DOT vinschen DOT de>
	<20241111201928 DOT 811a2f8f09142b7aa8fe9bdc AT nifty DOT ne DOT jp>
X-Mailer:	Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
Mime-Version:	1.0
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Takashi Yano via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
Errors-To:	cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On Mon, 11 Nov 2024 20:19:28 +0900
Takashi Yano via Cygwin <cygwin AT cygwin DOT com> wrote:
> On Mon, 11 Nov 2024 11:56:13 +0100
> Corinna Vinschen wrote:
> > > diff --git a/winsup/cygwin/sec/base.cc b/winsup/cygwin/sec/base.cc
> > > index d5e39d281..c519af6e0 100644
> > > --- a/winsup/cygwin/sec/base.cc
> > > +++ b/winsup/cygwin/sec/base.cc
> > > @@ -681,6 +681,9 @@ convert_samba_sd (security_descriptor &sd_ret)
> > >  				     ace->Header.AceFlags))
> > >  	  return;
> > >        }
> > > +  /* Samba without AD seems to need this. */
> > > +  add_access_allowed_ace (acl, FILE_ALL_ACCESS,
> > > +			  well_known_authenticated_users_sid, acl_len, 0);
> > >    acl->AclSize = acl_len;
> > >  
> > >    RtlCreateSecurityDescriptor (&sd, SECURITY_DESCRIPTOR_REVISION);
> > > 
> > > What do you think?
> > 
> > Giving all authenticated users full permissions to all your files?
> > Unconditionally?  That sounds like opening a security hole wide open.
> 
> Does this really mean such thing? Windows 11 share reports here,
> access mask 0x001201bf for S-1-5-11 is granted. Isn't this simillar?

Even with this patch, the file:

yano $ touch samba_test_file.txt
yano $ ls -l samba_test_files.txt
-rw-r--r-- 1 yano yano 0 Nov 11 20:25 samba_test_file.txt

cannot be written by other users:

someone $ echo BBBB > samba_test_files.txt
samba_test_files.txt: Permission denied.

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -