DKIM-Filter:	OpenDKIM Filter v2.11.0 delorie.com 461BnHvP821643
Authentication-Results:	delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=oslt9Y/X
X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org A77B638133EE
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1719834556;
	bh=dAVEzOMQlbxhyFsSK9lI7PiZGDadCDC66vPmEx4lAQ4=;
	h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	From;
	b=oslt9Y/X0nf0Ff4ErNBiLZC6FoJZSoMn1n3x4cnO0quIZTRbwsSPhi61N9t5AuqD4
	AItEtBd+D1Jd9XnxP5mPFQFqvH1GI5kmbT2LrnybB6cREVs/a93ThVCDGvZDVBdLFB
	53x0qHDmuWUdxvZfd4HK8+Zn0ZRnlHYCrTjOjNQs=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org 1643D381577F
ARC-Filter:	OpenARC Filter v1.0.0 sourceware.org 1643D381577F
ARC-Seal:	i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719834488; cv=none;
	b=TnjcTJ95K5gFvIuv3Hg9GqDpkUZnXf8aHb26tokszjsRxFf2oV02jWvmhm3z0zupCE5FpMfFkTgEkmKD55hnUJZQYy/DsLBHKeb2iIv8aXEcw/E+8uCN9z+xkQOni0/BRYffDZXJSGXiqmfFLjDsfmcowgVZ9iKred/DaeVP5CI=
ARC-Message-Signature:	i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1719834488; c=relaxed/simple;
	bh=U4QFoLOp4eEdEgQClSj5sm2FmISfZCLWGuosFwybngk=;
	h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;
	b=blCIszl2I4wr88offI7+AAly02f2ah+TWJpPr8fbtpzaaKFFhK4tZ++T3Irh3ZfJdLrcmBjBUlPCZgeCc0xBboS1ZMUjsnSce0+AtcWs3ypJ9GLYuah3T+8JVn7pDXK3gG9+XeFayJkZ+6lYLqJNF7VYafeQwY9Sad49tln15rY=
ARC-Authentication-Results:	i=1; server2.sourceware.org
X-UI-Sender-Class:	55c96926-9e95-11ee-ae09-1f7a4046a0f6
Message-ID:	<fb960e5d-ccdd-474b-a046-5178563d4200@johannesthoma.com>
Date:	Mon, 1 Jul 2024 13:47:56 +0200
MIME-Version:	1.0
User-Agent:	Mozilla Thunderbird
Subject:	Re: cygwin application hangs on closing console
To:	cygwin AT cygwin DOT com
References:	<d268ca90-3c5b-4de6-9dd5-320ee713283c AT johannesthoma DOT com>
	<20240423035104 DOT 85352f8a8d821c0f4d569d18 AT nifty DOT ne DOT jp>
	<b71816f0-633c-4eaf-b9d6-955b10e4866a AT johannesthoma DOT com>
	<20240423192606 DOT 7b4aa04685afca2525eb5ed3 AT nifty DOT ne DOT jp>
	<6dd8a568-88c0-42d5-aa46-b09247cdecec AT johannesthoma DOT com>
	<b67fc4f5-3fbb-454a-a0ce-da4f987924dc AT johannesthoma DOT com>
	<d00f900a-e70c-4a2b-9570-0d3c9fcd45d2 AT SystematicSW DOT ab DOT ca>
	<5ed3b0b8-d4f8-454c-951a-fc7b85a7c302 AT johannesthoma DOT com>
	<95442cfe-a87c-4816-b337-b130e481e3f1 AT johannesthoma DOT com>
	<20240628211726 DOT c131e0a300046d1fa46f6b53 AT nifty DOT ne DOT jp>
	<20240629003209 DOT d0bd3cc2961891fb69b55b35 AT nifty DOT ne DOT jp>
In-Reply-To:	<20240629003209.d0bd3cc2961891fb69b55b35@nifty.ne.jp>
X-Provags-ID:	V03:K1:4PvTDz+YTS+Z7fSCv+ZDLD1GMj6hANDBJGaPkt7JeqxTOIoGnd3
	mF8twwYMyA0aAc+XNKdZDv8WHg9uNZTkqfUiYGZj7gJT/usMFr6iPTN7t2THv/8V/nLCvu8
	Tl9NKilLLBjizbYpR44iMSoU4O6gOS7NR6pO2kriMEVCtS0rTYxDxUFDjkWLCmatZSWTLiX
	CRMI9806ISe+70MzuxKbA==
UI-OutboundReport:	notjunk:1;M01:P0:poyqPsXByX8=;k1HDRsUp1ZsqfFhdsu/qhea4gGM
	fxmCPaZr8teBAf/YteWds2wHDrsIyQkvHt76C42ePa05RStsHd28c47pWpgy7drV/yodvlXG8
	/GRwvrHMu3fPi9tIEHPbHF65E3g8JskePaNTwQpENwrlrUf4NLNsJSu1lfewMGaq/WAmJecnr
	GzTw+mejsFDj/wpJCes1RWEpKImv0hNuIiYzwtLWu7m3+CrciOGpOxBj+PN4fzENsquAso3YL
	g/46AtUaBIxtftrSWKke9YMri+8Y0MeB8Y2+QV9Mvkl+q43KSltLRRmpBckQ26Z+VHAENIOop
	mSyC0sO3aS63GyGIc0jcSFuAxtmbXueH1MFJouWfsU2aDfkWzOBBBwOD6VyKGjdtHJoAurrV0
	dd1YDAPS1nNzKD3CmV0ksrxJ3s37NIvZm405qk0oqIbDqJBzekIVk+sl2uRMlm0MfIepLpJYe
	PMRJAyFk8yvnXEtaAKwK5MNeV7fhFiGpUCEMCWuMxN/2uHYcZK8hPgSWNv2PfeX5JAoCTIYod
	RhjII+rKAPE/Mt8c2LLS2VdhME8iyhyLte5e/yeY9p9LRLjg7JcJwg6qnesUUqJIpmj936knU
	VodQsIfrS3Qg3KzLRHk4+7OgaKpimlaUl7Gr8y3cTXScdPkQqKY8e2GHAarSfU6U/ZCC1bOCM
	kPWYtdkoalkwScwvJFdei1xh2v4uqB3urb3wxzlA5gXiAf/7Nmh6+eRXMMlZiWs5agKa8oHaj
	fFKQq0qxNFy7CebRppLBuiilWSIeCXb0yPqiKZ6dxc1dOscn8j7ew8=
X-Spam-Status:	No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS,
	TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version:	SpamAssassin 3.4.6 (2021-04-09) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Johannes Khoshnazar-Thoma via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Johannes Khoshnazar-Thoma <johannes AT johannesthoma DOT com>
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi Takashi Yano,

Thank you for your reply, comments inline.

Am 28.06.24 um 17:32 schrieb Takashi Yano via Cygwin:
> On Fri, 28 Jun 2024 21:17:26 +0900
> Takashi Yano wrote:
>> Sorry for very late replay.
No problem we are all sometimes very busy :)

>>
>> On Mon, 3 Jun 2024 15:20:32 +0200
>> Johannes Khoshnazar-Thoma wrote:
>>> We did more testing and it looks like the name of the event
>>> that signals console master thread start and end is shared between
>>> unrelated processes (it uses the console minor which is always (?)
>>> 0 when running from a powershell).
>>>
>>> So since it is a two-state event (as opposed to a semaphore)
>>> in theory the following can happen:
>>>
>>> Process A	Process B
>>> SetEvent(e)
>>> 		SetEvent(e)
>>> Waitforevent(e)
>>> 		Waitforevent(e)
>>
>> This should not happen. Master thread is unique to console.
>> get_minor() number is always 0 for the first opened console.
>> If you open another powershell window and start cygwin process
>> while the first cygwin process is still active, the get_minor()
>> returns 1.
>>
>> Waiting for thread_sync_event is executed only
>>    if (shared_console_info[unit] && con.owner == myself->pid)
>> con.owner is in the shared memory which is shared among all
>> processes started in the same console. Therefore, only the
>> one process start to wait the event.
>>
>>> The second SetEvent does nothing. As a result the
>>> later Waitforevent is stuck (which is what we observe).
>>>
>>> So the question is: why should this event be used in
>>> unrelated cygwin processes? Is there a technical reason
>>> we don't understand (yet) for doing that (sharing the event).
>>>
>>> We patched cygwin to use pseudo random event names (the
>>> tm_usec field of gettimeofday()) and the stuckness vanished.
>>> So unless there is a reason for sharing the event between
>>> cygwin processes this patch should work:
>>
>> Do you really confirm that your patch resolves the issue?
>> If so, the cause might be some kind of race issue.
>
This patch solved the issue for our case. It was running for
3 days (instead of about 30 minutes) and the hang in console
close did not trigger.

Note that the hang does not happen when just running cygwin
applications via terminal windows (like cmd, powershell and
MinTTY). It triggers however when a cygwin application is
run both as a service (I think as SYSTEM account, but I
can ask again) and from a terminal window.

> There was similar bug in cygwin 3.5.1, however, it has been
> already fixed in 3.5.3.
> https://cygwin.com/git/?p=newlib-cygwin.git;a=commitdiff;h=fc5e9525453fea7c27b0e13635ae54abaa0db69d
>
> I believe your problem is reproducible with 3.5.3. Right?
>
Yes it is. We did long running tests and it is reproducible
with 3.5.3. I also did tests that force the minor being the
same for two cygwin processes (by patching the source code)
and the hang also triggers (after a few minutes).

So can it be that separate cygwin processes can have the
same minor? For example when on is started as a service
and the other is started interactively?

Could you maybe point to the place in the cygwin (winsup)
source code where the minor is allocated?

Thanks again for your hard work on cygwin.

Best regards,

- Johannes

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -