delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin/2024/06/01/12:09:24

DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 451G9Mvc2979387
Authentication-Results: delorie.com;
dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=Ui6psNDp
X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 02CFF38708DA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
s=default; t=1717258161;
bh=N1xLKfDk6SgSSmcfay5S3Q0UKaHt91jwwkuOkWDssS4=;
h=Date:Subject:To:Cc:References:In-Reply-To:List-Id:
List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
From:Reply-To:From;
b=Ui6psNDp1R+ExBsj48r5ixoUGLASem3uv/roPpVEfzJX3jgHa8XKlU+bHnTz0uHA4
K5+MvDsZTMICdAozY4uUt6BXz9GGU9ZIbb8eU/lQOQqKUPkECxyANxiobPQguxSlYJ
HE2qQkWCEZ6KPw24DaA+dSKH3W4gdScok4utaUUQ=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC29738708DA
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DC29738708DA
ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1717258138; cv=pass;
b=etWk8gDUXzD+sw8zFSdkjdvKfswEPjecxmZcrItGyKuHlg+NFyN0khD+SIRz6Z07gsRTYJk/MpY6O3jxwhQlQO3DD6FggqL5eamKiOp0liPhalU3jHZ+GS78hr92j3kSqA/fIMsafQ8T7sykGptP3mGa+bwR36COFGFKF1qrPR8=
ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key;
t=1717258138; c=relaxed/simple;
bh=IasqaU/7E4DD78iKFQ8FZNp1dbTdJbDhCkIwOFzPWCQ=;
h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version;
b=M8yXc4exzbJ7vGE7w9pM4c6CM3uqCsq9O16y2JflB97SzOqcR3fYrnqbI2cZ9kA5da+7OVG0cCFVFWOCvZf53YtKH132uWizG2zGeUJSQFzzCArknZ/lNi+KIrXy1QXLzLgzNAkMWUikvMClpYA/nbdu3KucYptvqdwaed4je0M=
ARC-Authentication-Results: i=2; server2.sourceware.org
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=ZrB65JLopWnBr9XN7bGAKRdIRHMvLFneVYXfIMfh5fnso+UtQ5lbr4B/pvM4zmVCCvJ1XdoVDNtzmK3xoGq9otlorWC1lYvD92FmuyBEWhNH553OmRDVwOHH9YLYr4W09yX6zD5TGKajO6NLxoyUqFrEZcReBsEJjjmmy4bwCjQvuQi1BNifz0ujOBAbjyKEpIJEJz+LX4RBc28+PGz3spJilrdowiVBgDj9o+d530/kRFcgZ3BOoMbaMyxRTKogpRb6gjO8EcqTrsRKdVF24WdTGxi8tM7YbgR1BDrIEAmDWEiKHFBjaXJl+9QvU/wZa46JI/gyXtG9GeE0Xig/5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=UkaE8u/eOM+J8HEUs7DOKezYiwm8btyLNQA9JpEx2RY=;
b=hGV2t1ZrIPcMNTXipZf5dlXqUFWHqIVcnQxgD/9inyfDVMHIxPcqEG77Y6AxILHvrv11LIpPiyzV8QXe29OgzODh2A23EQqVxyYmKGC0MGHFlvCbnxveReRQQ00QRaLAsxae5cjcoqFM9hvcYy5arCpfzwR2oQzQ2C45CqQPWprG1TGsfqkypYVpu4Xf/lw9PCk4dXcMcTz4WgXd+tTT5vJj6RXUizOeS/vUnovApjVkQs7bWNWJN5v6FcA9pN/A3xAjueC2GHN69yQGbV2mchqzcIhftj7npE4e50F+VrO/QzJJuOiYmMVZh3tRv7UfnG0+o6I5dI91MF9S5aJIqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu;
dkim=pass header.d=cornell.edu; arc=none
Message-ID: <8f6e5346-52ff-4682-ae9b-de345399b28c@cornell.edu>
Date: Sat, 1 Jun 2024 12:08:51 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] Cygwin: pthread: Fix a race issue introduced by the
commit 2c5433e5da82
To: Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>, Bruno Haible <bruno AT clisp DOT org>
Cc: cygwin AT cygwin DOT com
References: <20240530050538 DOT 53724-1-takashi DOT yano AT nifty DOT ne DOT jp>
<20240530205012 DOT 2aff4d507acac144e50df2a4 AT nifty DOT ne DOT jp>
<20240530205918 DOT 7c730117b567bb3bec3a0c3f AT nifty DOT ne DOT jp>
<4338587 DOT 3DMzsUbDvx AT nimes>
<20240601231830 DOT 882dc56aadb9c3087bcf4b9c AT nifty DOT ne DOT jp>
In-Reply-To: <20240601231830.882dc56aadb9c3087bcf4b9c@nifty.ne.jp>
X-ClientProxiedBy: BL1P223CA0030.NAMP223.PROD.OUTLOOK.COM
(2603:10b6:208:2c4::35) To SN6PR04MB5151.namprd04.prod.outlook.com
(2603:10b6:805:90::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR04MB5151:EE_|LV3PR04MB9187:EE_
X-MS-Office365-Filtering-Correlation-Id: 6185cf3f-bb07-439d-8e0d-08dc825522d5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?dzZKZkJpZ3hhalNPYVIvVmdDSmZPRVZrZW80YytWZ1p5MmZuMWhzYzdkSHA3?=
=?utf-8?B?T2dFbVZRdldZWERHVG5xYldqQklDZlhqNUtUY1Q3WDZQZGczZkNxQXNUTi93?=
=?utf-8?B?dGs0ais3bkVYeTdja0Z3MEZSZE1TQzVOYzBVZ0c3a2RsLzNzNlVTKzg1Yk9h?=
=?utf-8?B?ZDRKb0luZkM3MlJOVk12Vi9WSHM1WXBObGVQUXhXSm40cEpOdXdGL1JWZnQ1?=
=?utf-8?B?ZmpUTWJrb2M0cm9mWlh0elVWbnlmM0pPOWRkYnpzQ3BMK0FvSEpLZk9iNkxo?=
=?utf-8?B?SE9kSUtYSC9kM1RyM1pjbkdLMVlWbmhpVzB0TmpwSm9QeG03Uzc0MjJjSGYz?=
=?utf-8?B?V2cyL0FFaFBKT3V5STV2VWsrZDcyVTQ5MnNSaG5YdHMwbHRFRmJJaGlCUUpq?=
=?utf-8?B?L3lVUFlPbGZUbDFyZytvVU1aZ0RwNjFTYXFaTDdab2l3aHpiWHhGRHpYaVhw?=
=?utf-8?B?NUY0UU14VUNJZVRnQi9SQU8yQ3YzQWhVek5nZmJIdEVpWi9LV0RIR0lSMzZE?=
=?utf-8?B?SHZpdXdqZnFjRkIwK3NOTVFybk1BU3lFWC9VWDBwdTJ0ZlhNYzlaSTk2YXlZ?=
=?utf-8?B?MXNWZWpBem8zblVURjNqdW8xWFkxenlOTHdnV2pWdFduQUh4WmFOamJ3MEto?=
=?utf-8?B?UFJMMHNOQlFDSDNnbXd6aWxYT0dBalo0Wmw2Mi9sUE54OFhYUlhCVWZ0MnFK?=
=?utf-8?B?YUl2empWRzYrMDJQWXpYQTJpakREdFcxNms4a1VLay9Ta1FsaHNROTQrVUpM?=
=?utf-8?B?ckJiYWlQWFc3WElZdXlXZXRqNnlONmtYZDk2dit6bEJnUUxKVVNmTFUvN09a?=
=?utf-8?B?ZzJ2VU84ODNCSWg3V2psdllFa3paUDhFaUNOTGx6OUVTSmMzU0FvYW82V3dJ?=
=?utf-8?B?Tm9iRUExclBkYVRYZitscTMyVDFMMjlJajBDWk5uQW1WTEsrOUpwcW5VVHMy?=
=?utf-8?B?Um8xSDVsbzNHa1loMEVNZVpqSW00K2pvaU1JMnA1Ni9neEFYeHRqejdkTUlp?=
=?utf-8?B?RVR3ZWd3OUc4cUp4MEVuenB3MVpCNmN3cFQwSVd5ZmpkWHN1YmtCWTJuYkQr?=
=?utf-8?B?b0lxWkt5YkdEMzROd25iOUY2ZG9FNkgvbDcvb25TNWMzbVNDYTNxcGF1Z1V1?=
=?utf-8?B?ZVY4UE5iVW5zTUNEMWRoZndKWDA2elRuZVdWbGdGSlFtMXd4K3hDUnM1R3VT?=
=?utf-8?B?M3hHSFJBZHJXdEdhbWd1WXpRUGI0YldLb2g4YXRFdmpRc3RDb3pBVVlrYzFK?=
=?utf-8?B?L2pMYzd1eVRWQUFkK0JFcG1CakJCSXdCSjZqajhkMWpFa0FRbkppaFRMaGo3?=
=?utf-8?B?USsyTUQ2UWt2aDVtZVZteHhHVStoS3lFK2JMbVJkdkdtdVdock8zRHVDL21j?=
=?utf-8?B?c3RlblQ0ck81d0ZJSmVRZTZuZ1NFOFdURmV5YzMrOExrNlQyZzZSUkZxQ3dw?=
=?utf-8?B?cW1hVEFJZmNpSGxEYlpkMTdiSWFXQkV5TzN0dWtDWGtkdVZRaUc5RHc1TTRL?=
=?utf-8?B?L3N4TWp0R3IvYm5XaHJ6SG5BSzdEbGx1Q1BBcytabSthTk8wK1ovZXhlbVlt?=
=?utf-8?B?ZjVHOHkxZmhRNUkwNlBLQ3VMNlZSbTdFUjF0U2pPTVZkQ1FlR2ZXQWp5dmZI?=
=?utf-8?B?Q3hSYTd0WFl5YnduUG45dkcrSE5KZTVPc2J5TGVDbmJNZzNSK0ZvNTBzOHZQ?=
=?utf-8?B?SnEvMVFydjhjYi9qRkpmWjk0bTdrVFlHTXZRVDZjQWpMb3RvMnplL2tnPT0=?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SN6PR04MB5151.namprd04.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVhxbEhwdnlKaFI0WGRIZDNGYjVscWNKSHYwakpEeFkwdlhBc0RJMjFEVXJM?=
=?utf-8?B?YTBlVFo0RUNZTkswWmIwb1lHRG5BbTdheUZsSmFEZ2tVMzd6NVJLWUxmNktY?=
=?utf-8?B?bDJCMGtlZlVkYU11eVRQT3RWdnpzNTNWL3hISGVOV0piNXljTXJ6czVKY21R?=
=?utf-8?B?NUtiYUErMjNQRDVzRHorWjk2UFFQRkZqOUIxYm9jUFlsVG1YaGg5WWFDc25D?=
=?utf-8?B?SldYdGc3Nm9HUVRYSzdDb01uZmpwaktua0ZzZVBQc2N0aE14R3lpbEhmam95?=
=?utf-8?B?emI3QVRmMUx1WC9McTA2Ly9oUjR6K2hxNURtdHRFWWExM0U3Yldkd29kVHJL?=
=?utf-8?B?M3dINENmVWYzK3pNSGhpZjFTdThiVGlYejhnNzBsc3ZNZDQyallDWmFiUjJC?=
=?utf-8?B?eWRsNGlIdGtTZUFSRmxiZ0dVVE1BMlh4RnVmQXBCYjJhclo3aFF0ZnFtMlZk?=
=?utf-8?B?N2lMMi84Y1RjTjZ5UVVYaXpOWmQ3bFAvSk41TGRSZlllOW1NYVF5Z0NGRkw1?=
=?utf-8?B?YUpaL05paUtiSEhHaExtUTl1QWpYY3lYUG1wbjVSR1N4eFcwV1VjeVFxUGZ6?=
=?utf-8?B?cTRqcVRyZGhMN0I5clF3dGZoenFSY3FnVjR6Z0pwQVNnV0pTWXMvcXRuYVp5?=
=?utf-8?B?ays3bURnckZ4ekxnRm53SnFsUlMzekZMYnNTdVVhellBdjJ0L2dUdnJzMkdl?=
=?utf-8?B?RmM5clJLVXFsYmVLYXI5QllBRmFpeHUwTWF6UThRWmEyc3htNURZd1RESmVN?=
=?utf-8?B?VDR1RWxtblZvTVlzNmYvV3daNGJEQXJFc01WQTJmZXdlVWk5SHNjQ2xDUmJO?=
=?utf-8?B?c1dDbjNlS3VORnNIYmdNWjljUDYvREtkSitDZDNncnU3S1cwOTlaM1IyRzN1?=
=?utf-8?B?OFhBNTFHblRtN0NhOG02VkxLZTFpQTJSSDdxSVdnMkJSc2dMaVhSeUlRWm5w?=
=?utf-8?B?ckREOERNeUhpMjRoWlROY3l2M3BXN2F0TXlxM21WNEk4YjlXellRdUVCei9Z?=
=?utf-8?B?WGZyN2FPUmhaRDdJMFpyS1NoVzRhV2dGVHlMM2pGZDdJQkVHWXg2SEx2UHFo?=
=?utf-8?B?TFRYck5SRFlKL29nb3BOOFB4TG9IT1lhMTkvak5LNUl5eWNFYmkwbzQybWYv?=
=?utf-8?B?SDJjc0NZZ0lLbEJUWnVrWG1qQ2V2aGVhblVQSzR6elVjSFFWOGNBcWZRTkVF?=
=?utf-8?B?dExRMjdvZ0ZaUk1YNWlEcjVwVFB1Y0k5bEQxMHZMckVCN2pFbHQ2QkVCRkh4?=
=?utf-8?B?S3JyNEZDK2JhOEJkYzJZVlhhWEJ2NU5PNkZjMTRITm9qS2pOclpzV3hsOVgx?=
=?utf-8?B?TXJsZlpkSE0wamNoZUJvODRPeGhhUFA2SFdyOXpPN1BhOEVRSVQ3WTFEcjNj?=
=?utf-8?B?T25LTThib3VsMTcwRENYNE41a01TUjVYQUlHT1ZseE80QlFnKzJzMk1WSlB1?=
=?utf-8?B?N2RLUTFKT1dDUkpKOXVjTWNXTWR0UzJLY00ra2RSSGs0V25CZkhUZ1JYWEw4?=
=?utf-8?B?QVptRGhRSGg3dCsra0kybVhrWjJKemI3N3hKd1R0SFRSazhFamNGOFRSdnBL?=
=?utf-8?B?NnhIaVhtbmFVb05xUWZIYUtnaFJZaVJFalB0MkpQdklQcjN2Q2JLKzIyUkoy?=
=?utf-8?B?V09iazYwYlB1L1EzVlFwS016N3NHZ2gvVmN4M2NRb0NoM0NZVzRGT0Q1RGJI?=
=?utf-8?B?MUR6clUyMGZzSWZUYmZMbitHUjI2UTFwaU14QXpxUmQ5azY3OHo5T0ZxcW0z?=
=?utf-8?B?NlpZOExXOCtXNE96djg1Lzg2R0hLUlFXdmMwQW9hOFdGSzlXN28yMXpuRllQ?=
=?utf-8?B?NDdBNm5PcUFVVlJnTDFyaU9JZ1I3TFFwajU0NHEvVm53eGc5aXNVY09Xcllw?=
=?utf-8?B?MVowSEZhZjJGemVrWlBlZE1OaGNKMGQva2krWlF4QzdKUjQyRXN3RmpnbVZr?=
=?utf-8?B?QmcvaTNCSGFvRlh3bUcyb1AvVjhDUUtGQVpRblFIN2dNKytxT1IvbHBrTFlt?=
=?utf-8?B?Q1ZMbVdmajY0UEZMdGNrSnF0MUp4Tk50WlFtb3NVQlFmMzAveGgwTDZubXdM?=
=?utf-8?B?VUtpVjkvb3pteUVFSnQvK0dSbzRNQlgwUng5RnRBZkw2a2Mwa216aDBIODVB?=
=?utf-8?Q?63Zk5JodrREnCaOjIVYlpNAiq?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: 6185cf3f-bb07-439d-8e0d-08dc825522d5
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB5151.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2024 16:08:54.9375 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ct8ILQWQuygeT6/5+tVRsigNQOu16xuU71Wuto+rBq6t869UQfAPy0Q8rc7NNq7A4fH47ISFN3K8TNUJlpK/Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR04MB9187
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, KAM_NUMSUBJECT,
SPF_HELO_PASS, SPF_PASS, TXREP,
T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Ken Brown <kbrown AT cornell DOT edu>
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi Takashi,

On 6/1/2024 10:18 AM, Takashi Yano via Cygwin wrote:
> int
> pthread::once (pthread_once_t *once_control, void (*init_routine) (void))
> {
>    /* Sign bit of once_control->state is used as done flag.
>       Similary, the next significant bit is used as destroyed flag. */

         Typo: Similarly

>    const int done = INT_MIN;		/* 0b1000000000000000 */
>    const int destroyed = INT_MIN >> 1;	/* 0b1100000000000000 */

Shouldn't the constants in the comments have 32 bits?  Other than that, 
LGTM.  (But you should wait for Bruno to confirm before you commit.)

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019