X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org F33A63858439
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1707498203;
	bh=sAA7y2rBjpUel/8yXO9mOQNqHDc+OZbNKskiDBQ/RZ0=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	From;
	b=pwG4XIRqJAgWgu+b3iHI2+fQvAfgan0I7QXYfRBW6lVAGwA/W6QUfyQY6l3tCFHjU
	VN9beTPw3qBmBzA8zCTiUT3NSvqyXZI2pM88+SsdbmcLXWZ6fk1JEgJlCrpeIPpRPb
	4UL6Xuz2zyyHCAwMbFACHHgbK6M35zzJ/ZP2ZQSM=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 6C5C73858D3C
Date:	Fri, 9 Feb 2024 18:02:23 +0100
To:	cygwin AT cygwin DOT com
Subject:	Re: Updated: setup (2.930)
Message-ID:	<ZcZan_0kb3v_Y-jG@calimero.vinschen.de>
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<6a25c776-98bb-4240-8a57-7081324c5a05 AT dronecode DOT org DOT uk>
	<23db00778577ab0853fe1026befb9fe8 AT kylheku DOT com>
	<3391e2e4-da0e-4985-9ec3-a6639f497db9 AT dronecode DOT org DOT uk>
	<ZcZQ5v1Oabbop8XM AT calimero DOT vinschen DOT de>
MIME-Version:	1.0
In-Reply-To:	<ZcZQ5v1Oabbop8XM@calimero.vinschen.de>
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Corinna Vinschen via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	cygwin AT cygwin DOT com
Cc:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
Errors-To:	cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Feb  9 17:20, Corinna Vinschen via Cygwin wrote:
> On Feb  9 13:36, Jon Turney via Cygwin wrote:
> > On 09/02/2024 02:17, Kaz Kylheku via Cygwin wrote:
> > > 
> > > I see the commit: https://cygwin.com/cgit/cygwin-apps/setup/commit/?id=0122154811bacdd7dc042cff0c80bb0a36af360c
> > > 
> > > I'm curious, what improvement arises out of looking up the SetDefaultDllDirectories
> > > function dynamically in kernel32.dll?
> > > 
> > > Is it the case that malicious software can interpose itself somehow such that
> > > the statically linked SetDefaultDllDirectories call goes elsewhere other than
> > > kernel32.dll, which we can thwart by asking for the genuine article in kernel32.dll?
> > 
> > You're looking at the wrong commit there.
> > 
> > The dynamic lookup merely ensures that setup continues to work at all on
> > Windows versions (<6.0), which don't support that function.
> 
> Typo.  Windows < 6.2.  SetDefaultDllDirectories has been introduced with
> Windows 8.

...and with KB2533623 it was also backported to Vista, W7, and the
equivalent server versions, so just ignore me.

Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -