X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 52F653858C54
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1674287325;
	bh=RXSh5CTPEZ4dwrVt61rpWrk0ezUgDUh4EBoN9KHgiE8=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	From;
	b=dYSkdiOWAbyrUpAcm2z6mtQG5Lruu4lfjf6Nik5HDsTr5S8JasprCwLUGiIfNT1ro
	6hMVm1GYYAwvb5V9Y+IoaYaDbC5K/FVVqIPwu33Ef+73XZJqSus9ruvUOk+5LzEFUo
	avz0KyPoGc+9Lp5amcmxS8LR5ytdgT3z0R2EtGOE=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org 3F4E53858D20
X-SONIC-DKIM-SIGN:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
	t=1674287283; bh=qYJBrgL277wDwjjJ5aFc1YKcBs0ZlT0xvudeISzp1na=;
	h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
	b=d9vEJSTPAvUggPYavcTdJu3AByhiGSxiVoPKAH06vXAAe36DgW08woCakhC9VaGkHBesxvWilbhJa+ZbwsF4BgFW548Y3OAb+EIXVHXY43w19A/Woq8z2iFIJLS/98hGnPg0SEx2iBJdXdcRUzuwbu15Af4VNYhPqbNuB22vAFjXoF9WsZ+ZJz9N+yUJl37J+38hB9HuPiLdKq9PKU1q2eflQlF5TG/fo7sLdTwC1Dp9O26MoTBGPClWTcDa3KEIqpKr2SVhBfJ23zfqQMQlsV22fpKN+BccUZrwskoNgDWkS//C+uhHnCcyyoQIBk2OylcDQtM4wcHLpzaNAyLndQ==
X-YMail-OSG:	P_iEk9gVM1k5CztnK0hsDeWnAsPBjmDW_irQm9ZBEHs5aJyduA5NKbkxsoXM63t
	wMIC8vq.9OAcsJyADZnPgyi68uM8tj4BBFCLabHkLuprqGNdNkVDJRYbD3EZiRWCCAa6.0FqJ9eW
	4F1GIsvi4WosB4cd9TAk2h7Gl2wFy2qAuIFyx_yhyTfekZc6g8vXFfObMYt53cDV9ZMjkdz5Qzx.
	loW9Wry5AL8JNuwQnjHEj5fTHJe5_3v0DTBB.DrPS5VJqdlhyBq7QwzzEsXn5dNYGWQjlz8EQ.P0
	nSTvdx6QzpLenPwmJXGAs.1zLC9qnwddLiXLGGfINv.24T5umnp8WbObYblGh2RF.tjiOFidwjyN
	d2h8PGPlP4UsPxw88k7M_.k5Jgc7LWW3DiwvbX7oquLnUceheKx47S_Zz5ISiwfd1hrSV7qYM5HC
	goSzIBd8j2gLwztRmZS52_D9l5Pv.3YHCtdY7ls59MPywJLVd8iJ2quHjFg9YDjjOWTCdN3oDwfW
	mvPiiW55JwnVHChyQUkb9th2c6W3asouj4Ia_ta6zYLNyrMcDrg9oMCdZ2G1uGd_bKZdhWoHYI2S
	V2znyWXXwrR1N9SopULyY_uG7GJNlB9ScRLPbVrvL00ipXSdR6yhsLjVBBXS8Z0yy.E2g17f_Yud
	L9KDz3yHknZupjlROMez42ojt6kEfvtw0MdwUG3fiJa7Py_LkR9fIIXOJD2gyanQd9gNoG5oSgIG
	rkQeD8b9z_3Q2UvTZlSkBHHwXxrQOxjmJ2AVg5Xe14zS_pUCAxg8lDzih.QBY27pJ55DC1ydWQaJ
	TJl1l.mOhO8y356ly_kXL7KjL7sUXCtg4Fd_9LsTFamDYxNiezmGyTLWrZ9WWtUOvRMMLMOD2bh1
	SEK1.3zh1cCTE0gy0BU0ihu6eeGNAYTKLr0T1RApBlmp2EonpoiY4ubVNi4g.0gO_6DKY0Qw9Yfi
	1Oxq2Y63mJyUOVHzk9.I0nrfFmc2ZLhq6ygSp4MXL8yE8K2gPHfYryYEG7sRHXSUZgFryNHeAMPj
	NZVw2jzOqVMYxSfykwvD7K6j3s3FVyOsfVnvFZVxKLGKIeKnCrl1VFYAn9qTDecwYyINRx7HhFtl
	_Zsu9jur_w2_aLx8kttjdurUuwENdRZOW9z8gKx.AVOdLJ_GySi9gtg1emlvBeYG8PDo9vINU0yB
	4EXxMHewAWe58Jub.EODiRfV8GzU49Ef8JLiBqHMWh5nWj4oeD16vSSDqDac6vIo17TO8yvHYj_M
	KpiIqjwsr2mXGAQJg.dLlOxwajqyOGTRU5T9bkJIOe77rUdVdSQw72FEC_xj8dAG7oZY.mvbdXcJ
	cibbp3nyE8K9Zk2nIScV1PcPE.hhG5Fpgr.hF6T9mzn0Y8PSJ0d.sVW2VurD3CSL824PYobcyUjJ
	DoGDdnMxgC.7dDFSFW20cS04U58ZfwWXsmvu08Owp.ak_KG64bp0FOxBTKZZM2a9XonrzSVYUzXM
	MDbItRjr_RYZIpiHuwMZkhAbYGHVwcdOFPhRDinbw.azO3kKO__dfm328Og9fVx_1Oh_EBaleynI
	RygyQjGrVT.wtbE87zJ0ZuZ05YB3SuEFDoDPaVpm9y3dM_mJ8j.nXntk0dY6qWCBbtMAnjM9cLb1
	xDrQkwFLwSUku4JwumHKk5OUc4PBOiAsMCrZJu7Tu.NcCBw2XYdrQx44WHI8sf9dgysRmr25MKaM
	layz6aUfCe3JmC2e3nI6RAyFbnenw9mK7d1FxMohGxLOvAxw_7XTjZvRpqzTrHjSejvwHP2pSt61
	ENj3bfgT.3O2LbPMCm6r6cAo_ibnVx9Y7v45z67z6lpOouIpVKpTGyPAwN8w5FZkYKmx2jYhYCO6
	VA3Zj97kkkVpMCdoEo8DX9A8wiTHou5EwAo0koc0B.KCbSmWQ._2IY9dY2Dp9wES7jRjjrs4wuzX
	OWo2embF.AEAIy2SuN0Tiobyr1.3JroJJVa6rc3019ljz4B1Dup3RAXNBsZkSv3gMtqyuJfm4M4I
	_71jYjPsDX9OqKNOu_Gui9Gm4nfZygiMFevvHb3HFe9orPgT8ggL80WBZnfdTFrggbE1Vx6eRYus
	Waq.WFydcbr14ojw1X0AIav6382pO72v5wqzhh0SwmztRPMY7UjD5pkrQrvl8NVTP5PAxDuf_UFY
	JAEYiF5XhgDEgv9C.IDNvgoRUHdl_arGYp_jsNR_lPFARz0.7lp6XuKRmU5ZbTBmlJrWwUDZy4Dl
	0oGMhEEJ77ev2v_qUHBg-
X-Sonic-MF:	<ardovm AT yahoo DOT it>
Date:	Sat, 21 Jan 2023 08:47:56 +0100
To:	cygwin AT cygwin DOT com
Subject:	Re: compiling issue
Message-ID:	<Y8uYrKpRtDcChB1D@nuvolo>
References:	<034c01d92d57$fc35f6e0$f4a1e4a0$@icloud.com>
MIME-Version:	1.0
In-Reply-To:	<034c01d92d57$fc35f6e0$f4a1e4a0$@icloud.com>
X-Mailer:	WebService/1.1.21096
	mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
X-Spam-Status:	No, score=-0.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS,
	TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version:	SpamAssassin 3.4.6 (2021-04-09) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Arrigo Marchiori via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Arrigo Marchiori <ardovm AT yahoo DOT it>
Errors-To:	cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

--tTopRilTAR6NVyga
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

Hello,

On Fri, Jan 20, 2023 at 09:19:49PM -0800, Nathan via Cygwin wrote:

> The file here for a game I wanted to use is
> http://www.ifarchive.org/if-archive/games/source/Adventure2.5.tar.gz and it
> all compiled but one file getting the error is init.c  as follows: 
> 
> gcc -O  -c init.c
> 
> init.c:167:1: warning: return type defaults to 'int' [-Wimplicit-int]
>   167 | initialise() {
>       | ^~~~~~~~~~
> 
> init.c: In function 'initialise':
> init.c:169:13: warning: implicit declaration of function 'quick_init'
> [-Wimplicit-function-declaration]
>   169 |         if(!quick_init()){raw_init(); report(); quick_save();}
>       |             ^~~~~~~~~~
> 
> init.c:169:27: warning: implicit declaration of function 'raw_init'
> [-Wimplicit-function-declaration]
>   169 |         if(!quick_init()){raw_init(); report(); quick_save();}
>       |                           ^~~~~~~~
>

[...]

> init.c: At top level:
> init.c:173:8: warning: return type defaults to 'int' [-Wimplicit-int]
>   173 | static raw_init() {
>       |        ^~~~~~~~
> 
> init.c:173:8: error: static declaration of 'raw_init' follows non-static
> declaration
> init.c:169:27: note: previous implicit declaration of 'raw_init' with type
> 'int()'
>   169 |         if(!quick_init()){raw_init(); report(); quick_save();}
>       |                           ^~~~~~~~

[...]

> so any tips or suggestions to fix this would be appreciated.

I guess that this code was written to work older compilers, that
allowed different (looser) constructs.

The problem is not Cygwin, but rather the compiler installed with
Cygwin.

For this reason, what follows is off-topic here.

The attached patch should allow compilation with today's compilers.
Copy the file in the same directory as the sources and run:

 $ patch < adventure.patch

I hope this helps.

Best regards,
-- 
Arrigo

--tTopRilTAR6NVyga
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment; filename="adventure.patch"

--- init.c.orig	1996-01-29 23:21:02.000000000 +0100
+++ init.c	2023-01-21 08:35:20.788823913 +0100
@@ -164,13 +164,19 @@
  *	%B = VARIABLE NUMBER OF BLANKS
  *	%! = THE ENTIRE MESSAGE SHOULD BE SUPPRESSED */
 
-initialise() {
+static int quick_init();
+static int raw_init();
+static int finish_init();
+static void report();
+static int quick_save();
+
+void initialise() {
 	printf("Initialising...\n");
 	if(!quick_init()){raw_init(); report(); quick_save();}
 	finish_init();
 }
 
-static raw_init() {
+static int raw_init() {
 	printf("Couldn't find adventure.data, using adventure.text...\n");
 
 /*  CLEAR OUT THE VARIOUS TEXT-POINTER ARRAYS.  ALL TEXT IS STORED IN ARRAY
@@ -366,7 +372,7 @@
  *  CORRECT LINK TO USE.)  ABB IS ZEROED; IT CONTROLS WHETHER THE ABBREVIATED
  *  DESCRIPTION IS PRINTED.  COUNTS MOD 5 UNLESS "LOOK" IS USED. */
 
-static finish_init() {
+static int finish_init() {
 	/* 1101 */ for (I=1; I<=100; I++) {
 	PLACE[I]=0;
 	PROP[I]=0;
@@ -590,7 +596,7 @@
 
 /*  REPORT ON AMOUNT OF ARRAYS ACTUALLY USED, TO PERMIT REDUCTIONS. */
 
-static report() {
+static void report() {
 	/* 1998 */ for (K=1; K<=LOCSIZ; K++) {
 	KK=LOCSIZ+1-K;
 	if(LTEXT[KK] != 0) goto L1997;
@@ -631,8 +637,9 @@
 
 static void quick_item(long*);
 static void quick_array(long*, long);
+static int quick_io();
 
-static quick_init() {
+static int quick_init() {
 #ifdef AMIGA
 	f = fopen("ram:adventure.data", READ_MODE);
 #else
@@ -652,7 +659,7 @@
 	return(init_cksum == 0);
 }
 
-static quick_save() {
+static int quick_save() {
 	printf("Writing adventure.data...\n");
 	f = fopen("adventure.data",WRITE_MODE);
 	if(f == NULL){printf("Can't open file!\n"); return(0);}
@@ -664,7 +671,7 @@
 	return(0);
 }
 
-static quick_io() {
+static int quick_io() {
 	quick_item(&LINUSE);
 	quick_item(&TRVS);
 	quick_item(&CLSSES);

--tTopRilTAR6NVyga
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

--tTopRilTAR6NVyga--

- Raw text -