X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org B57823858426
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1672700700;
	bh=hvSbODCDPJgjuiuVYSt+Ufxb0QYnV5ytUY41lkRDJEk=;
	h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	From;
	b=bvRlLw8Sr5jgC4PCAY3k3lY6mKr7BPTpU+rU/D1S0MnUOBfpDJ3Oh9rpcUTB2OfOa
	sm3djZ3AuCHHsYOUfAO26DMgG9o/BiHtjJTwpfEqZvBK4RKLCKX/fKDrt5LVNEqBmD
	PqtTNDKkCgUcsETZra82VsSaa/gj+PFsbzrgsUC0=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DKIM-Filter:	OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 302N3nuT021834
X-Nifty-SrcIP:	[220.150.135.41]
Date:	Tue, 3 Jan 2023 08:03:50 +0900
To:	cygwin AT cygwin DOT com
Subject:	Re: Cygwin 3.4.3 and 3.5.0... hangs in make, top, procps, ls
	/proc/PID/...
Message-Id:	<20230103080350.04a8f6cd63854e0a49f8942d@nifty.ne.jp>
In-Reply-To:	<20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp>
References:	<4a4427cc-422b-1d14-015e-26523e620d9b AT Shaw DOT ca>
	<20230102113201 DOT 476c10bef7a5643bddc00762 AT nifty DOT ne DOT jp>
X-Mailer:	Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
Mime-Version:	1.0
X-Spam-Status:	No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A,
	RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
	TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version:	SpamAssassin 3.4.6 (2021-04-09) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Takashi Yano via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
Errors-To:	cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Mon, 2 Jan 2023 11:32:01 +0900
Takashi Yano wrote:
> On Thu, 29 Dec 2022 21:59:45 -0700
> Brian Inglis wrote:
> > I got some hangs (deadlock?) between (parallel?) make jobs, top, procps, and 
> > even ls /proc/*/ when trying to cygport all check curl or look at the process 
> > statuses when builds hung under Cygwin 3.4.3 and 3.5.0-0.69...
> > 
> > Had to revert to a Cygwin 3.4.0-344 test build from Dec 16 sources to build and 
> > check curl etc.
> > 
> > Only external differences seems to be recent dll sizes are *MUCH* smaller:
> > 
> > $ ls -glort /bin/cygwin1*.dll
> > -rwxr-xr-x 1 3588124 Sep  5 05:17 /bin/cygwin1-prev.dll
> > -rwxr-xr-x 1 3561202 Dec 16 00:33 /bin/cygwin1-test.dll
> > -rwxr-xr-x 1 3561202 Dec 16 00:33 /bin/cygwin1.dll
> > -rwxr-xr-x 1 2951221 Dec 16 05:50 /bin/cygwin1-save.dll
> > -rwxr-xr-x 1 2951221 Dec 16 05:50 /bin/cygwin1-curr.dll
> > -rwxr-xr-x 1 2940981 Dec 23 03:03 /bin/cygwin1-69.dll
> > 
> > and tars:
> > -rwxr-xr-x 1 3563651 2022-12-04 06:09 usr/bin/cygwin1.dll cygwin-3.4.0-1
> > -rwxr-xr-x 1 3563526 2022-12-10 13:12 usr/bin/cygwin1.dll cygwin-3.4.1-1
> > -rwxr-xr-x 1 3564074 2022-12-11 05:06 usr/bin/cygwin1.dll cygwin-3.4.2-1
> > -rwxr-xr-x 1 2951221 2022-12-16 05:50 usr/bin/cygwin1.dll cygwin-3.4.3-1
> > -rwxr-xr-x 1 2940981 2022-12-23 03:03 usr/bin/cygwin1.dll cygwin-3.5.0-0.69...
> > 
> > Anyone seen this issue or anything come to mind to cause or help diagnose this?
> > 
> > Running MS Win 10.0.19044.2364 21H2 patched to date.
> 
> I have looked into this issue a bit, and found that
> q->sigtls becomes sometimes NULL and access violation
> occurs at the following code.
> 
> winsup/cygwin/sigproc.cc: 1378
> 		if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo)))
> 		  {
> 		    tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait);
> 
> I'm not sure why this happens, however it seems that
> the following patch fixes the issue.
> 
> diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
> index ce36c8be3..90eaa2a47 100644
> --- a/winsup/cygwin/sigproc.cc
> +++ b/winsup/cygwin/sigproc.cc
> @@ -1375,6 +1375,8 @@ wait_sig (VOID *)
>  	    *pack.mask = 0;
>  	    while ((q = q->next))
>  	      {
> +		if (q->sigtls == NULL)
> +		  continue;
>  		if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo)))
>  		  {
>  		    tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait);
> 
> Corinna, could you please have a look?

Do we need to guard here as well?

	case __SIGPENDING:
	  {
	    unsigned bit;

	    *pack.mask = 0;
	    tl_entry = cygheap->find_tls (pack.sigtls);
	    while ((q = q->next))
	      {
		/* Skip thread-specific signals for other threads. */
		if (q->sigtls && pack.sigtls != q->sigtls)
		  continue;
------->	if (pack.sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo)))
		  *pack.mask |= bit;
	      }
	    cygheap->unlock_tls (tl_entry);
	  }
	  break;

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -