X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.1 sourceware.org 41D79385041A
Authentication-Results:	sourceware.org;
	dmarc=fail (p=none dis=none) header.from=nifty.ne.jp
Authentication-Results:	sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp
DKIM-Filter:	OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 24SEPJ7v018730
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp;
	s=dec2015msa; t=1653747919;
	bh=TALt67R/VkL1FfG2jUrptZqNRuPcQwYv1D3RRTLpYG8=;
	h=Date:From:To:Subject:In-Reply-To:References:From;
	b=ms7w3zzJdPI6ov+Fqsm8KOWZWMIdUBylN71ZfeM+N/LJsTI7hUb5uPImPpNn3YiZ0
	g07T/s7cu62IxqEUwyjdii8ckwPMOaD5I6x8Qq5cUjyMdnmfDaD4ZhvDNBs156B2+h
	H5upr+oV5ymopVBplVD+8iQv1xAAhvrfcsO8EvjvsYqOgJgwxAH+ileZcr0F3WhqVU
	6CZZKVrDY3xdNVJH0ryLMbPsxa1bhXMafEE0U9JQP03CqjSFqbgcvZpWudOcMEFllV
	u0QMnuKdZ47XKU393WuvnNgrMUFO2RpQ6jbbISq0wZKlT0hEcRLoB3WtG3CWuuBseS
	3FUcT4OiTCuIw==
X-Nifty-SrcIP:	[119.150.44.95]
Date:	Sat, 28 May 2022 23:25:19 +0900
From:	Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
To:	cygwin AT cygwin DOT com
Subject:	Re: Unable to execute Cygwin application within UDF format
Message-Id:	<20220528232519.5221a03d560fa140e59d1aeb@nifty.ne.jp>
In-Reply-To:	<04783b49-9bd0-da03-805b-d30e6363b7b6@cornell.edu>
References:	<CANe7G9EE5Q9kd7FM=+ERhhB2zBxyNo1Tx7Rbuy=X4svaG2m0fw AT mail DOT gmail DOT com>
	<20220527133120 DOT 58530edd99f4a87c605b8a04 AT nifty DOT ne DOT jp>
	<CANe7G9EZbuKOJt_X2mq1X70Y=tWFiy5_w9fnKp59EgCGQjAUAw AT mail DOT gmail DOT com>
	<20220527181849 DOT 6baaa5d9e8446f3e7d23cbee AT nifty DOT ne DOT jp>
	<20220527195123 DOT abd2d66a17e28b51f1a745a3 AT nifty DOT ne DOT jp>
	<20220527212813 DOT 9bdc5d02d5da3172103bbbce AT nifty DOT ne DOT jp>
	<20220527213629 DOT 64893e46789e0e6f7244b0fd AT nifty DOT ne DOT jp>
	<04783b49-9bd0-da03-805b-d30e6363b7b6 AT cornell DOT edu>
X-Mailer:	Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
Mime-Version:	1.0
X-Spam-Status:	No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A,
	RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
	T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version:	SpamAssassin 3.4.6 (2021-04-09) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Errors-To:	cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Sat, 28 May 2022 09:22:12 -0400
Ken Brown wrote:
> On 5/27/2022 8:36 AM, Takashi Yano wrote:
> > diff --git a/winsup/cygwin/cygheap.cc b/winsup/cygwin/cygheap.cc
> > index 01b49468e..34c9e2bc7 100644
> > --- a/winsup/cygwin/cygheap.cc
> > +++ b/winsup/cygwin/cygheap.cc
> > @@ -183,6 +183,11 @@ init_cygheap::init_installation_root ()
> >   	  if (p)
> >   	    p = wcschr (p + 1, L'\\');  /* Skip share name */
> >   	}
> > +      else
> > +	{
> > +	  len = 4;
> > +	  p = installation_root_buf + 4;
> > +	}
> >       }
> >     installation_root_buf[1] = L'?';
> >     RtlInitEmptyUnicodeString (&installation_key, installation_key_buf,
> 
> This looks right to me.  I would just suggest an explanatory comment, something 
> like this:
> 
> +      else  /* Long path prefix followed by drive letter path */

Thanks for the advice. I will submit the patch to cygwin-patches
mailing list.

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -