X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.1 sourceware.org 6D8EE3857433
Authentication-Results:	sourceware.org;
	dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results:	sourceware.org; spf=pass smtp.mailfrom=gmail.com
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
	h=mime-version:references:in-reply-to:from:date:message-id:subject:to
	:cc; bh=8EU50HvTVVvc+sOiTFSOSG5J4C2LUR2AoCQWX3/fuq8=;
	b=GzYIBXj/91oNGde/sO6RF89HXa6Jqt0BsbQGSFe/vubcnWlF5Zl5Pp9upjYrDP8EiN
	u3UHf2yTvL8PIeGRkpftD05Xg2rU/biA7F/oGeGJcfOskyxj2sUqcfX+8QP316GgZaTu
	x0bEOKAgAUDFtnGtxrxlhhRpZ+x90aiOMB9aWb7eBQl2RsuPpU4G1Nh4G/Ac+TMr3R1f
	gFrPJdJwEbBrfcsCznoVIvUlNkV1z1bjkpLLkykWr54zzshpyLnCPbW6kx6NDojUYH2W
	TwFcY+oIM1mmsB3ysitBNkpRscJ0LJoYRp927tUtCK3DZIZhmvayQcxp17VBV6/Naewu
	cQdA==
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20210112;
	h=x-gm-message-state:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:cc;
	bh=8EU50HvTVVvc+sOiTFSOSG5J4C2LUR2AoCQWX3/fuq8=;
	b=vuywZBN73PD8NccV3u9O8beankNoJ7llUHK15/+Q583ukw/nlmv81RlMf7L8okla3Y
	uj1TEChfeIrT9ZinYmTFkqudIiPQ2Fu8F/vKe/5l1c88kJaJDpfe/9Svb2mQ2/INTtVR
	APuzNyyjCMqNhCrvwX2oRlUNXvhaRXSHI5lwvW+IJXaidIzDab5BQBVDUALpd0ouLGd7
	110DDwkz2PimxLbchBFgC7EbsHT9RuT7To5JtW4Kub5jZw8MnEFv5gxm305vzLt6qHx5
	f5jqUvauiTp7YvrDv1I847yaA0oBtTgtjo1gsuxIcQDtDGbDbH36CbTKJ9bTm2c5FZmu
	UDsA==
X-Gm-Message-State:	AOAM533Ayh6V1QXFmsXm4gltUUuIMFFllwZbNwD+r7wycau0hBCuQf3f
	1ZXYf6UCAPaeibOkM5SGs1qlQGCnYJM9cgd5q4M=
X-Google-Smtp-Source:	ABdhPJxH0XEB4FlN06UxHjnR/5s/Kf+LhTCMSj3W87J2fMc6U43p9L7ruf1ghyhI0v1MPMwG/REASt/UQIlxJRjYM6w=
X-Received:	by 2002:a05:6638:40a5:b0:326:3bad:fe1 with SMTP id
	m37-20020a05663840a500b003263bad0fe1mr8676542jam.127.1651657599267; Wed, 04
	May 2022 02:46:39 -0700 (PDT)
MIME-Version:	1.0
References:	<CAGHpTB+t+gCySabZZQvJstZSLresmoOTUUL8of9cwCdvmGySdg AT mail DOT gmail DOT com>
	<20220504002343 DOT 4345bfe1630fa904276f0d37 AT nifty DOT ne DOT jp>
	<CAGHpTB+3V98eWDaHv7DCa133KWS39FaDFMUo=8qOJjxTFon51A AT mail DOT gmail DOT com>
	<20220504011018 DOT 7c455cedb38571f786d72ae9 AT nifty DOT ne DOT jp>
	<CAGHpTBJyOgYAzEvs3NLb8AzkiujbCKjaf+w-QSJAou47g-J-Cg AT mail DOT gmail DOT com>
In-Reply-To:	<CAGHpTBJyOgYAzEvs3NLb8AzkiujbCKjaf+w-QSJAou47g-J-Cg@mail.gmail.com>
From:	Orgad Shaneh <orgads AT gmail DOT com>
Date:	Wed, 4 May 2022 12:46:28 +0300
Message-ID:	<CAGHpTB+tZX+z0ZkCNG-42bp4Pw+YKUXkccnnNqwN_tHRekk=UA@mail.gmail.com>
Subject:	Re: mintty crashes on Windows 7
To:	Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
X-Spam-Status:	No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT,
	RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version:	SpamAssassin 3.4.4 (2020-01-24) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Cc:	cygwin AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Wed, May 4, 2022 at 12:33 PM Orgad Shaneh <orgads AT gmail DOT com> wrote:
>
> On Tue, May 3, 2022 at 7:10 PM Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp> wrote:
> >
> > On Tue, 3 May 2022 18:52:28 +0300
> > Orgad Shaneh wrote:
> > > On Tue, May 3, 2022 at 6:23 PM Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp> wrote:
> > > >
> > > > On Tue, 3 May 2022 14:47:17 +0300
> > > > Orgad Shaneh wrote:
> > > > > Hi,
> > > > >
> > > > > Running `mintty ./bash` crashes on Windows 7 on cygwin-3_3-branch.
> > > > >
> > > > > Tested in MSYS2 on merge-3.3 branch from
> > > > > https://github.com/orgads/msys2-runtime-1. It includes the tip of
> > > > > cygwin-3_3-branch as of today (05827d2df8).
> > > > >
> > > > I cannot reproduce this with cygwin git head of cygwin-3_3-branch.
> > > > Is this MSYS2 specific problem?
> > >
> > > You're right. I can't reproduce either. Only in my MSYS branch.
> > >
> > > Can you give me some guidance how to debug it?
> >
> > If you could identify which commit causes the issue, It would help.
>
> 0e1847fb87f5306cda6c022540560c5926627ae1 is the first bad commit
> commit 0e1847fb87f5306cda6c022540560c5926627ae1
> Author: Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
> Date:   Mon Feb 28 20:25:09 2022 +0900
>
>     Cygwin: pty: Isolate CTRL_C_EVENTs between ptys.
>
>     - With this patch, unique invisible consoles are created for each pty
>       to isolate CTRL_C_EVENTs between ptys. This is necessary by Ctrl-C
>       handling in fhandler_termios::process_sigs() for non-cygwin apps
>       started in pty if the pseudo console is disabled.
>
>  winsup/cygwin/fhandler_termios.cc |  6 ++----
>  winsup/cygwin/fhandler_tty.cc     | 17 +++++++++++++++++
>  winsup/cygwin/tty.cc              |  2 ++
>  3 files changed, 21 insertions(+), 4 deletions(-)
>
> I tried reverting this commit, and it fixed the crash indeed.
>
> - Orgad

Reduced the revert to this:
@@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
        code does not work as expected because it calls Win32
        API directly rather than cygwin read()/write(). Due to
        this behaviour, protection based on attach_mutex does
        not take effect. */
     get_ttyp ()->need_invisible_console = true;
-  else if (_major (myself->ctty) != DEV_CONS_MAJOR
-    && (!get_ttyp ()->invisible_console_pid
-        || !pinfo (get_ttyp ()->invisible_console_pid)))
-    /* Create a new invisible console for each pty to isolate
-       CTRL_C_EVENTs between ptys. */
-    get_ttyp ()->need_invisible_console = true;
   else
     {
       acquire_attach_mutex (mutex_timeout);
       fhandler_console::need_invisible ();
       release_attach_mutex ();

- Orgad

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -