X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.1 sourceware.org 25DFE385800A
Authentication-Results:	sourceware.org;
	dmarc=fail (p=none dis=none) header.from=nifty.ne.jp
Authentication-Results:	sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp
DKIM-Filter:	OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 22ABX0QW028333
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp;
	s=dec2015msa; t=1646911980;
	bh=J68oJpUiR+Mh2IDccXdh1qlnEXs2Z870vMb/5/MLhoQ=;
	h=Date:From:To:Subject:In-Reply-To:References:From;
	b=gtflvlmPOZfd++VuKe2veflWKvBu8izGcvTc0ueUlEQDsh967x54L5j7bIb6MlFhI
	3CPZEW/Qce9Z2Kpwx2nns/z494QWRS7+6U4/W0h1hbrDcvL75vpBOBMXiYntIR0iU5
	+wS8zA0vSy5Mv9RMmkW5KSzyHuhCbyBMCOD5cP0uFZXeu96jMEr3/4l2Bgh8Rwoxi8
	94Bh1epM9R3XYwVodC2lyholjZzw8WYuqt0lo1QxVSBrCX6KYFFCZv9hxiwvmn4unj
	QgFCd25RajkJOx5WXrdvhN7ubbaBtjZ9mwmt6D7d/kHh9V4QHa94rvvTqhVqau63QA
	2OHt8+TZcxk3Q==
X-Nifty-SrcIP:	[119.150.36.16]
Date:	Thu, 10 Mar 2022 20:33:02 +0900
From:	Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
To:	cygwin AT cygwin DOT com
Subject:	Re: keyboard problem under X and last snapshot (2022-03-01)
Message-Id:	<20220310203302.8c057b480ad959ea2eda177b@nifty.ne.jp>
In-Reply-To:	<20220310181031.9b9c6d6b465fb97a34c99611@nifty.ne.jp>
References:	<FEC414AD-0458-4056-A44B-B5E274493433 AT Denis-Excoffier DOT org>
	<20220310181031 DOT 9b9c6d6b465fb97a34c99611 AT nifty DOT ne DOT jp>
X-Mailer:	Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
Mime-Version:	1.0
X-Spam-Status:	No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE,
	SPF_HELO_NONE, SPF_PASS, TXREP,
	T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version:	SpamAssassin 3.4.4 (2020-01-24) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Errors-To:	cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Thu, 10 Mar 2022 18:10:31 +0900
Takashi Yano wrote:
> On Wed, 9 Mar 2022 22:24:45 +0100
> Denis Excoffier wrote:
> > I tried the last snapshot (dated 2022-03-01), which seems to work well, until i failed to launch X/Windows, giving the
> > following message in a Windows popup: Failed to activate virtual core keyboard: 2
> > 
> > Under the preceding snapshot (dated 2022-02-17) everything works perfectly.
> > 
> > Below the full content of the failing XWin.0.log. Any ideas?
> 
> I noticed this occurs after the commit:
> 
> commit 0ddf19d6ca6edf9edd7fc147124794fa9d5100e0
> Author: Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
> Date:   Mon Feb 21 21:20:48 2022 +0900
> 
>     Cygwin: pty, console: Fix handle leak which occurs on exec() error.
> 
>     - This patch fixes the handle leak which occurs when exec() fails
>       with an error. The duplicated handles will be closed when the
>       exec'ed process is terminated. However, if exec() fails, the code
>       path does not reach to the code closing the duplicated handles.
>       To implement this fix more appropriately, the setup, cleanup and
>       closing pty codes which was previously located in spawn.cc are
>       encapsulated into the fhandler_pty_slave class functions.
> 
> Now, I am looking into this problem. Please wait a while.

I found the cause. The problem was access violation in the code
retrieving the pgid of the ctty.

I will submit a patch shortly.

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -