X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.1 sourceware.org C11AE3858D37
Authentication-Results:	sourceware.org;
	dmarc=none (p=none dis=none) header.from=harkless.org
Authentication-Results:	sourceware.org; spf=pass smtp.mailfrom=yahoo.com
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
	t=1645963716; bh=BSRqYc5XAHAf0F2O73jZxKL/1T24gZIkRJMYOo+5V+o=;
	h=Date:Subject:To:References:From:In-Reply-To:From:Subject:Reply-To;
	b=lShAv4HBwmeyHnRh/JHm0qT2RB0+svmvj0riWeS/RmEjQ4w7Yks+D+JvIctmVqd7+Ff+iyKjbunpuRiKxWph26ZcwSB7DXpXOjDzaui6JLS1BzPhQimHrYVG0ZRyEK782AzYpdcMVVItegU9bZC8k8wMfu9TxDEA0xJjXgLfVZUdvv9aTHane3Esuq2YrumHDKiHzekgiJ6kYCOhZhmrVRhCDP/bCbUHgWRrENawzhNE9Wx9B3BSwOSJ6IdC+/lYGO8aLa1GtUI+33iXBJO0zWApmmQ24mbCyfeqx83BQBFcfsGoN3uD+6WQ16KGIr/oLOf0htlc80AHT2TbZIF0WA==
X-SONIC-DKIM-SIGN:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
	t=1645963716; bh=4g1eQiOVlt0GnyCbLAqx2u3PHlPUV61P+thZXSVX5wX=;
	h=X-Sonic-MF:Date:Subject:To:From:From:Subject;
	b=tMsbJhnzDvGf29YQn9KXAAQmUwT7URKZqCAnqCsvcMAg4yWvvbxOzmpkpujy9IDyLSIVoHepcLqyi8H2q3PDeOH80RNS+z7u6xQyNwRsQrnWnyKILCJi+qQv2J4dWZSolgqPwEbvirxOWtBs5iGFwAQNFbfRzgKC148R/YID9I37jwdVBco4Bv6NiiPMsm1UxFWIhFr0u3Wq4asZueLAc8Nv1ksEKK2TAHVIBuC/bIdUrcqoSRVQ4irceOClmR+NuvlS2fES8+yDD2koI+I7JNg6EuErBuPtabkHdsCfmYL76wMsRqXaQQPjFfY2/oC9bHZhPnkgNHC29BKwwUUcQA==
X-YMail-OSG:	pi2IqkEVM1lPZef_Z6GIdyZl2VRI3NkD4xk5qqwR1p2nVSQ7ZmwKs_0WzspO9jc
	lA3z.NjuL2AnkiFruOz6N9FfxA9y0tmRbFHWF_JgIkzkEem6HkWqBkrteeouvuArjxS1iTIf7Z3W
	zrWliXTbb5uvJEJULPutWvQufB82VsT5i4igO7Q3SMU06fpOrBo0zmOdv_eUsHzZoBCvq3Up9pr5
	LxYPNADMUlAUdoRQ47A9AdwZO80RqHPODEoIr9KsZiGYqbK8z8nBt3SrNZ_WnvLbbltp8PHC1gIk
	_g9XCya7Iw5Ozt5R70auVeAEBMfJe1ZzCd1PTq1cEU2B65QjR3MLD_CEbSKG6IuEd6SsTtCKwUjd
	9Tvv5kUzgCRl10uorRmBMWYDJA0oO.MVF25UTPZ0Yp1dk6.tmogYmAXbwhiFHLP6Q0mI5cBhT5i2
	oVG8mnytqWvBDNBpGL5tfsGPBZM6wVp6JA2ogJurobsCZ_3TZS2.lMLZqHuYAMRSs4cjpCvTDhyB
	SeEhb1AeqimTLuyNUnHC5NzzSkMy6b0Zs6qTuGdZVNmDEKQquEPpxvjPPozcnRWVYHwwId7JCgF1
	4YBTCL1Ok8LEy4XMxHyu0FxSyfhBOO3mOXyPvZCFxgr0NxjJFR3IOjtgiIt7AyENWh81GuZYAhUq
	HFToJw87Z.aU3xoy9Q5NYpnVO0zjlq1tfTyBJAjwjjwFvgIC1ZPTfrzeziC26mEA3Y_8XSUn4jEu
	m8SLJEzHzYYvLq.s1r7FblPjOvqT4tIM3NWWmlS1.Vkgra3R.7e5DDYUrlnlBksvokWzLTMZUvkR
	u_zNgwnsWVMHI_uJZaONzx6W6fydnbvFQmkImK0DNVar6cjHvQrCG_8KgSDq30w2w0fN0pmQaCUU
	FkJZImKK6Jzb8hSp4kzbKMO.2QcAHejzgnR_cCoHxnGZOaE8d4e8G9lURT8nMvj1K0l4CP6s5p8N
	NP.PweZnb65WTofXSPJh3atgnkTQdv2Ueh67YWTr2sWKQ1OD.nJLIcpLlPHDEw2qajF9G.AD_jrO
	c1Orf7Ey3NHlFk9zetRBSqyZa.C4t9rL5.fUQwjznbha.d.DzM_0CpS0aSG1BdIKwM2tX5EIN9Qr
	s4Aqt9zouo7drh_o.2S8Bie1tbCdijwUw4x2Dwak4idaQdtgyIExHgGxTtXWj4jqQaR19gp7Xglz
	Qs89Z7lb4_3e_oj0QyMy0kN9ysv0BSUrI99yczkzrH.UD7Xd6oWOPWh1ajjOlvdzgY7EVRCv5vjG
	ZELXGu6IDIltgkbqPPnd1e6vzHjB.xCUNkkCh4qIZ5RsnRBj7wh8NmvQxZyfwchvgKxJeEEeENDP
	JrIs4Z9EXeBkVL8r0M0Noz9NaaxyyHLKdhfmoLAKl1h0vooKNLHPsT4gMUwq0OyNMdWZC4agzhWq
	Lx_e7WF4pId1JxzSHu8HBGzi1PYYGqbaTxu_jm5OOnyuzz2ml5NcOda3ms9xRo1uXjBkFv7eFciY
	fWFg0_OuZMLayH9yIvII29QGtsPApYfibRUZsaofY11tAOIHGRXjYl2sUu5tFmWj.4FU9RGXP8PE
	WwxSqvlzZRqnB6hOwq_XGphbS80aWqtUdEhBLil9im9.0x4uKEJD4.kOFh_22G2v7JKa1pIkPySq
	pSt9qFLCy.hV_YSoRZNxZgtfYXlOyO3gW310ZYXga.RHfVAq4u7fU5HdWkrK0Nqjl65S8aqmSr8q
	pncAkc2qgGxA4FE3NDXsa2zlqAn205HwYj3AdR.EB87NsjbV7jIHyO3ZJKlsAddNUTtCCLijcc6U
	2iphluoA_vyRW1mz_v0._U3Ccwq63bNH_0AKzkhxuwLy7cZpDlg5DZp8BqAzJQT4NUFsAYo_PiEo
	oLs2urZiwnt.wOFbvQykXsoLFWTZQbeGhDqoDdDzxoj9BEjk70zEi9Tl12QeV0SD8fdtVrp3n5fg
	h8ptj9y0NLZDrn7yQ59g01q.OdIaLWVqRU7HAxLPE8QY2hnc2a6srIwpRTSaTPtrloz4GTh45Ld.
	5DRumiHMu2acWR.wsmcbsPlKAiX.tB4XtSYF.UHxhlqiRi11cA0p.7WDw4zzFttHJDT7zUCMdwyW
	5c765tGAjpeMQABpBmz8pw29YZqmFlLSHCcbOrvbXJaa0bGAWJtNhM6KuEiw.dNG0M5Q1xBiZ3cS
	8KmMX.ohuqSEtEA5Xfbm6c41EBuvzLSEVLCzadnipRKsV0tg7LE7lEt48yue0uCYtYSSrgihaQIe
	JNej2Zfd41nXilZ.LP6hYgmQp_A--
X-Sonic-MF:	<dan_harkless AT yahoo DOT com>
Message-ID:	<4ce6d539-09c4-da8d-9e17-80df3667d8aa@harkless.org>
Date:	Sun, 27 Feb 2022 04:06:32 -0800
MIME-Version:	1.0
User-Agent:	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
	Thunderbird/91.6.1
Subject:	Re: Patches to findutils 4.9.0-1's updatedb to do locking, allow
	filenames with spaces & progress monitoring, exclude /dev on Cygwin, etc.
To:	Bernhard Voelker <mail AT bernhard-voelker DOT de>, bug-findutils AT gnu DOT org,
	cygwin AT cygwin DOT com
References:	<986736274 DOT 144968 DOT 1630167325057 DOT ref AT mail DOT yahoo DOT com>
	<986736274 DOT 144968 DOT 1630167325057 AT mail DOT yahoo DOT com>
	<a60ffa68-274a-5072-c90a-0dce7bc93431 AT harkless DOT org>
	<3457cee1-18b5-2916-adee-afdfaf9769ea AT t-online DOT de>
	<525a832a-78fd-5a32-e195-5747120da922 AT harkless DOT org>
	<a3772125-f8a0-05fb-2dc5-c3a650fed7c8 AT SystematicSw DOT ab DOT ca>
	<88b29ca4-313f-2318-c2ed-b55f86aafac0 AT harkless DOT org>
	<f5455ae6-a91c-b948-1c21-133cec1816f8 AT bernhard-voelker DOT de>
From:	Dan Harkless <cygwin-list21 AT harkless DOT org>
In-Reply-To:	<f5455ae6-a91c-b948-1c21-133cec1816f8@bernhard-voelker.de>
X-Mailer:	WebService/1.1.19797
	mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
X-Spam-Status:	No, score=-0.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,
	HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version:	SpamAssassin 3.4.4 (2020-01-24) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Errors-To:	cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>
X-MIME-Autoconverted:	from base64 to 8bit by delorie.com id 21RC8t41021005

On 2/27/2022 3:54 AM, Bernhard Voelker wrote:
> On 2/24/22 17:32, Dan Harkless wrote:
>> I'm finally getting around to sending in a patch (to bug-findutils and
>> the Cygwin list, to which I'm currently subscribed) to address these
>> issues, along with some others, a few of which represent small changes
>> in behavior:
> Thanks for the patch ... but:

Thanks for taking a look at it.

> a) The patch does not cleanly apply:
>
>    ~/findutils/locate> patch -t < /tmp/updatedb.patch
>    patching file updatedb
>    Reversed (or previously applied) patch detected!  Assuming -R.
>    Hunk #2 succeeded at 47 with fuzz 2.
>    Hunk #7 FAILED at 167.
>    Hunk #8 FAILED at 202.
>    Hunk #9 succeeded at 217 (offset -2 lines).
>    Hunk #10 succeeded at 276 (offset -2 lines).
>    2 out of 10 hunks FAILED -- saving rejects to file updatedb.rej

Ah.  As I mentioned, my patch was against Cygwin's findutils 4.9.0-1, 
and since my Linux systems use a different version of locate, I hadn't 
tested there (nor did I have time to look at the original 4.9.0 
source).  I'd been hoping any Cygwin patches wouldn't invalidate it; pity.

> b) The patch changes the file 'updatedb' which is created at build time
> instead of the file 'updatedb.sh' which is under version control.

Gotcha.

> c) The description says that there are 10 more or less non-trivial
> changes in it.  A squashed diff of 500 lines on a file with 342 lines
> makes reviewing and discussing of each topic impossible.

Impossible?  Since the bulk of the changes are spacing changes to 
standardize code indentation across the file, I was hoping the separate 
'diff -uw' listing would be sufficient to enable easy review and discussion.

> Would you mind re-sending as separate Git patches?

It'll be awhile before I'll have time to get set up to do that, but will do.

> Have a nice day,
> Berny

Thanks again,
Dan Harkless
http://harkless.org/dan/


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -