X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.1 sourceware.org DE599385B83A
Authentication-Results:	sourceware.org; dmarc=none (p=none dis=none)
	header.from=dronecode.org.uk
Authentication-Results:	sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk
Authentication-Results:	btinternet.com;
	auth=pass (PLAIN) smtp.auth=jonturney AT btinternet DOT com;
	bimi=skipped
X-SNCR-Rigid:	6139429013B99019
X-Originating-IP:	[213.120.30.10]
X-OWM-Source-IP:	213.120.30.10 (GB)
X-OWM-Env-Sender:	jonturney AT btinternet DOT com
X-VadeSecure-score:	verdict=clean score=0/300, class=clean
X-RazorGate-Vade:	gggruggvucftvghtrhhoucdtuddrgedvvddrgeefgddufeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeffkeeigfdujeehteduiefgjeeltdelgeelteekudetfedtffefhfeufefgueettdenucfkphepvddufedruddvtddrfedtrddutdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtfegnpdhinhgvthepvddufedruddvtddrfedtrddutddpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedupdhrtghpthhtoheptgihghifihhnsegthihgfihinhdrtghomh
X-RazorGate-Vade-Verdict:	clean 0
X-RazorGate-Vade-Classification:	clean
Message-ID:	<eef4ada5-0ace-d828-c163-988390aa35e0@dronecode.org.uk>
Date:	Tue, 1 Feb 2022 20:33:10 +0000
MIME-Version:	1.0
User-Agent:	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
	Thunderbird/91.5.1
Subject:	Re: [PATCH cygport 1/2] postinst: Never remove an existing
	.gnu_debuglink
To:	The Cygwin Mailing List <cygwin AT cygwin DOT com>
References:	<20220201172519 DOT 14881-1-jon DOT turney AT dronecode DOT org DOT uk>
	<20220201172519 DOT 14881-2-jon DOT turney AT dronecode DOT org DOT uk>
	<YfmIbMQvjqL8yW3S AT calimero DOT vinschen DOT de>
From:	Jon Turney <jon DOT turney AT dronecode DOT org DOT uk>
In-Reply-To:	<YfmIbMQvjqL8yW3S@calimero.vinschen.de>
X-Spam-Status:	No, score=-3578.1 required=5.0 tests=BAYES_00, FORGED_SPF_HELO,
	GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A,
	RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP,
	T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version:	SpamAssassin 3.4.4 (2020-01-24) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Errors-To:	cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On 01/02/2022 19:22, Corinna Vinschen wrote:
> Hi Jon,
> 
> On Feb  1 17:25, Jon Turney wrote:
>> Be more careful not to remove an existing .gnu_debuglink, even if we
>> think this package has no useful debug symbols.
>>
>> (Some versions of 'llvm-objdump -l' fail to find line number info even
>> though it's there.  Don't break a package which manages it's own debug
>> symbols (e.g. cygwin) when that happens.)
>> ---
>>   lib/src_postinst.cygpart | 28 ++++++++++++++++++----------
>>   1 file changed, 18 insertions(+), 10 deletions(-)
>>
>> diff --git a/lib/src_postinst.cygpart b/lib/src_postinst.cygpart
>> index d8bb226..e29b2cb 100644
>> --- a/lib/src_postinst.cygpart
>> +++ b/lib/src_postinst.cygpart
>> @@ -1051,23 +1051,31 @@ __prepstrip() {
>>   
>>   			lines=$(${objdump} -d -l "${exe}" 2>/dev/null | sed -ne "s|.*\(/usr/src/debug/${PF}/.*\):[0-9]*$|\1|gp" | sort -u | tee -a ${T}/.dbgsrc.out | wc -l);
> 
> Shouldn't lines be computed *after* the new check for .gnu_deb?  After
> all, it's still pretty time-consuming and if the .gnu_deb check kicks in
> it's never tested...

The objdump invocation has the side effect of creating ${T}/.dbgsrc.out, 
which is later used to determine what source files to put into the 
debuginfo package.



-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -