X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 58D23385700B
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1611929934;
	bh=MjkV5ASN7AhnwomUo7f1SRbXq8CqUcE0Ne8lvkA+SeM=;
	h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	From;
	b=dT3lPoKOsr7xAHQked10I635KL878bSJ/nE2AbZqRPQrOU0cvri0GylMlkWSb5RiD
	auuwqg+u20YC8N7ajHEoN8bjk/dyAFw9iN7u3PoYAQfKx8j85xCpFKWWOy1PJzlN7Z
	puqsktTdMqUZ4PDMJOePy6G9052ZgByOd4cevilg=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 97807385700B
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:subject:to:references:from:message-id:date
	:user-agent:mime-version:in-reply-to:content-language
	:content-transfer-encoding;
	bh=TthwZkYQVuZGCUzYwvazKQ7xLsNO6lwWIQgNRPr/x98=;
	b=KniIY1nabNyWo4UL5s138YH85tX4a54AnGqlKAXnzJ748lcPWB9J3chfemgrLcytlB
	R/s2wry+ylxgad8i9g3lDeqZG0fOwIET/Mda1jOERI2xuGwtsNvdNxna5KNpi5TtZfam
	x08rdnCtOWFvmAsU1HOsumugO8JUllzZwBAYqAUkes87/J1CMr5ATTtqUHHjIXvbXJzP
	VXdLeEtQnlhXDmQzLKWkNh+6zm5uRXBl/wjjkkwBqHygFEIiI3ZEyc1q7PVL1jEcYDir
	es9PyFvSOZLqYxkgey4bS2cyqlDdt8CfePYAp8ytQ9HrDIekJIOt5ILezonbVbpGGKSU
	3OzQ==
X-Gm-Message-State:	AOAM531USYpfgZ/r2VLOzsV3YO3QSbETDxUqXnmFk/wQno3nEx8sr9dJ
	tP5/y3QXKE+/zzegPDSW0evZv1Yv85nUZQ==
X-Google-Smtp-Source:	ABdhPJx5IbTzBeE7emI11bAmly13jO4uZtIVP8hGbufkgPuJzQdrFqx520iF7oYtKsHLzFRGJVNNXw==
X-Received:	by 2002:a17:906:2755:: with SMTP id
	a21mr4833738ejd.374.1611929929662;
	Fri, 29 Jan 2021 06:18:49 -0800 (PST)
Subject:	Re: python-cython C++ support patch
To:	cygwin AT cygwin DOT com
References:	<20210129 DOT 193143 DOT 371461372727925270 DOT trueroad AT trueroad DOT jp>
Message-ID:	<7edac602-ab79-7421-f5f8-929c7fa68428@gmail.com>
Date:	Fri, 29 Jan 2021 15:18:36 +0100
User-Agent:	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
	Thunderbird/78.7.0
MIME-Version:	1.0
In-Reply-To:	<20210129.193143.371461372727925270.trueroad@trueroad.jp>
X-Spam-Status:	No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A,
	RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
	TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Marco Atzeri via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Marco Atzeri <marco DOT atzeri AT gmail DOT com>
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>

On 29.01.2021 11:31, Masamichi Hosoda wrote:
> Hi,
> 
> I've found that modules built by python-cython with C++ could not be loaded.
> If I understand correctly, the following patch fixes it.
> Would you like to apply this patch to the package?
> 
> ```
> --- a/Cython-0.29.21/Cython/Utility/ModuleSetupCode.c
> +++ b/Cython-0.29.21/Cython/Utility/ModuleSetupCode.c
> @@ -709,7 +709,11 @@
>   /////////////// PyModInitFuncType.proto ///////////////
>   
>   #ifndef CYTHON_NO_PYINIT_EXPORT
> +#ifdef __cplusplus
> +#define __Pyx_PyMODINIT_FUNC  extern "C" PyObject *
> +#else
>   #define __Pyx_PyMODINIT_FUNC  PyObject *
> +#endif
>   
>   #elif PY_MAJOR_VERSION < 3
>   // Py2: define this to void manually because PyMODINIT_FUNC adds __declspec(dllexport) to it's definition.
> ```
> 
> Thanks.

Thanks Masamichi,

it seems in line with similar patches that I have applied to some
other python sub packages

Have you a test case for this one ?

I will look to rebuilt python-cython after some extra check

Marco



--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -